====================================================== WARNING: possible circular locking dependency detected 5.15.180-syzkaller #0 Not tainted ------------------------------------------------------ syz.8.884/9692 is trying to acquire lock: ffff88805bc24da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314 but task is already holding lock: ffff88805bc25108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] ffff88805bc25108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9){+.+.}-{3:3}: down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:787 [inline] ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2826 quota_setquota+0x4ac/0x530 fs/quota/quota.c:309 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl+0x295/0x6c0 fs/quota/quota.c:915 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x5a/0x410 fs/quota/dquot.c:507 ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6180 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x1e3/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0x5d0/0xe20 fs/quota/dquot.c:1752 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xf68/0x4940 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x146c/0x64e0 fs/ext4/extents.c:4339 ext4_map_blocks+0x9cd/0x1c60 fs/ext4/inode.c:672 ext4_getblk+0x16d/0x630 fs/ext4/inode.c:869 ext4_bread+0x26/0x180 fs/ext4/inode.c:922 ext4_append+0x2c3/0x560 fs/ext4/namei.c:83 ext4_init_new_dir+0x2a2/0x940 fs/ext4/namei.c:3030 ext4_mkdir+0x47d/0xc50 fs/ext4/namei.c:3076 vfs_mkdir+0x387/0x570 fs/namei.c:4065 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #4 (&ei->i_data_sem){++++}-{3:3}: down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ext4_map_blocks+0x901/0x1c60 fs/ext4/inode.c:665 mpage_map_one_extent fs/ext4/inode.c:2407 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline] ext4_writepages+0x12ca/0x2d20 fs/ext4/inode.c:2828 do_writepages+0x48d/0x6d0 mm/page-writeback.c:2386 __writeback_single_inode+0x153/0xda0 fs/fs-writeback.c:1647 writeback_sb_inodes+0x9fe/0x1610 fs/fs-writeback.c:1930 __writeback_inodes_wb+0x12a/0x3f0 fs/fs-writeback.c:2001 wb_writeback+0x455/0xb90 fs/fs-writeback.c:2106 wb_check_background_flush fs/fs-writeback.c:2172 [inline] wb_do_writeback fs/fs-writeback.c:2260 [inline] wb_workfn+0xb47/0xe60 fs/fs-writeback.c:2288 process_one_work+0x863/0x1000 kernel/workqueue.c:2310 worker_thread+0xaa8/0x12a0 kernel/workqueue.c:2457 kthread+0x436/0x520 kernel/kthread.c:334 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:354 ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361 ocfs2_create+0x192/0x410 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x11e1/0x2f30 fs/namei.c:3739 do_filp_open+0x1b3/0x3e0 fs/namei.c:3769 do_sys_openat2+0x142/0x4a0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x135/0x160 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:352 ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361 ocfs2_create+0x192/0x410 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x11e1/0x2f30 fs/namei.c:3739 do_filp_open+0x1b3/0x3e0 fs/namei.c:3769 do_sys_openat2+0x142/0x4a0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x135/0x160 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (sb_internal#3){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1928 [inline] ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:350 ocfs2_write_info+0x117/0x350 fs/ocfs2/quota_global.c:982 dquot_set_dqinfo+0x459/0x6c0 fs/quota/dquot.c:2904 quota_setinfo+0x2a4/0x2b0 fs/quota/quota.c:173 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl+0x295/0x6c0 fs/quota/quota.c:915 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2826 quota_setquota+0x4ac/0x530 fs/quota/quota.c:309 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl+0x295/0x6c0 fs/quota/quota.c:915 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9); lock(&dquot->dq_lock); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9); lock(&ocfs2_quota_ip_alloc_sem_key); *** DEADLOCK *** 3 locks held by syz.8.884/9692: #0: ffff888028b920e0 (&type->s_umount_key#71){++++}-{3:3}, at: user_get_super+0x118/0x240 fs/super.c:850 #1: ffff88805f6180a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x290/0xaf0 fs/ocfs2/quota_global.c:811 #2: ffff88805bc25108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #2: ffff88805bc25108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#9){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313 stack backtrace: CPU: 0 PID: 9692 Comm: syz.8.884 Not tainted 5.15.180-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call Trace: dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2826 quota_setquota+0x4ac/0x530 fs/quota/quota.c:309 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl+0x295/0x6c0 fs/quota/quota.c:915 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f7345459969 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f734327f038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007f7345681160 RCX: 00007f7345459969 RDX: 0000000000000000 RSI: 0000200000000200 RDI: ffffffff80000801 RBP: 00007f73454dbab1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000200000000240 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000001 R14: 00007f7345681160 R15: 00007ffe39b54c98