======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor234/8099 is trying to acquire lock:
00000000555464bb (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457

but task is already holding lock:
00000000080a29cf (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock){+.+.}:
       hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263
       notify_change+0x70b/0xfc0 fs/attr.c:334
       do_truncate+0x134/0x1f0 fs/open.c:63
       handle_truncate fs/namei.c:3009 [inline]
       do_last fs/namei.c:3427 [inline]
       path_openat+0x2308/0x2df0 fs/namei.c:3537
       do_filp_open+0x18c/0x3f0 fs/namei.c:3567
       do_sys_open+0x3b3/0x520 fs/open.c:1085
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:937 [inline]
       __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
       hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357
       hfsplus_rename_cat+0x272/0x1490 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x119/0x200 fs/hfsplus/dir.c:550
       vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
       do_renameat2+0xb59/0xc70 fs/namei.c:4629
       __do_sys_renameat2 fs/namei.c:4664 [inline]
       __se_sys_renameat2 fs/namei.c:4661 [inline]
       __x64_sys_renameat2+0xba/0x150 fs/namei.c:4661
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

7 locks held by syz-executor234/8099:
 #0: 00000000769a8d35 (sb_writers#11){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
 #0: 00000000769a8d35 (sb_writers#11){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360
 #1: 000000003e83cdad (&type->s_vfs_rename_key){+.+.}, at: lock_rename+0x54/0x280 fs/namei.c:2867
 #2: 00000000a23554ee (&type->i_mutex_dir_key#7/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
 #2: 00000000a23554ee (&type->i_mutex_dir_key#7/1){+.+.}, at: lock_rename+0xa0/0x280 fs/namei.c:2871
 #3: 000000000b866afa (&sb->s_type->i_mutex_key#17/2){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
 #3: 000000000b866afa (&sb->s_type->i_mutex_key#17/2){+.+.}, at: lock_rename+0xd4/0x280 fs/namei.c:2872
 #4: 00000000e1d3d9d7 (&sb->s_type->i_mutex_key#17){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
 #4: 00000000e1d3d9d7 (&sb->s_type->i_mutex_key#17){+.+.}, at: lock_two_nondirectories+0xec/0x110 fs/inode.c:1015
 #5: 00000000f8e11bf9 (&sb->s_type->i_mutex_key#17/4){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
 #5: 00000000f8e11bf9 (&sb->s_type->i_mutex_key#17/4){+.+.}, at: lock_two_nondirectories+0xd1/0x110 fs/inode.c:1017
 #6: 00000000080a29cf (&tree->tree_lock){+.+.}, at: hfsplus_find_init+0x1b7/0x220 fs/hfsplus/bfind.c:30

stack backtrace:
CPU: 0 PID: 8099 Comm: syz-executor234 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 __mutex_lock_common kernel/locking/mutex.c:937 [inline]
 __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
 hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357
 hfsplus_rename_cat+0x272/0x1490 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x119/0x200 fs/hfsplus/dir.c:550
 vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
 do_renameat2+0xb59/0xc70 fs/namei.c:4629
 __do_sys_renameat2 fs/namei.c:4664 [inline]
 __se_sys_renameat2 fs/namei.c:4661 [inline]
 __x64_sys_renameat2+0xba/0x150 fs/namei.c:4661
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f597a74aa19
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe754e9738 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RA