======================================================== WARNING: possible irq lock inversion dependency detected 6.5.0-syzkaller-04592-gd68b4b6f307d #0 Not tainted -------------------------------------------------------- syz-executor.3/15942 just changed the state of lock: ffffffff8d951bf8 (disc_data_lock){.?..}-{2:2}, at: ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 but this lock was taken by another, HARDIRQ-safe lock in the past: (&port_lock_key){-.-.}-{2:2} and interrupts could create inverse lock ordering between them. other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(disc_data_lock); local_irq_disable(); lock(&port_lock_key); lock(disc_data_lock); lock(&port_lock_key); *** DEADLOCK *** 1 lock held by syz-executor.3/15942: #0: ffff888033179098 (&tty->ldisc_sem){++++}-{0:0}, at: tty_ldisc_ref_wait+0x24/0x80 drivers/tty/tty_ldisc.c:243 the shortest dependencies between 2nd lock and 1st lock: -> (&port_lock_key){-.-.}-{2:2} { IN-HARDIRQ-W at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x3a/0x50 kernel/locking/spinlock.c:162 serial8250_handle_irq+0x91/0xbd0 drivers/tty/serial/8250/8250_port.c:1914 serial8250_default_handle_irq+0x94/0x210 drivers/tty/serial/8250/8250_port.c:1960 serial8250_interrupt+0xfc/0x200 drivers/tty/serial/8250/8250_core.c:127 __handle_irq_event_percpu+0x22a/0x740 kernel/irq/handle.c:158 handle_irq_event_percpu kernel/irq/handle.c:193 [inline] handle_irq_event+0xab/0x1e0 kernel/irq/handle.c:210 handle_edge_irq+0x261/0xcf0 kernel/irq/chip.c:831 generic_handle_irq_desc include/linux/irqdesc.h:161 [inline] handle_irq arch/x86/kernel/irq.c:238 [inline] __common_interrupt+0xdb/0x300 arch/x86/kernel/irq.c:257 common_interrupt+0xa9/0xd0 arch/x86/kernel/irq.c:247 asm_common_interrupt+0x26/0x40 arch/x86/include/asm/idtentry.h:636 native_safe_halt arch/x86/include/asm/irqflags.h:48 [inline] arch_safe_halt arch/x86/include/asm/irqflags.h:86 [inline] acpi_safe_halt+0x1b/0x20 drivers/acpi/processor_idle.c:112 acpi_idle_enter+0xc5/0x160 drivers/acpi/processor_idle.c:707 cpuidle_enter_state+0x82/0x500 drivers/cpuidle/cpuidle.c:267 cpuidle_enter+0x4e/0xa0 drivers/cpuidle/cpuidle.c:388 cpuidle_idle_call kernel/sched/idle.c:215 [inline] do_idle+0x315/0x3f0 kernel/sched/idle.c:282 cpu_startup_entry+0x18/0x20 kernel/sched/idle.c:379 start_secondary+0x20e/0x2a0 arch/x86/kernel/smpboot.c:326 secondary_startup_64_no_verify+0x166/0x16b IN-SOFTIRQ-W at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x3a/0x50 kernel/locking/spinlock.c:162 serial8250_handle_irq+0x91/0xbd0 drivers/tty/serial/8250/8250_port.c:1914 serial8250_default_handle_irq+0x94/0x210 drivers/tty/serial/8250/8250_port.c:1960 serial8250_interrupt+0xfc/0x200 drivers/tty/serial/8250/8250_core.c:127 __handle_irq_event_percpu+0x22a/0x740 kernel/irq/handle.c:158 handle_irq_event_percpu kernel/irq/handle.c:193 [inline] handle_irq_event+0xab/0x1e0 kernel/irq/handle.c:210 handle_edge_irq+0x261/0xcf0 kernel/irq/chip.c:831 generic_handle_irq_desc include/linux/irqdesc.h:161 [inline] handle_irq arch/x86/kernel/irq.c:238 [inline] __common_interrupt+0xdb/0x300 arch/x86/kernel/irq.c:257 common_interrupt+0x51/0xd0 arch/x86/kernel/irq.c:247 asm_common_interrupt+0x26/0x40 arch/x86/include/asm/idtentry.h:636 deref_stack_reg arch/x86/kernel/unwind_orc.c:406 [inline] unwind_next_frame+0xdaa/0x2390 arch/x86/kernel/unwind_orc.c:585 __unwind_start+0x5a4/0x880 arch/x86/kernel/unwind_orc.c:760 unwind_start arch/x86/include/asm/unwind.h:64 [inline] arch_stack_walk+0xaf/0x170 arch/x86/kernel/stacktrace.c:24 stack_trace_save+0x96/0xd0 kernel/stacktrace.c:122 kasan_save_stack+0x33/0x50 mm/kasan/common.c:45 kasan_set_track+0x25/0x30 mm/kasan/common.c:52 kasan_save_free_info+0x2b/0x40 mm/kasan/generic.c:522 ____kasan_slab_free mm/kasan/common.c:236 [inline] ____kasan_slab_free+0x15b/0x1b0 mm/kasan/common.c:200 kasan_slab_free include/linux/kasan.h:162 [inline] slab_free_hook mm/slub.c:1800 [inline] slab_free_freelist_hook+0x114/0x1e0 mm/slub.c:1826 slab_free mm/slub.c:3809 [inline] kmem_cache_free+0xf0/0x480 mm/slub.c:3831 rcu_do_batch kernel/rcu/tree.c:2139 [inline] rcu_core+0x7fb/0x1bb0 kernel/rcu/tree.c:2403 __do_softirq+0x218/0x965 kernel/softirq.c:553 invoke_softirq kernel/softirq.c:427 [inline] __irq_exit_rcu kernel/softirq.c:632 [inline] irq_exit_rcu+0xb7/0x120 kernel/softirq.c:644 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1109 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:645 native_safe_halt arch/x86/include/asm/irqflags.h:48 [inline] arch_safe_halt arch/x86/include/asm/irqflags.h:86 [inline] acpi_safe_halt+0x1b/0x20 drivers/acpi/processor_idle.c:112 acpi_idle_enter+0xc5/0x160 drivers/acpi/processor_idle.c:707 cpuidle_enter_state+0x82/0x500 drivers/cpuidle/cpuidle.c:267 cpuidle_enter+0x4e/0xa0 drivers/cpuidle/cpuidle.c:388 cpuidle_idle_call kernel/sched/idle.c:215 [inline] do_idle+0x315/0x3f0 kernel/sched/idle.c:282 cpu_startup_entry+0x18/0x20 kernel/sched/idle.c:379 start_secondary+0x20e/0x2a0 arch/x86/kernel/smpboot.c:326 secondary_startup_64_no_verify+0x166/0x16b INITIAL USE at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x3a/0x50 kernel/locking/spinlock.c:162 serial8250_do_set_termios+0x334/0x1240 drivers/tty/serial/8250/8250_port.c:2791 serial8250_set_termios+0x6b/0x80 drivers/tty/serial/8250/8250_port.c:2910 uart_set_options+0x30e/0x5e0 drivers/tty/serial/serial_core.c:2284 serial8250_console_setup+0x18a/0x430 drivers/tty/serial/8250/8250_port.c:3505 univ8250_console_setup+0x168/0x210 drivers/tty/serial/8250/8250_core.c:632 try_enable_preferred_console+0x24d/0x470 kernel/printk/printk.c:3228 register_console+0x331/0x10d0 kernel/printk/printk.c:3401 univ8250_console_init+0x35/0x50 drivers/tty/serial/8250/8250_core.c:717 console_init+0xba/0x5c0 kernel/printk/printk.c:3601 start_kernel+0x25a/0x480 init/main.c:1004 x86_64_start_reservations+0x18/0x30 arch/x86/kernel/head64.c:556 x86_64_start_kernel+0xb2/0xc0 arch/x86/kernel/head64.c:537 secondary_startup_64_no_verify+0x166/0x16b } ... key at: [] port_lock_key+0x0/0x40 ... acquired at: __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x5f/0x70 kernel/locking/spinlock.c:228 ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 ppp_asynctty_wakeup+0x18/0xb0 drivers/net/ppp/ppp_async.c:360 tty_wakeup+0xe5/0x120 drivers/tty/tty_io.c:525 tty_port_default_wakeup+0x2a/0x40 drivers/tty/tty_port.c:71 serial8250_tx_chars+0x542/0xf60 drivers/tty/serial/8250/8250_port.c:1836 __start_tx drivers/tty/serial/8250/8250_port.c:1544 [inline] serial8250_start_tx+0x7a8/0x980 drivers/tty/serial/8250/8250_port.c:1653 serial_port_runtime_resume+0x29e/0x330 drivers/tty/serial/serial_port.c:40 __rpm_callback+0xc5/0x4c0 drivers/base/power/runtime.c:392 rpm_callback+0x1da/0x220 drivers/base/power/runtime.c:446 rpm_resume+0xdb9/0x1980 drivers/base/power/runtime.c:912 pm_runtime_work+0x12e/0x180 drivers/base/power/runtime.c:977 process_one_work+0xaa2/0x16f0 kernel/workqueue.c:2600 worker_thread+0x687/0x1110 kernel/workqueue.c:2751 kthread+0x33a/0x430 kernel/kthread.c:388 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:145 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> (disc_data_lock){.?..}-{2:2} { IN-HARDIRQ-R at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x3a/0x70 kernel/locking/spinlock.c:228 ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 ppp_asynctty_wakeup+0x18/0xb0 drivers/net/ppp/ppp_async.c:360 tty_wakeup+0xe5/0x120 drivers/tty/tty_io.c:525 tty_port_default_wakeup+0x2a/0x40 drivers/tty/tty_port.c:71 serial8250_tx_chars+0x542/0xf60 drivers/tty/serial/8250/8250_port.c:1836 serial8250_handle_irq+0x5f2/0xbd0 drivers/tty/serial/8250/8250_port.c:1940 serial8250_default_handle_irq+0x94/0x210 drivers/tty/serial/8250/8250_port.c:1960 serial8250_interrupt+0xfc/0x200 drivers/tty/serial/8250/8250_core.c:127 __handle_irq_event_percpu+0x22a/0x740 kernel/irq/handle.c:158 handle_irq_event_percpu kernel/irq/handle.c:193 [inline] handle_irq_event+0xab/0x1e0 kernel/irq/handle.c:210 handle_edge_irq+0x261/0xcf0 kernel/irq/chip.c:831 generic_handle_irq_desc include/linux/irqdesc.h:161 [inline] handle_irq arch/x86/kernel/irq.c:238 [inline] __common_interrupt+0xdb/0x300 arch/x86/kernel/irq.c:257 common_interrupt+0xa9/0xd0 arch/x86/kernel/irq.c:247 asm_common_interrupt+0x26/0x40 arch/x86/include/asm/idtentry.h:636 unwind_get_return_address+0x6/0xe0 arch/x86/kernel/unwind_orc.c:365 arch_stack_walk+0xbe/0x170 arch/x86/kernel/stacktrace.c:26 stack_trace_save+0x96/0xd0 kernel/stacktrace.c:122 kasan_save_stack+0x33/0x50 mm/kasan/common.c:45 kasan_set_track+0x25/0x30 mm/kasan/common.c:52 __kasan_slab_alloc+0x81/0x90 mm/kasan/common.c:328 kasan_slab_alloc include/linux/kasan.h:186 [inline] slab_post_alloc_hook mm/slab.h:762 [inline] slab_alloc_node mm/slub.c:3478 [inline] kmem_cache_alloc_node+0x185/0x3f0 mm/slub.c:3523 __alloc_skb+0x287/0x330 net/core/skbuff.c:634 alloc_skb include/linux/skbuff.h:1286 [inline] nsim_dev_trap_skb_build drivers/net/netdevsim/dev.c:748 [inline] nsim_dev_trap_report drivers/net/netdevsim/dev.c:805 [inline] nsim_dev_trap_report_work+0x29e/0xc70 drivers/net/netdevsim/dev.c:850 process_one_work+0xaa2/0x16f0 kernel/workqueue.c:2600 worker_thread+0x687/0x1110 kernel/workqueue.c:2751 kthread+0x33a/0x430 kernel/kthread.c:388 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:145 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 HARDIRQ-ON-R at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x5f/0x70 kernel/locking/spinlock.c:228 ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 ppp_asynctty_ioctl+0x23/0x2c0 drivers/net/ppp/ppp_async.c:286 tty_ioctl+0x706/0x1580 drivers/tty/tty_io.c:2795 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd INITIAL USE at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_write_lock_irq include/linux/rwlock_api_smp.h:195 [inline] _raw_write_lock_irq+0x36/0x50 kernel/locking/spinlock.c:326 ppp_asynctty_close+0x1c/0x1c0 drivers/net/ppp/ppp_async.c:219 tty_ldisc_close+0x111/0x190 drivers/tty/tty_ldisc.c:455 tty_ldisc_kill+0x94/0x150 drivers/tty/tty_ldisc.c:607 tty_ldisc_release+0x116/0x2a0 drivers/tty/tty_ldisc.c:775 tty_release_struct+0x23/0xe0 drivers/tty/tty_io.c:1698 tty_release+0xe23/0x1410 drivers/tty/tty_io.c:1869 __fput+0x3f7/0xa70 fs/file_table.c:384 __fput_sync+0x47/0x50 fs/file_table.c:465 __do_sys_close fs/open.c:1572 [inline] __se_sys_close fs/open.c:1557 [inline] __x64_sys_close+0x87/0xf0 fs/open.c:1557 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd INITIAL READ USE at: lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x5f/0x70 kernel/locking/spinlock.c:228 ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 ppp_asynctty_wakeup+0x18/0xb0 drivers/net/ppp/ppp_async.c:360 tty_wakeup+0xe5/0x120 drivers/tty/tty_io.c:525 tty_port_default_wakeup+0x2a/0x40 drivers/tty/tty_port.c:71 serial8250_tx_chars+0x542/0xf60 drivers/tty/serial/8250/8250_port.c:1836 __start_tx drivers/tty/serial/8250/8250_port.c:1544 [inline] serial8250_start_tx+0x7a8/0x980 drivers/tty/serial/8250/8250_port.c:1653 serial_port_runtime_resume+0x29e/0x330 drivers/tty/serial/serial_port.c:40 __rpm_callback+0xc5/0x4c0 drivers/base/power/runtime.c:392 rpm_callback+0x1da/0x220 drivers/base/power/runtime.c:446 rpm_resume+0xdb9/0x1980 drivers/base/power/runtime.c:912 pm_runtime_work+0x12e/0x180 drivers/base/power/runtime.c:977 process_one_work+0xaa2/0x16f0 kernel/workqueue.c:2600 worker_thread+0x687/0x1110 kernel/workqueue.c:2751 kthread+0x33a/0x430 kernel/kthread.c:388 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:145 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 } ... key at: [] disc_data_lock+0x18/0x60 ... acquired at: mark_usage kernel/locking/lockdep.c:4578 [inline] __lock_acquire+0x13a5/0x5de0 kernel/locking/lockdep.c:5090 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x5f/0x70 kernel/locking/spinlock.c:228 ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 ppp_asynctty_ioctl+0x23/0x2c0 drivers/net/ppp/ppp_async.c:286 tty_ioctl+0x706/0x1580 drivers/tty/tty_io.c:2795 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd stack backtrace: CPU: 0 PID: 15942 Comm: syz-executor.3 Not tainted 6.5.0-syzkaller-04592-gd68b4b6f307d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 print_irq_inversion_bug.part.0+0x3e1/0x590 kernel/locking/lockdep.c:4079 print_irq_inversion_bug kernel/locking/lockdep.c:4032 [inline] check_usage_forwards kernel/locking/lockdep.c:4110 [inline] mark_lock_irq kernel/locking/lockdep.c:4242 [inline] mark_lock+0x920/0x1950 kernel/locking/lockdep.c:4677 mark_usage kernel/locking/lockdep.c:4578 [inline] __lock_acquire+0x13a5/0x5de0 kernel/locking/lockdep.c:5090 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x5f/0x70 kernel/locking/spinlock.c:228 ap_get+0x18/0xf0 drivers/net/ppp/ppp_async.c:136 ppp_asynctty_ioctl+0x23/0x2c0 drivers/net/ppp/ppp_async.c:286 tty_ioctl+0x706/0x1580 drivers/tty/tty_io.c:2795 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f4b77a7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4b787f50c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f4b77b9bf80 RCX: 00007f4b77a7cae9 RDX: 0000000020000040 RSI: 0000000080047437 RDI: 0000000000000003 RBP: 00007f4b77ac847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f4b77b9bf80 R15: 00007f4b77cbfa48