====================================================== WARNING: possible circular locking dependency detected 5.14.0-rc4-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/24778 is trying to acquire lock: ffff88801e2d4918 (&disk->open_mutex){+.+.}-{3:3}, at: del_gendisk+0x8b/0x770 block/genhd.c:587 but task is already holding lock: ffffffff8c487928 (loop_ctl_mutex){+.+.}-{3:3}, at: loop_control_remove drivers/block/loop.c:2439 [inline] ffffffff8c487928 (loop_ctl_mutex){+.+.}-{3:3}, at: loop_control_ioctl+0x103/0x450 drivers/block/loop.c:2494 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (loop_ctl_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 loop_add+0x9c/0x8c0 drivers/block/loop.c:2316 loop_probe+0x6a/0x80 drivers/block/loop.c:2426 blk_request_module+0x111/0x1d0 block/genhd.c:660 blkdev_get_no_open+0x1d5/0x250 fs/block_dev.c:1334 blkdev_get_by_dev.part.0+0x25/0xdd0 fs/block_dev.c:1397 blkdev_get_by_dev+0x6b/0x80 fs/block_dev.c:1450 swsusp_check+0x4d/0x270 kernel/power/swap.c:1525 software_resume.part.0+0x102/0x1f0 kernel/power/hibernate.c:977 software_resume kernel/power/hibernate.c:86 [inline] resume_store+0x161/0x190 kernel/power/hibernate.c:1179 kobj_attr_store+0x50/0x80 lib/kobject.c:856 sysfs_kf_write+0x110/0x160 fs/sysfs/file.c:139 kernfs_fop_write_iter+0x342/0x500 fs/kernfs/file.c:296 call_write_iter include/linux/fs.h:2114 [inline] new_sync_write+0x426/0x650 fs/read_write.c:518 vfs_write+0x75a/0xa40 fs/read_write.c:605 ksys_write+0x12d/0x250 fs/read_write.c:658 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #2 (major_names_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 __register_blkdev+0x2b/0x3e0 block/genhd.c:216 register_mtd_blktrans+0x85/0x3c0 drivers/mtd/mtd_blkdevs.c:531 do_one_initcall+0x103/0x650 init/main.c:1282 do_initcall_level init/main.c:1355 [inline] do_initcalls init/main.c:1371 [inline] do_basic_setup init/main.c:1391 [inline] kernel_init_freeable+0x6b8/0x741 init/main.c:1593 kernel_init+0x1a/0x1d0 init/main.c:1485 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #1 (mtd_table_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 blktrans_open+0x69/0x600 drivers/mtd/mtd_blkdevs.c:210 blkdev_get_whole+0xa1/0x420 fs/block_dev.c:1253 blkdev_get_by_dev.part.0+0x30c/0xdd0 fs/block_dev.c:1417 blkdev_get_by_dev fs/block_dev.c:1506 [inline] blkdev_open+0x295/0x300 fs/block_dev.c:1512 do_dentry_open+0x4c8/0x11d0 fs/open.c:826 do_open fs/namei.c:3374 [inline] path_openat+0x1c23/0x27f0 fs/namei.c:3507 do_filp_open+0x1aa/0x400 fs/namei.c:3534 do_sys_openat2+0x16d/0x420 fs/open.c:1204 do_sys_open fs/open.c:1220 [inline] __do_sys_open fs/open.c:1228 [inline] __se_sys_open fs/open.c:1224 [inline] __x64_sys_open+0x119/0x1c0 fs/open.c:1224 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #0 (&disk->open_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3051 [inline] check_prevs_add kernel/locking/lockdep.c:3174 [inline] validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015 lock_acquire kernel/locking/lockdep.c:5625 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590 __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 del_gendisk+0x8b/0x770 block/genhd.c:587 loop_remove drivers/block/loop.c:2413 [inline] loop_control_remove drivers/block/loop.c:2462 [inline] loop_control_ioctl+0x3b5/0x450 drivers/block/loop.c:2494 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:1069 [inline] __se_sys_ioctl fs/ioctl.c:1055 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:1055 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae other info that might help us debug this: Chain exists of: &disk->open_mutex --> major_names_lock --> loop_ctl_mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(loop_ctl_mutex); lock(major_names_lock); lock(loop_ctl_mutex); lock(&disk->open_mutex); *** DEADLOCK *** 1 lock held by syz-executor.5/24778: #0: ffffffff8c487928 (loop_ctl_mutex){+.+.}-{3:3}, at: loop_control_remove drivers/block/loop.c:2439 [inline] #0: ffffffff8c487928 (loop_ctl_mutex){+.+.}-{3:3}, at: loop_control_ioctl+0x103/0x450 drivers/block/loop.c:2494 stack backtrace: CPU: 1 PID: 24778 Comm: syz-executor.5 Not tainted 5.14.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:105 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2131 check_prev_add kernel/locking/lockdep.c:3051 [inline] check_prevs_add kernel/locking/lockdep.c:3174 [inline] validate_chain kernel/locking/lockdep.c:3789 [inline] __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015 lock_acquire kernel/locking/lockdep.c:5625 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590 __mutex_lock_common kernel/locking/mutex.c:959 [inline] __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104 del_gendisk+0x8b/0x770 block/genhd.c:587 loop_remove drivers/block/loop.c:2413 [inline] loop_control_remove drivers/block/loop.c:2462 [inline] loop_control_ioctl+0x3b5/0x450 drivers/block/loop.c:2494 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:1069 [inline] __se_sys_ioctl fs/ioctl.c:1055 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:1055 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x4665e9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb2475e3188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 000000000056bf80 RCX: 00000000004665e9 RDX: 0000000000000000 RSI: 0000000000004c81 RDI: 0000000000000003 RBP: 00000000004bfcc4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf80 R13: 0000000000a9fb1f R14: 00007fb2475e3300 R15: 0000000000022000