====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/21984 is trying to acquire lock: 00000000a26162b9 (&ovl_i_mutex_key[depth]){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] 00000000a26162b9 (&ovl_i_mutex_key[depth]){+.+.}, at: ovl_write_iter+0x148/0xb40 fs/overlayfs/file.c:270 but task is already holding lock: 000000005f142171 (&pipe->mutex/1){+.+.}, at: pipe_lock_nested fs/pipe.c:77 [inline] 000000005f142171 (&pipe->mutex/1){+.+.}, at: pipe_lock fs/pipe.c:85 [inline] 000000005f142171 (&pipe->mutex/1){+.+.}, at: pipe_wait+0x1bd/0x1e0 fs/pipe.c:133 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&pipe->mutex/1){+.+.}: pipe_lock_nested fs/pipe.c:77 [inline] pipe_lock+0x63/0x80 fs/pipe.c:85 iter_file_splice_write+0x183/0xbb0 fs/splice.c:700 do_splice_from fs/splice.c:852 [inline] do_splice fs/splice.c:1154 [inline] __do_sys_splice fs/splice.c:1428 [inline] __se_sys_splice+0xfe7/0x16d0 fs/splice.c:1408 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #1 (sb_writers#3){.+.+}: sb_start_write include/linux/fs.h:1579 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:360 ovl_maybe_copy_up+0x11f/0x190 fs/overlayfs/copy_up.c:888 ovl_ioctl_set_flags+0x168/0x310 fs/overlayfs/file.c:437 ovl_ioctl_set_fsflags fs/overlayfs/file.c:477 [inline] ovl_ioctl+0x16c/0x2f0 fs/overlayfs/file.c:521 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:501 [inline] do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705 __do_sys_ioctl fs/ioctl.c:712 [inline] __se_sys_ioctl fs/ioctl.c:710 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&ovl_i_mutex_key[depth]){+.+.}: down_write+0x34/0x90 kernel/locking/rwsem.c:70 inode_lock include/linux/fs.h:748 [inline] ovl_write_iter+0x148/0xb40 fs/overlayfs/file.c:270 call_write_iter include/linux/fs.h:1821 [inline] new_sync_write fs/read_write.c:474 [inline] __vfs_write+0x51b/0x770 fs/read_write.c:487 __kernel_write+0x109/0x370 fs/read_write.c:506 write_pipe_buf+0x153/0x1f0 fs/splice.c:798 splice_from_pipe_feed fs/splice.c:503 [inline] __splice_from_pipe+0x389/0x800 fs/splice.c:627 splice_from_pipe fs/splice.c:662 [inline] default_file_splice_write+0xd8/0x180 fs/splice.c:810 do_splice_from fs/splice.c:852 [inline] do_splice fs/splice.c:1154 [inline] __do_sys_splice fs/splice.c:1428 [inline] __se_sys_splice+0xfe7/0x16d0 fs/splice.c:1408 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: &ovl_i_mutex_key[depth] --> sb_writers#3 --> &pipe->mutex/1 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&pipe->mutex/1); lock(sb_writers#3); lock(&pipe->mutex/1); lock(&ovl_i_mutex_key[depth]); *** DEADLOCK *** 2 locks held by syz-executor.3/21984: #0: 00000000480330e1 (sb_writers#26){.+.+}, at: file_start_write include/linux/fs.h:2779 [inline] #0: 00000000480330e1 (sb_writers#26){.+.+}, at: do_splice fs/splice.c:1153 [inline] #0: 00000000480330e1 (sb_writers#26){.+.+}, at: __do_sys_splice fs/splice.c:1428 [inline] #0: 00000000480330e1 (sb_writers#26){.+.+}, at: __se_sys_splice+0x11de/0x16d0 fs/splice.c:1408 #1: 000000005f142171 (&pipe->mutex/1){+.+.}, at: pipe_lock_nested fs/pipe.c:77 [inline] #1: 000000005f142171 (&pipe->mutex/1){+.+.}, at: pipe_lock fs/pipe.c:85 [inline] #1: 000000005f142171 (&pipe->mutex/1){+.+.}, at: pipe_wait+0x1bd/0x1e0 fs/pipe.c:133 stack backtrace: CPU: 1 PID: 21984 Comm: syz-executor.3 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 down_write+0x34/0x90 kernel/locking/rwsem.c:70 inode_lock include/linux/fs.h:748 [inline] ovl_write_iter+0x148/0xb40 fs/overlayfs/file.c:270 call_write_iter include/linux/fs.h:1821 [inline] new_sync_write fs/read_write.c:474 [inline] __vfs_write+0x51b/0x770 fs/read_write.c:487 __kernel_write+0x109/0x370 fs/read_write.c:506 write_pipe_buf+0x153/0x1f0 fs/splice.c:798 splice_from_pipe_feed fs/splice.c:503 [inline] __splice_from_pipe+0x389/0x800 fs/splice.c:627 splice_from_pipe fs/splice.c:662 [inline] default_file_splice_write+0xd8/0x180 fs/splice.c:810 do_splice_from fs/splice.c:852 [inline] do_splice fs/splice.c:1154 [inline] __do_sys_splice fs/splice.c:1428 [inline] __se_sys_splice+0xfe7/0x16d0 fs/splice.c:1408 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f518a1790c9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f51886eb168 EFLAGS: 00000246 ORIG_RAX: 0000000000000113 RAX: ffffffffffffffda RBX: 00007f518a298f80 RCX: 00007f518a1790c9 RDX: 0000000000000005 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00007f518a1d4ae9 R08: 000000000000fdef R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffdc8c7e3bf R14: 00007f51886eb300 R15: 0000000000022000 nla_parse: 13 callbacks suppressed netlink: 12 bytes leftover after parsing attributes in process `syz-executor.1'. IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 netlink: 'syz-executor.1': attribute type 29 has an invalid length. netlink: 4608 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 'syz-executor.1': attribute type 29 has an invalid length. netlink: 4608 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 'syz-executor.4': attribute type 29 has an invalid length. netlink: 4608 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 'syz-executor.1': attribute type 29 has an invalid length. netlink: 4608 bytes leftover after parsing attributes in process `syz-executor.1'. kauditd_printk_skb: 43 callbacks suppressed audit: type=1804 audit(1672930318.293:11705): pid=22437 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir3101477965/syzkaller.NE0WZE/6626/cgroup.controllers" dev="sda1" ino=14531 res=1 netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. IPv6: ADDRCONF(NETDEV_UP): wlan1: link is not ready netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. wlan1: Created IBSS using preconfigured BSSID 50:50:50:50:50:50 netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. wlan1: Creating new IBSS network, BSSID 50:50:50:50:50:50 IPv6: ADDRCONF(NETDEV_CHANGE): wlan1: link becomes ready netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. wlan1: Created IBSS using preconfigured BSSID 50:50:50:50:50:50 IPVS: ftp: loaded support on port[0] = 21 wlan1: Creating new IBSS network, BSSID 50:50:50:50:50:50 audit: type=1804 audit(1672930319.333:11706): pid=22495 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir3101477965/syzkaller.NE0WZE/6627/cgroup.controllers" dev="sda1" ino=14884 res=1 audit: type=1804 audit(1672930319.533:11707): pid=22513 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.5" name="/root/syzkaller-testdir3776129113/syzkaller.9G0dNH/7493/cgroup.controllers" dev="sda1" ino=14659 res=1 nla_parse: 209 callbacks suppressed netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. IPv6: ADDRCONF(NETDEV_UP): wlan1: link is not ready netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. audit: type=1804 audit(1672930319.963:11708): pid=22551 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir3101477965/syzkaller.NE0WZE/6628/cgroup.controllers" dev="sda1" ino=14932 res=1 netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.0'. hpfs: bad mount options. 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. hpfs: bad mount options. IPVS: ftp: loaded support on port[0] = 21 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. 9pnet: Insufficient options for proto=fd hpfs: bad mount options. overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. audit: type=1804 audit(1672930321.183:11709): pid=22623 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.5" name="/root/syzkaller-testdir3776129113/syzkaller.9G0dNH/7494/cgroup.controllers" dev="sda1" ino=14972 res=1 wlan1: Created IBSS using preconfigured BSSID 50:50:50:50:50:50 wlan1: Creating new IBSS network, BSSID 50:50:50:50:50:50 IPv6: ADDRCONF(NETDEV_CHANGE): wlan1: link becomes ready hpfs: bad mount options. hpfs: bad mount options. 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. IPVS: ftp: loaded support on port[0] = 21 hpfs: bad mount options. 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. hpfs: bad mount options. 9pnet: Insufficient options for proto=fd hpfs: bad mount options. 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. hpfs: bad mount options. 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. hpfs: bad mount options. IPVS: ftp: loaded support on port[0] = 21 9pnet: Insufficient options for proto=fd overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.