====================================================== WARNING: possible circular locking dependency detected 6.1.118-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.837/7207 is trying to acquire lock: ffff0000f1b786f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x2c8/0x764 fs/ocfs2/acl.c:365 but task is already holding lock: ffff0000f00aa990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1118/0x13ac fs/jbd2/transaction.c:461 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2468 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2505 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3ef4/0x4a0c fs/ocfs2/super.c:1139 mount_bdev+0x274/0x370 fs/super.c:1443 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x278/0x8fc fs/namespace.c:3056 path_mount+0x590/0xe5c fs/namespace.c:3386 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount fs/namespace.c:3584 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2468 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2505 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3ef4/0x4a0c fs/ocfs2/super.c:1139 mount_bdev+0x274/0x370 fs/super.c:1443 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x278/0x8fc fs/namespace.c:3056 path_mount+0x590/0xe5c fs/namespace.c:3386 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount fs/namespace.c:3584 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (sb_internal#4){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350 ocfs2_xattr_set+0xdcc/0x1478 fs/ocfs2/xattr.c:3647 ocfs2_xattr_user_set+0xc0/0xe8 fs/ocfs2/xattr.c:7385 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x230/0x294 fs/xattr.c:617 path_setxattr+0x17c/0x258 fs/xattr.c:636 __do_sys_setxattr fs/xattr.c:652 [inline] __se_sys_setxattr fs/xattr.c:648 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_suballoc_bits+0x164/0x4428 fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x3b0/0x9f8 fs/ocfs2/xattr.c:3281 ocfs2_xattr_set+0xc08/0x1478 fs/ocfs2/xattr.c:3638 ocfs2_xattr_user_set+0xc0/0xe8 fs/ocfs2/xattr.c:7385 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x230/0x294 fs/xattr.c:617 path_setxattr+0x17c/0x258 fs/xattr.c:636 __do_sys_setxattr fs/xattr.c:652 [inline] __se_sys_setxattr fs/xattr.c:648 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&oi->ip_xattr_sem){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_init_acl+0x2c8/0x764 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1574/0x2560 fs/ocfs2/namei.c:408 ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0xeac/0x2548 fs/namei.c:3780 do_filp_open+0x1bc/0x3cc fs/namei.c:3810 do_sys_openat2+0x128/0x3e0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(jbd2_handle); lock(&journal->j_trans_barrier); lock(jbd2_handle); lock(&oi->ip_xattr_sem); *** DEADLOCK *** 8 locks held by syz.0.837/7207: #0: ffff0000dd100460 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000f1b789c8 (&type->i_mutex_dir_key#14){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000f1b789c8 (&type->i_mutex_dir_key#14){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3547 [inline] #1: ffff0000f1b789c8 (&type->i_mutex_dir_key#14){+.+.}-{3:3}, at: path_openat+0x5ec/0x2548 fs/namei.c:3780 #2: ffff0000f1af89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff0000f1af89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x4428 fs/ocfs2/suballoc.c:782 #3: ffff0000f1b7ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff0000f1b7ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x4428 fs/ocfs2/suballoc.c:782 #4: ffff0000f1afa648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #4: ffff0000f1afa648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635 #5: ffff0000dd100650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359 #6: ffff0000f1c9c8e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352 #7: ffff0000f00aa990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1118/0x13ac fs/jbd2/transaction.c:461 stack backtrace: CPU: 1 PID: 7207 Comm: syz.0.837 Not tainted 6.1.118-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_init_acl+0x2c8/0x764 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1574/0x2560 fs/ocfs2/namei.c:408 ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0xeac/0x2548 fs/namei.c:3780 do_filp_open+0x1bc/0x3cc fs/namei.c:3810 do_sys_openat2+0x128/0x3e0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585