====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.336/5342 is trying to acquire lock: ffff88805f98be48 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x391/0x1c70 fs/ext4/inode.c:597 but task is already holding lock: ffff88807a604208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_create+0xb1/0x550 fs/ext4/namei.c:2874 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12d8/0x4d60 fs/ext4/mballoc.c:5742 ext4_ext_map_blocks+0x1b01/0x7630 fs/ext4/extents.c:4318 ext4_map_blocks+0xa66/0x1c70 fs/ext4/inode.c:672 _ext4_get_block+0x23b/0x660 fs/ext4/inode.c:815 ext4_block_write_begin+0x6b0/0x13a0 fs/ext4/inode.c:1100 ext4_write_begin+0x6c6/0x15f0 ext4_da_write_begin+0x342/0xb60 fs/ext4/inode.c:2974 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785 ext4_buffered_write_iter+0x227/0x360 fs/ext4/file.c:268 ext4_file_write_iter+0x87c/0x1990 do_iter_readv_writev+0x594/0x7a0 do_iter_write+0x1e6/0x760 fs/read_write.c:855 iter_file_splice_write+0x806/0xfa0 fs/splice.c:689 do_splice_from fs/splice.c:767 [inline] direct_splice_actor+0xe3/0x1c0 fs/splice.c:936 splice_direct_to_actor+0x500/0xc10 fs/splice.c:891 do_splice_direct+0x285/0x3d0 fs/splice.c:979 do_sendfile+0x622/0x1000 fs/read_write.c:1249 __do_sys_sendfile64 fs/read_write.c:1317 [inline] __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x391/0x1c70 fs/ext4/inode.c:597 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:869 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3057 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 4 locks held by syz.2.336/5342: #0: ffff88807a604460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff88805f9883f0 (&type->i_mutex_dir_key#4/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #1: ffff88805f9883f0 (&type->i_mutex_dir_key#4/1){+.+.}-{3:3}, at: filename_create+0x25c/0x530 fs/namei.c:3835 #2: ffff88805f91e428 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #3: ffff88807a604208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 stack backtrace: CPU: 1 PID: 5342 Comm: syz.2.336 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x391/0x1c70 fs/ext4/inode.c:597 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:869 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3057 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fd72528e897 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd7236e6e68 EFLAGS: 00000246 ORIG_RAX: 0000000000000102 RAX: ffffffffffffffda RBX: 00007fd7236e6ef0 RCX: 00007fd72528e897 RDX: 00000000000001ff RSI: 0000000020001040 RDI: 00000000ffffff9c RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000020001040 R13: 00007fd7236e6eb0 R14: 0000000000000000 R15: 0000000000000000 EXT4-fs error (device loop2): ext4_add_entry:2484: inode #2: comm syz.2.336: Directory hole found for htree leaf block 0