EXT4-fs error (device loop2): ext4_find_dest_de:2093: inode #2: block 16: comm syz-executor.2: bad entry in directory: rec_len is smaller than minimal - offset=108, inode=646161, rec_len=0, size=4096 fake=0 ====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc1-syzkaller-gfe15c26ee26e #0 Not tainted ------------------------------------------------------ syz-executor.2/12019 is trying to acquire lock: ffff00012dffa650 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1477 [inline] ffff00012dffa650 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:1599 [inline] ffff00012dffa650 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x51c/0x148c fs/ext4/inode.c:240 but task is already holding lock: ffff00013249a218 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] ffff00013249a218 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline] ffff00013249a218 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x1c48/0x3264 fs/ext4/namei.c:4193 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}: down_write_nested+0x64/0xd8 kernel/locking/rwsem.c:1689 inode_lock_nested include/linux/fs.h:793 [inline] ext4_rename fs/ext4/namei.c:3879 [inline] ext4_rename2+0x1c48/0x3264 fs/ext4/namei.c:4193 vfs_rename+0x908/0xcd4 fs/namei.c:4772 do_renameat2+0x980/0x1040 fs/namei.c:4923 __do_sys_renameat2 fs/namei.c:4956 [inline] __se_sys_renameat2 fs/namei.c:4953 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4953 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #1 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x5d8/0xd94 fs/ext4/ext4_jbd2.c:111 ext4_sample_last_mounted fs/ext4/file.c:851 [inline] ext4_file_open+0x3c8/0x590 fs/ext4/file.c:880 do_dentry_open+0x734/0xfa0 fs/open.c:920 vfs_open+0x7c/0x90 fs/open.c:1051 do_open fs/namei.c:3560 [inline] path_openat+0x1f2c/0x2810 fs/namei.c:3715 do_filp_open+0x1bc/0x3cc fs/namei.c:3742 do_sys_openat2+0x128/0x3d8 fs/open.c:1348 do_sys_open fs/open.c:1364 [inline] __do_sys_openat fs/open.c:1380 [inline] __se_sys_openat fs/open.c:1375 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1375 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #0 (sb_internal){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x2f0/0x8c8 kernel/locking/lockdep.c:5669 percpu_down_read+0x78/0x304 include/linux/percpu-rwsem.h:51 __sb_start_write include/linux/fs.h:1477 [inline] sb_start_intwrite include/linux/fs.h:1599 [inline] ext4_evict_inode+0x51c/0x148c fs/ext4/inode.c:240 evict+0x260/0x68c fs/inode.c:665 iput_final fs/inode.c:1748 [inline] iput+0x988/0xa6c fs/inode.c:1774 ext4_rename fs/ext4/namei.c:4012 [inline] ext4_rename2+0x2bec/0x3264 fs/ext4/namei.c:4193 vfs_rename+0x908/0xcd4 fs/namei.c:4772 do_renameat2+0x980/0x1040 fs/namei.c:4923 __do_sys_renameat2 fs/namei.c:4956 [inline] __se_sys_renameat2 fs/namei.c:4953 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4953 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 other info that might help us debug this: Chain exists of: sb_internal --> jbd2_handle --> &type->i_mutex_dir_key#3/4 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#3/4); lock(jbd2_handle); lock(&type->i_mutex_dir_key#3/4); lock(sb_internal); *** DEADLOCK *** 3 locks held by syz-executor.2/12019: #0: ffff00012dffa460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:394 #1: ffff00013249c030 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff00013249c030 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0xf0/0x18c fs/namei.c:2991 #2: ffff00013249a218 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #2: ffff00013249a218 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline] #2: ffff00013249a218 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x1c48/0x3264 fs/ext4/namei.c:4193 stack backtrace: CPU: 1 PID: 12019 Comm: syz-executor.2 Not tainted 6.3.0-rc1-syzkaller-gfe15c26ee26e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x2f0/0x8c8 kernel/locking/lockdep.c:5669 percpu_down_read+0x78/0x304 include/linux/percpu-rwsem.h:51 __sb_start_write include/linux/fs.h:1477 [inline] sb_start_intwrite include/linux/fs.h:1599 [inline] ext4_evict_inode+0x51c/0x148c fs/ext4/inode.c:240 evict+0x260/0x68c fs/inode.c:665 iput_final fs/inode.c:1748 [inline] iput+0x988/0xa6c fs/inode.c:1774 ext4_rename fs/ext4/namei.c:4012 [inline] ext4_rename2+0x2bec/0x3264 fs/ext4/namei.c:4193 vfs_rename+0x908/0xcd4 fs/namei.c:4772 do_renameat2+0x980/0x1040 fs/namei.c:4923 __do_sys_renameat2 fs/namei.c:4956 [inline] __se_sys_renameat2 fs/namei.c:4953 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4953 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591