====================================================== WARNING: possible circular locking dependency detected 6.9.0-syzkaller-08995-g0450d2083be6 #0 Not tainted ------------------------------------------------------ syz-executor.0/1633 is trying to acquire lock: ffff888029607258 (&psock->ingress_lock){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] ffff888029607258 (&psock->ingress_lock){+...}-{2:2}, at: sk_psock_stop net/core/skmsg.c:802 [inline] ffff888029607258 (&psock->ingress_lock){+...}-{2:2}, at: sk_psock_drop+0x2fb/0x500 net/core/skmsg.c:846 but task is already holding lock: ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_hash_delete_from_link net/core/sock_map.c:932 [inline] ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_unlink net/core/sock_map.c:1613 [inline] ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_remove_links+0x1c5/0x6c0 net/core/sock_map.c:1625 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&htab->buckets[i].lock){+.-.}-{2:2}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] sock_hash_delete_elem+0x17c/0x400 net/core/sock_map.c:957 0xffffffffa0000856 bpf_dispatcher_nop_func include/linux/bpf.h:1243 [inline] __bpf_prog_run include/linux/filter.h:691 [inline] bpf_prog_run include/linux/filter.h:698 [inline] __bpf_trace_run kernel/trace/bpf_trace.c:2403 [inline] bpf_trace_run2+0x2ee/0x540 kernel/trace/bpf_trace.c:2444 trace_kfree include/trace/events/kmem.h:94 [inline] kfree+0x2bd/0x3b0 mm/slub.c:4450 sk_psock_cork_free include/linux/skmsg.h:434 [inline] sk_psock_stop+0xc5/0x110 net/core/skmsg.c:804 sock_map_close+0x1b2/0x2d0 net/core/sock_map.c:1692 inet_release+0x17f/0x200 net/ipv4/af_inet.c:437 __sock_release net/socket.c:659 [inline] sock_close+0xbe/0x240 net/socket.c:1421 __fput+0x42b/0x8a0 fs/file_table.c:422 __do_sys_close fs/open.c:1556 [inline] __se_sys_close fs/open.c:1541 [inline] __x64_sys_close+0x7f/0x110 fs/open.c:1541 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&psock->ingress_lock){+...}-{2:2}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] sk_psock_stop net/core/skmsg.c:802 [inline] sk_psock_drop+0x2fb/0x500 net/core/skmsg.c:846 sock_hash_delete_from_link net/core/sock_map.c:937 [inline] sock_map_unlink net/core/sock_map.c:1613 [inline] sock_map_remove_links+0x573/0x6c0 net/core/sock_map.c:1625 sock_map_unhash+0x17c/0x310 net/core/sock_map.c:1642 unix_shutdown+0x234/0x400 net/unix/af_unix.c:2966 __sys_shutdown_sock net/socket.c:2426 [inline] __sys_shutdown net/socket.c:2438 [inline] __do_sys_shutdown net/socket.c:2446 [inline] __se_sys_shutdown+0x150/0x1b0 net/socket.c:2444 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&htab->buckets[i].lock); lock(&psock->ingress_lock); lock(&htab->buckets[i].lock); lock(&psock->ingress_lock); *** DEADLOCK *** 2 locks held by syz-executor.0/1633: #0: ffffffff8e333d20 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline] #0: ffffffff8e333d20 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:781 [inline] #0: ffffffff8e333d20 (rcu_read_lock){....}-{1:2}, at: sock_map_unhash+0x21/0x310 net/core/sock_map.c:1635 #1: ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] #1: ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_hash_delete_from_link net/core/sock_map.c:932 [inline] #1: ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_unlink net/core/sock_map.c:1613 [inline] #1: ffff888029a70068 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_remove_links+0x1c5/0x6c0 net/core/sock_map.c:1625 stack backtrace: CPU: 1 PID: 1633 Comm: syz-executor.0 Not tainted 6.9.0-syzkaller-08995-g0450d2083be6 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] sk_psock_stop net/core/skmsg.c:802 [inline] sk_psock_drop+0x2fb/0x500 net/core/skmsg.c:846 sock_hash_delete_from_link net/core/sock_map.c:937 [inline] sock_map_unlink net/core/sock_map.c:1613 [inline] sock_map_remove_links+0x573/0x6c0 net/core/sock_map.c:1625 sock_map_unhash+0x17c/0x310 net/core/sock_map.c:1642 unix_shutdown+0x234/0x400 net/unix/af_unix.c:2966 __sys_shutdown_sock net/socket.c:2426 [inline] __sys_shutdown net/socket.c:2438 [inline] __do_sys_shutdown net/socket.c:2446 [inline] __se_sys_shutdown+0x150/0x1b0 net/socket.c:2444 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f9a00a7cee9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9a017870c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000030 RAX: ffffffffffffffda RBX: 00007f9a00babf80 RCX: 00007f9a00a7cee9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00007f9a00ac949e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f9a00babf80 R15: 00007fffc1d9b888