====================================================== WARNING: possible circular locking dependency detected 6.1.0-rc6-syzkaller-00251-g0b1dcc2cf55a #0 Not tainted ------------------------------------------------------ syz-executor183/3630 is trying to acquire lock: ffff88814b858170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x2ad/0x380 fs/jbd2/transaction.c:904 but task is already holding lock: ffff88814b856b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x1a0/0x6e0 fs/ext4/inode.c:6057 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&sbi->s_writepages_rwsem){++++}-{0:0}: lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5668 percpu_down_write+0x50/0x300 kernel/locking/percpu-rwsem.c:227 ext4_change_inode_journal_flag+0x1a0/0x6e0 fs/ext4/inode.c:6057 ext4_ioctl_setflags fs/ext4/ioctl.c:686 [inline] ext4_fileattr_set+0xdef/0x1810 fs/ext4/ioctl.c:1003 vfs_fileattr_set+0x8be/0xd20 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1daf/0x2a70 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x83/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #3 (mapping.invalidate_lock){++++}-{3:3}: lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5668 down_write+0x9c/0x270 kernel/locking/rwsem.c:1562 filemap_invalidate_lock include/linux/fs.h:801 [inline] ext4_setattr+0xe6c/0x18d0 fs/ext4/inode.c:5453 notify_change+0xe38/0x10f0 fs/attr.c:420 do_truncate+0x214/0x300 fs/open.c:65 do_sys_ftruncate+0x2eb/0x380 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&sb->s_type->i_mutex_key#7){++++}-{3:3}: lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5668 down_read+0x39/0x50 kernel/locking/rwsem.c:1509 inode_lock_shared include/linux/fs.h:766 [inline] ext4_bmap+0x55/0x410 fs/ext4/inode.c:3164 bmap+0xa1/0xd0 fs/inode.c:1798 jbd2_journal_bmap fs/jbd2/journal.c:977 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1789 [inline] jbd2_journal_flush+0x5d0/0xca0 fs/jbd2/journal.c:2492 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1081 [inline] __ext4_ioctl fs/ext4/ioctl.c:1586 [inline] ext4_ioctl+0x3797/0x55d0 fs/ext4/ioctl.c:1606 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1de/0x26c0 kernel/locking/mutex.c:603 mutex_lock_io_nested+0x43/0x60 kernel/locking/mutex.c:833 jbd2_journal_flush+0x2a6/0xca0 fs/jbd2/journal.c:2464 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1081 [inline] __ext4_ioctl fs/ext4/ioctl.c:1586 [inline] ext4_ioctl+0x3797/0x55d0 fs/ext4/ioctl.c:1606 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&journal->j_barrier){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x184a/0x6470 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1de/0x26c0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x2ad/0x380 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x1a8/0x6e0 fs/ext4/inode.c:6058 ext4_ioctl_setflags fs/ext4/ioctl.c:686 [inline] ext4_fileattr_set+0xdef/0x1810 fs/ext4/ioctl.c:1003 vfs_fileattr_set+0x8be/0xd20 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1daf/0x2a70 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x83/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &journal->j_barrier --> mapping.invalidate_lock --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(mapping.invalidate_lock); lock(&sbi->s_writepages_rwsem); lock(&journal->j_barrier); *** DEADLOCK *** 4 locks held by syz-executor183/3630: #0: ffff88814b854460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:437 #1: ffff888077347258 (&sb->s_type->i_mutex_key#7){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff888077347258 (&sb->s_type->i_mutex_key#7){++++}-{3:3}, at: vfs_fileattr_set+0x135/0xd20 fs/ioctl.c:681 #2: ffff8880773473f8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:801 [inline] #2: ffff8880773473f8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x115/0x6e0 fs/ext4/inode.c:6049 #3: ffff88814b856b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x1a0/0x6e0 fs/ext4/inode.c:6057 stack backtrace: CPU: 1 PID: 3630 Comm: syz-executor183 Not tainted 6.1.0-rc6-syzkaller-00251-g0b1dcc2cf55a #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f9/0x3b0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x184a/0x6470 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1de/0x26c0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x2ad/0x380 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x1a8/0x6e0 fs/ext4/inode.c:6058 ext4_ioctl_setflags fs/ext4/ioctl.c:686 [inline] ext4_fileattr_set+0xdef/0x1810 fs/ext4/ioctl.c:1003 vfs_fileattr_set+0x8be/0xd20 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1daf/0x2a70 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x83/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f1c3b9d5be9 Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffdde126dc8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f1c3b9d5be9 RDX: 0000000020000080 RSI: 0000000040086602 RDI: 0000000000000004 RBP: 00007f1c3b999d90 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f1c3b999e20