====================================================== WARNING: possible circular locking dependency detected 5.15.169-syzkaller #0 Not tainted ------------------------------------------------------ syz.6.877/8176 is trying to acquire lock: ffff0000eb0089c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] ffff0000eb0089c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782 but task is already holding lock: ffff0000e642bff8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x4e4/0x1478 fs/ocfs2/xattr.c:3588 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_init_acl+0x2d0/0x778 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1558/0x24f8 fs/ocfs2/namei.c:408 vfs_mknod+0x3c8/0x448 fs/namei.c:3944 do_mknodat+0x3c8/0x694 __do_sys_mknodat fs/namei.c:4022 [inline] __se_sys_mknodat fs/namei.c:4019 [inline] __arm64_sys_mknodat+0xb0/0xcc fs/namei.c:4019 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #4 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464 jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560 ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354 ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882 ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610 generic_shutdown_super+0x130/0x2f0 fs/super.c:475 kill_block_super+0x70/0xdc fs/super.c:1427 deactivate_locked_super+0xb8/0x13c fs/super.c:335 deactivate_super+0x108/0x128 fs/super.c:366 cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143 __cleanup_mnt+0x20/0x30 fs/namespace.c:1150 task_work_run+0x130/0x1e4 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline] el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882 ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610 generic_shutdown_super+0x130/0x2f0 fs/super.c:475 kill_block_super+0x70/0xdc fs/super.c:1427 deactivate_locked_super+0xb8/0x13c fs/super.c:335 deactivate_super+0x108/0x128 fs/super.c:366 cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143 __cleanup_mnt+0x20/0x30 fs/namespace.c:1150 task_work_run+0x130/0x1e4 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline] el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #2 (sb_internal#5){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359 ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655 vfs_mkdir+0x334/0x4e4 fs/namei.c:4065 do_mkdirat+0x20c/0x610 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_reserve_local_alloc_bits+0xfc/0x2474 fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1223 ocfs2_mknod+0xe08/0x24f8 fs/ocfs2/namei.c:352 ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655 vfs_mkdir+0x334/0x4e4 fs/namei.c:4065 do_mkdirat+0x20c/0x610 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x388/0x864 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x37c/0x950 fs/ocfs2/xattr.c:3282 ocfs2_xattr_set+0xc08/0x1478 fs/ocfs2/xattr.c:3639 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7350 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:303 do_setxattr fs/xattr.c:588 [inline] setxattr+0x250/0x2b4 fs/xattr.c:611 path_setxattr+0x17c/0x258 fs/xattr.c:630 __do_sys_setxattr fs/xattr.c:646 [inline] __se_sys_setxattr fs/xattr.c:642 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:642 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5); *** DEADLOCK *** 3 locks held by syz.6.877/8176: #0: ffff0000d1e5c460 (sb_writers#32){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #1: ffff0000e642c2c8 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000e642c2c8 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: vfs_setxattr+0x17c/0x344 fs/xattr.c:302 #2: ffff0000e642bff8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x4e4/0x1478 fs/ocfs2/xattr.c:3588 stack backtrace: CPU: 0 PID: 8176 Comm: syz.6.877 Not tainted 5.15.169-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x388/0x864 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x37c/0x950 fs/ocfs2/xattr.c:3282 ocfs2_xattr_set+0xc08/0x1478 fs/ocfs2/xattr.c:3639 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7350 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:303 do_setxattr fs/xattr.c:588 [inline] setxattr+0x250/0x2b4 fs/xattr.c:611 path_setxattr+0x17c/0x258 fs/xattr.c:630 __do_sys_setxattr fs/xattr.c:646 [inline] __se_sys_setxattr fs/xattr.c:642 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:642 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584