====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc1-syzkaller-00125-g0c559323bbaa #0 Not tainted ------------------------------------------------------ syz.3.473/9957 is trying to acquire lock: ffff88807b4713e8 (&dquot->dq_lock){+.+.}-{3:3}, at: wait_on_dquot fs/quota/dquot.c:355 [inline] ffff88807b4713e8 (&dquot->dq_lock){+.+.}-{3:3}, at: dqget+0x6e6/0xeb0 fs/quota/dquot.c:971 but task is already holding lock: ffff88807b48c620 (&ei->xattr_sem){++++}-{3:3}, at: ext4_setattr+0xae2/0x1bc0 fs/ext4/inode.c:5367 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&ei->xattr_sem){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline] ext4_xattr_set_handle+0x277/0x1580 fs/ext4/xattr.c:2373 ext4_initxattrs+0xa3/0x120 fs/ext4/xattr_security.c:44 security_inode_init_security+0x29c/0x480 security/security.c:1846 __ext4_new_inode+0x3635/0x4380 fs/ext4/ialloc.c:1323 ext4_create+0x279/0x550 fs/ext4/namei.c:2834 lookup_open fs/namei.c:3595 [inline] open_last_lookups fs/namei.c:3694 [inline] path_openat+0x1c03/0x3590 fs/namei.c:3930 do_filp_open+0x235/0x490 fs/namei.c:3960 do_sys_openat2+0x13e/0x1d0 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1441 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xed/0x4d0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x158f/0x19f0 fs/ocfs2/quota_local.c:771 dquot_load_quota_sb+0x762/0xbb0 fs/quota/dquot.c:2458 dquot_load_quota_inode+0x320/0x600 fs/quota/dquot.c:2495 ocfs2_enable_quotas+0x169/0x450 fs/ocfs2/super.c:926 ocfs2_fill_super+0x4c8d/0x5750 fs/ocfs2/super.c:1141 mount_bdev+0x20a/0x2d0 fs/super.c:1679 legacy_get_tree+0xee/0x190 fs/fs_context.c:662 vfs_get_tree+0x90/0x2b0 fs/super.c:1800 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4055 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4032 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_modify_bh+0xed/0x4d0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x158f/0x19f0 fs/ocfs2/quota_local.c:771 dquot_load_quota_sb+0x762/0xbb0 fs/quota/dquot.c:2458 dquot_load_quota_inode+0x320/0x600 fs/quota/dquot.c:2495 ocfs2_enable_quotas+0x169/0x450 fs/ocfs2/super.c:926 ocfs2_fill_super+0x4c8d/0x5750 fs/ocfs2/super.c:1141 mount_bdev+0x20a/0x2d0 fs/super.c:1679 legacy_get_tree+0xee/0x190 fs/fs_context.c:662 vfs_get_tree+0x90/0x2b0 fs/super.c:1800 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4055 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4032 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (sb_internal#2){.+.+}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1716 [inline] sb_start_intwrite include/linux/fs.h:1899 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x6df/0xb80 fs/ocfs2/quota_global.c:855 dqget+0x770/0xeb0 fs/quota/dquot.c:976 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1504 ocfs2_get_init_inode+0x158/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b40 fs/ocfs2/namei.c:308 ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257 do_mkdirat+0x264/0x3a0 fs/namei.c:4280 __do_sys_mkdirat fs/namei.c:4295 [inline] __se_sys_mkdirat fs/namei.c:4293 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4293 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x1de/0x1d70 fs/ocfs2/quota_local.c:1231 ocfs2_acquire_dquot+0x833/0xb80 fs/ocfs2/quota_global.c:878 dqget+0x770/0xeb0 fs/quota/dquot.c:976 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1504 ocfs2_get_init_inode+0x158/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b40 fs/ocfs2/namei.c:308 ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257 do_mkdirat+0x264/0x3a0 fs/namei.c:4280 __do_sys_mkdirat fs/namei.c:4295 [inline] __se_sys_mkdirat fs/namei.c:4293 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4293 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&dquot->dq_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x6e6/0xeb0 fs/quota/dquot.c:971 dquot_transfer+0x482/0x6d0 fs/quota/dquot.c:2153 ext4_setattr+0xaf3/0x1bc0 fs/ext4/inode.c:5368 notify_change+0xbca/0xe90 fs/attr.c:503 chown_common+0x501/0x850 fs/open.c:793 vfs_fchown fs/open.c:861 [inline] ksys_fchown+0xe3/0x160 fs/open.c:872 __do_sys_fchown fs/open.c:880 [inline] __se_sys_fchown fs/open.c:878 [inline] __x64_sys_fchown+0x7a/0x90 fs/open.c:878 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &dquot->dq_lock --> jbd2_handle --> &ei->xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(&ei->xattr_sem); lock(jbd2_handle); lock(&ei->xattr_sem); lock(&dquot->dq_lock); *** DEADLOCK *** 3 locks held by syz.3.473/9957: #0: ffff888030642420 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5e/0x200 fs/namespace.c:559 #1: ffff88807b48c950 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline] #1: ffff88807b48c950 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: chown_common+0x3e1/0x850 fs/open.c:783 #2: ffff88807b48c620 (&ei->xattr_sem){++++}-{3:3}, at: ext4_setattr+0xae2/0x1bc0 fs/ext4/inode.c:5367 stack backtrace: CPU: 0 UID: 0 PID: 9957 Comm: syz.3.473 Not tainted 6.12.0-rc1-syzkaller-00125-g0c559323bbaa #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x6e6/0xeb0 fs/quota/dquot.c:971 dquot_transfer+0x482/0x6d0 fs/quota/dquot.c:2153 ext4_setattr+0xaf3/0x1bc0 fs/ext4/inode.c:5368 notify_change+0xbca/0xe90 fs/attr.c:503 chown_common+0x501/0x850 fs/open.c:793 vfs_fchown fs/open.c:861 [inline] ksys_fchown+0xe3/0x160 fs/open.c:872 __do_sys_fchown fs/open.c:880 [inline] __se_sys_fchown fs/open.c:878 [inline] __x64_sys_fchown+0x7a/0x90 fs/open.c:878 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f95d417dff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f95d4fe0038 EFLAGS: 00000246 ORIG_RAX: 000000000000005d RAX: ffffffffffffffda RBX: 00007f95d4336058 RCX: 00007f95d417dff9 RDX: 0000000039323420 RSI: 0000000000000000 RDI: 0000000000000005 RBP: 00007f95d41f0296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f95d4336058 R15: 00007ffce01a50a8