======================================================
WARNING: possible circular locking dependency detected
4.19.207-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/3724 is trying to acquire lock:
000000002890a5dd (&macvlan_netdev_addr_lock_key#2/2){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
000000002890a5dd (&macvlan_netdev_addr_lock_key#2/2){+...}, at: dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574

but task is already holding lock:
0000000054be0e1e (&dev_addr_list_lock_key#2/1){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
0000000054be0e1e (&dev_addr_list_lock_key#2/1){+...}, at: dev_uc_sync+0x11a/0x1e0 net/core/dev_addr_lists.c:544

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev_addr_list_lock_key#2/1){+...}:
       netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
       dev_uc_sync+0x11a/0x1e0 net/core/dev_addr_lists.c:544
       macvlan_set_mac_lists+0x55/0x110 drivers/net/macvlan.c:806
       __dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
       dev_set_rx_mode net/core/dev.c:7607 [inline]
       __dev_open+0x26c/0x3a0 net/core/dev.c:1410
       __dev_change_flags+0x501/0x660 net/core/dev.c:7679
       rtnl_configure_link+0xec/0x230 net/core/rtnetlink.c:2830
       rtnl_newlink+0x1057/0x15c0 net/core/rtnetlink.c:3161
       rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
       netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2457
       netlink_unicast_kernel net/netlink/af_netlink.c:1320 [inline]
       netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1346
       netlink_sendmsg+0x6bb/0xc40 net/netlink/af_netlink.c:1911
       sock_sendmsg_nosec net/socket.c:651 [inline]
       sock_sendmsg+0xc3/0x120 net/socket.c:661
       ___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
       __sys_sendmsg net/socket.c:2265 [inline]
       __do_sys_sendmsg net/socket.c:2274 [inline]
       __se_sys_sendmsg net/socket.c:2272 [inline]
       __x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&macvlan_netdev_addr_lock_key#2/2){+...}:
       _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:354
       netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
       dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574
       team_set_rx_mode+0xce/0x230 drivers/net/team/team.c:1788
       __dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
       dev_uc_sync+0x193/0x1e0 net/core/dev_addr_lists.c:547
       macvlan_set_mac_lists+0x55/0x110 drivers/net/macvlan.c:806
       __dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
       dev_set_rx_mode net/core/dev.c:7607 [inline]
       __dev_open+0x26c/0x3a0 net/core/dev.c:1410
       __dev_change_flags+0x501/0x660 net/core/dev.c:7679
       rtnl_configure_link+0xec/0x230 net/core/rtnetlink.c:2830
       rtnl_newlink+0x1057/0x15c0 net/core/rtnetlink.c:3161
       rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
       netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2457
       netlink_unicast_kernel net/netlink/af_netlink.c:1320 [inline]
       netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1346
       netlink_sendmsg+0x6bb/0xc40 net/netlink/af_netlink.c:1911
       sock_sendmsg_nosec net/socket.c:651 [inline]
       sock_sendmsg+0xc3/0x120 net/socket.c:661
       ___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
       __sys_sendmsg net/socket.c:2265 [inline]
       __do_sys_sendmsg net/socket.c:2274 [inline]
       __se_sys_sendmsg net/socket.c:2272 [inline]
       __x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev_addr_list_lock_key#2/1);
                               lock(&macvlan_netdev_addr_lock_key#2/2);
                               lock(&dev_addr_list_lock_key#2/1);
  lock(&macvlan_netdev_addr_lock_key#2/2);

 *** DEADLOCK ***

4 locks held by syz-executor.5/3724:
 #0: 000000007ef01958 (rtnl_mutex){+.+.}, at: rtnl_lock net/core/rtnetlink.c:77 [inline]
 #0: 000000007ef01958 (rtnl_mutex){+.+.}, at: rtnetlink_rcv_msg+0x3fe/0xb80 net/core/rtnetlink.c:4779
 #1: 000000009b90ba34 (&macvlan_netdev_addr_lock_key#3/4){+...}, at: spin_lock_bh include/linux/spinlock.h:334 [inline]
 #1: 000000009b90ba34 (&macvlan_netdev_addr_lock_key#3/4){+...}, at: netif_addr_lock_bh include/linux/netdevice.h:4012 [inline]
 #1: 000000009b90ba34 (&macvlan_netdev_addr_lock_key#3/4){+...}, at: dev_set_rx_mode net/core/dev.c:7606 [inline]
 #1: 000000009b90ba34 (&macvlan_netdev_addr_lock_key#3/4){+...}, at: __dev_open+0x264/0x3a0 net/core/dev.c:1410
 #2: 0000000054be0e1e (&dev_addr_list_lock_key#2/1){+...}, at: netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
 #2: 0000000054be0e1e (&dev_addr_list_lock_key#2/1){+...}, at: dev_uc_sync+0x11a/0x1e0 net/core/dev_addr_lists.c:544
 #3: 00000000ed8ab225 (rcu_read_lock){....}, at: team_set_rx_mode+0x0/0x230 drivers/net/team/team.c:509

stack backtrace:
CPU: 1 PID: 3724 Comm: syz-executor.5 Not tainted 4.19.207-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 _raw_spin_lock_nested+0x30/0x40 kernel/locking/spinlock.c:354
 netif_addr_lock_nested include/linux/netdevice.h:4007 [inline]
 dev_uc_sync_multiple+0x11a/0x1e0 net/core/dev_addr_lists.c:574
 team_set_rx_mode+0xce/0x230 drivers/net/team/team.c:1788
 __dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
 dev_uc_sync+0x193/0x1e0 net/core/dev_addr_lists.c:547
 macvlan_set_mac_lists+0x55/0x110 drivers/net/macvlan.c:806
 __dev_set_rx_mode+0x1d9/0x2f0 net/core/dev.c:7601
 dev_set_rx_mode net/core/dev.c:7607 [inline]
 __dev_open+0x26c/0x3a0 net/core/dev.c:1410
 __dev_change_flags+0x501/0x660 net/core/dev.c:7679
 rtnl_configure_link+0xec/0x230 net/core/rtnetlink.c:2830
 rtnl_newlink+0x1057/0x15c0 net/core/rtnetlink.c:3161
 rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782
 netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2457
 netlink_unicast_kernel net/netlink/af_netlink.c:1320 [inline]
 netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1346
 netlink_sendmsg+0x6bb/0xc40 net/netlink/af_netlink.c:1911
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xc3/0x120 net/socket.c:661
 ___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227
 __sys_sendmsg net/socket.c:2265 [inline]
 __do_sys_sendmsg net/socket.c:2274 [inline]
 __se_sys_sendmsg net/socket.c:2272 [inline]
 __x64_sys_sendmsg+0x132/0x220 net/socket.c:2272
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f5989440709
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f59869b7188 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f5989544f60 RCX: 00007f5989440709
RDX: 0000000000000000 RSI: 0000000020000280 RDI: 0000000000000005
RBP: 00007f598949acb4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff0f30874f R14: 00007f59869b7300 R15: 0000000000022000
ISO 9660 Extensions: Microsoft Joliet Level 0
device macvlan5 entered promiscuous mode
8021q: adding VLAN 0 to HW filter on device macvlan5
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
device macvlan6 entered promiscuous mode
8021q: adding VLAN 0 to HW filter on device macvlan6
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
IPVS: ftp: loaded support on port[0] = 21
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
isofs_fill_super: root inode is not a directory. Corrupted media?
isofs_fill_super: root inode is not a directory. Corrupted media?
ISO 9660 Extensions: Microsoft Joliet Level 0
ISO 9660 Extensions: Microsoft Joliet Level 0
isofs_fill_super: root inode is not a directory. Corrupted media?
isofs_fill_super: root inode is not a directory. Corrupted media?