======================================================== WARNING: possible irq lock inversion dependency detected 5.9.0-syzkaller #0 Not tainted -------------------------------------------------------- syz-executor.5/9615 just changed the state of lock: ffff8880990ba108 (&group->lock){..-.}-{2:2}, at: snd_pcm_period_elapsed+0x2c/0x210 sound/core/pcm_lib.c:1799 but this lock took another, SOFTIRQ-READ-unsafe lock in the past: (&card->ctl_files_rwlock){.+.+}-{2:2} and interrupts could create inverse lock ordering between them. other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&card->ctl_files_rwlock); local_irq_disable(); lock(&group->lock); lock(&card->ctl_files_rwlock); lock(&group->lock); *** DEADLOCK *** 2 locks held by syz-executor.5/9615: #0: ffff88804feec388 (&vcpu->mutex){+.+.}-{3:3}, at: kvm_vcpu_ioctl+0xff/0xa50 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3207 #1: ffffc90000da8db0 ((&dpcm->timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:45 [inline] #1: ffffc90000da8db0 ((&dpcm->timer)){+.-.}-{0:0}, at: call_timer_fn+0x57/0x160 kernel/time/timer.c:1405 the shortest dependencies between 2nd lock and 1st lock: -> (&card->ctl_files_rwlock){.+.+}-{2:2} { HARDIRQ-ON-R at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 snd_ctl_notify+0x86/0x550 sound/core/control.c:153 __snd_ctl_add_replace+0x582/0x8a0 sound/core/control.c:382 snd_ctl_add_replace sound/core/control.c:399 [inline] snd_ctl_add+0x6e/0x110 sound/core/control.c:426 snd_card_dummy_new_mixer sound/drivers/dummy.c:885 [inline] snd_dummy_probe+0xb9e/0x1000 sound/drivers/dummy.c:1080 platform_drv_probe+0xcd/0x150 drivers/base/platform.c:747 really_probe+0x753/0x1110 drivers/base/dd.c:557 driver_probe_device+0x106/0x1a0 drivers/base/dd.c:738 bus_for_each_drv+0x108/0x170 drivers/base/bus.c:431 __device_attach+0x262/0x3f0 drivers/base/dd.c:912 bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:491 device_add+0x1630/0x19b0 drivers/base/core.c:2926 platform_device_add+0x4ad/0x6e0 drivers/base/platform.c:597 platform_device_register_full+0x448/0x530 drivers/base/platform.c:720 platform_device_register_resndata include/linux/platform_device.h:131 [inline] platform_device_register_simple include/linux/platform_device.h:160 [inline] alsa_card_dummy_init+0x1b3/0x398 sound/drivers/dummy.c:1168 do_one_initcall+0x14b/0x350 init/main.c:1205 do_initcall_level+0x101/0x14c init/main.c:1278 do_initcalls+0x59/0x9b init/main.c:1294 kernel_init_freeable+0x356/0x474 init/main.c:1514 kernel_init+0xd/0x290 init/main.c:1403 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 SOFTIRQ-ON-R at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 snd_ctl_notify+0x86/0x550 sound/core/control.c:153 __snd_ctl_add_replace+0x582/0x8a0 sound/core/control.c:382 snd_ctl_add_replace sound/core/control.c:399 [inline] snd_ctl_add+0x6e/0x110 sound/core/control.c:426 snd_card_dummy_new_mixer sound/drivers/dummy.c:885 [inline] snd_dummy_probe+0xb9e/0x1000 sound/drivers/dummy.c:1080 platform_drv_probe+0xcd/0x150 drivers/base/platform.c:747 really_probe+0x753/0x1110 drivers/base/dd.c:557 driver_probe_device+0x106/0x1a0 drivers/base/dd.c:738 bus_for_each_drv+0x108/0x170 drivers/base/bus.c:431 __device_attach+0x262/0x3f0 drivers/base/dd.c:912 bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:491 device_add+0x1630/0x19b0 drivers/base/core.c:2926 platform_device_add+0x4ad/0x6e0 drivers/base/platform.c:597 platform_device_register_full+0x448/0x530 drivers/base/platform.c:720 platform_device_register_resndata include/linux/platform_device.h:131 [inline] platform_device_register_simple include/linux/platform_device.h:160 [inline] alsa_card_dummy_init+0x1b3/0x398 sound/drivers/dummy.c:1168 do_one_initcall+0x14b/0x350 init/main.c:1205 do_initcall_level+0x101/0x14c init/main.c:1278 do_initcalls+0x59/0x9b init/main.c:1294 kernel_init_freeable+0x356/0x474 init/main.c:1514 kernel_init+0xd/0x290 init/main.c:1403 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 INITIAL USE at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_write_lock_irqsave include/linux/rwlock_api_smp.h:186 [inline] _raw_write_lock_irqsave+0xaa/0xd0 kernel/locking/spinlock.c:303 snd_ctl_open+0x322/0x480 sound/core/control.c:74 chrdev_open+0x498/0x580 fs/char_dev.c:414 do_dentry_open+0x7c8/0x1010 fs/open.c:817 do_open fs/namei.c:3251 [inline] path_openat+0x2794/0x3840 fs/namei.c:3368 do_filp_open+0x191/0x3a0 fs/namei.c:3395 do_sys_openat2+0x463/0x830 fs/open.c:1168 do_sys_open fs/open.c:1184 [inline] __do_sys_open fs/open.c:1192 [inline] __se_sys_open fs/open.c:1188 [inline] __x64_sys_open+0x1af/0x1e0 fs/open.c:1188 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 INITIAL READ USE at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 snd_ctl_notify+0x86/0x550 sound/core/control.c:153 __snd_ctl_add_replace+0x582/0x8a0 sound/core/control.c:382 snd_ctl_add_replace sound/core/control.c:399 [inline] snd_ctl_add+0x6e/0x110 sound/core/control.c:426 snd_card_dummy_new_mixer sound/drivers/dummy.c:885 [inline] snd_dummy_probe+0xb9e/0x1000 sound/drivers/dummy.c:1080 platform_drv_probe+0xcd/0x150 drivers/base/platform.c:747 really_probe+0x753/0x1110 drivers/base/dd.c:557 driver_probe_device+0x106/0x1a0 drivers/base/dd.c:738 bus_for_each_drv+0x108/0x170 drivers/base/bus.c:431 __device_attach+0x262/0x3f0 drivers/base/dd.c:912 bus_probe_device+0xb8/0x1f0 drivers/base/bus.c:491 device_add+0x1630/0x19b0 drivers/base/core.c:2926 platform_device_add+0x4ad/0x6e0 drivers/base/platform.c:597 platform_device_register_full+0x448/0x530 drivers/base/platform.c:720 platform_device_register_resndata include/linux/platform_device.h:131 [inline] platform_device_register_simple include/linux/platform_device.h:160 [inline] alsa_card_dummy_init+0x1b3/0x398 sound/drivers/dummy.c:1168 do_one_initcall+0x14b/0x350 init/main.c:1205 do_initcall_level+0x101/0x14c init/main.c:1278 do_initcalls+0x59/0x9b init/main.c:1294 kernel_init_freeable+0x356/0x474 init/main.c:1514 kernel_init+0xd/0x290 init/main.c:1403 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 } ... key at: [] snd_card_new.__key.3+0x0/0x10 ... acquired at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:223 snd_ctl_notify+0x86/0x550 sound/core/control.c:153 loopback_check_format sound/drivers/aloop.c:353 [inline] loopback_trigger+0xb75/0x1500 sound/drivers/aloop.c:387 snd_pcm_do_start sound/core/pcm_native.c:1350 [inline] snd_pcm_action_single sound/core/pcm_native.c:1207 [inline] snd_pcm_action sound/core/pcm_native.c:1290 [inline] snd_pcm_start+0x471/0x6c0 sound/core/pcm_native.c:1391 __snd_pcm_lib_xfer+0xf73/0x1320 sound/core/pcm_lib.c:2247 snd_pcm_oss_write3+0x209/0x330 sound/core/oss/pcm_oss.c:1221 snd_pcm_oss_write2+0x1bb/0x370 sound/core/oss/pcm_oss.c:1361 snd_pcm_oss_write1 sound/core/oss/pcm_oss.c:1419 [inline] snd_pcm_oss_write+0x911/0xd70 sound/core/oss/pcm_oss.c:2765 vfs_write+0x2dd/0xd20 fs/read_write.c:584 ksys_write+0x11b/0x220 fs/read_write.c:639 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 -> (&group->lock){..-.}-{2:2} { IN-SOFTIRQ-W at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xaa/0xd0 kernel/locking/spinlock.c:159 snd_pcm_period_elapsed+0x2c/0x210 sound/core/pcm_lib.c:1799 call_timer_fn+0x91/0x160 kernel/time/timer.c:1415 expire_timers kernel/time/timer.c:1460 [inline] __run_timers+0x65e/0x830 kernel/time/timer.c:1757 run_timer_softirq+0x46/0x80 kernel/time/timer.c:1770 __do_softirq+0x256/0x6e0 kernel/softirq.c:298 asm_call_irq_on_stack+0xf/0x20 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] do_softirq_own_stack+0x9a/0xf0 arch/x86/kernel/irq_64.c:77 invoke_softirq kernel/softirq.c:393 [inline] __irq_exit_rcu+0x21f/0x230 kernel/softirq.c:423 irq_exit_rcu+0x5/0x20 kernel/softirq.c:435 sysvec_apic_timer_interrupt+0xe0/0xf0 arch/x86/kernel/apic/apic.c:1091 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581 arch_local_irq_restore arch/x86/include/asm/paravirt.h:653 [inline] console_unlock+0xdcf/0xe20 kernel/printk/printk.c:2505 vprintk_emit+0x205/0x370 kernel/printk/printk.c:2029 printk+0x62/0x83 kernel/printk/printk.c:2078 set_target_expiration arch/x86/kvm/lapic.c:1729 [inline] __start_apic_timer+0x842/0x8e0 arch/x86/kvm/lapic.c:1932 kvm_apic_set_state+0xd2a/0x1dd0 arch/x86/kvm/lapic.c:2589 kvm_vcpu_ioctl_set_lapic arch/x86/kvm/x86.c:3832 [inline] kvm_arch_vcpu_ioctl+0xea9/0x4470 arch/x86/kvm/x86.c:4451 kvm_vcpu_ioctl+0x550/0xa50 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3382 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:739 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 INITIAL USE at: lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0xa6/0xc0 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:379 [inline] snd_pcm_group_lock_irq sound/core/pcm_native.c:97 [inline] snd_pcm_stream_lock_irq sound/core/pcm_native.c:136 [inline] snd_pcm_hw_params+0xca/0x16b0 sound/core/pcm_native.c:672 snd_pcm_oss_change_params_locked+0x25e0/0x4410 sound/core/oss/pcm_oss.c:941 snd_pcm_oss_change_params sound/core/oss/pcm_oss.c:1084 [inline] snd_pcm_oss_get_active_substream+0x1d8/0x270 sound/core/oss/pcm_oss.c:1101 snd_pcm_oss_get_formats+0x34/0x370 sound/core/oss/pcm_oss.c:1817 snd_pcm_oss_set_format sound/core/oss/pcm_oss.c:1858 [inline] snd_pcm_oss_ioctl+0x9ee/0x4660 sound/core/oss/pcm_oss.c:2617 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:739 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 } ... key at: [] snd_pcm_group_init.__key+0x0/0x10 ... acquired at: mark_usage kernel/locking/lockdep.c:4305 [inline] __lock_acquire+0xa67/0x2bd0 kernel/locking/lockdep.c:4791 lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xaa/0xd0 kernel/locking/spinlock.c:159 snd_pcm_period_elapsed+0x2c/0x210 sound/core/pcm_lib.c:1799 call_timer_fn+0x91/0x160 kernel/time/timer.c:1415 expire_timers kernel/time/timer.c:1460 [inline] __run_timers+0x65e/0x830 kernel/time/timer.c:1757 run_timer_softirq+0x46/0x80 kernel/time/timer.c:1770 __do_softirq+0x256/0x6e0 kernel/softirq.c:298 asm_call_irq_on_stack+0xf/0x20 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] do_softirq_own_stack+0x9a/0xf0 arch/x86/kernel/irq_64.c:77 invoke_softirq kernel/softirq.c:393 [inline] __irq_exit_rcu+0x21f/0x230 kernel/softirq.c:423 irq_exit_rcu+0x5/0x20 kernel/softirq.c:435 sysvec_apic_timer_interrupt+0xe0/0xf0 arch/x86/kernel/apic/apic.c:1091 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581 arch_local_irq_restore arch/x86/include/asm/paravirt.h:653 [inline] console_unlock+0xdcf/0xe20 kernel/printk/printk.c:2505 vprintk_emit+0x205/0x370 kernel/printk/printk.c:2029 printk+0x62/0x83 kernel/printk/printk.c:2078 set_target_expiration arch/x86/kvm/lapic.c:1729 [inline] __start_apic_timer+0x842/0x8e0 arch/x86/kvm/lapic.c:1932 kvm_apic_set_state+0xd2a/0x1dd0 arch/x86/kvm/lapic.c:2589 kvm_vcpu_ioctl_set_lapic arch/x86/kvm/x86.c:3832 [inline] kvm_arch_vcpu_ioctl+0xea9/0x4470 arch/x86/kvm/x86.c:4451 kvm_vcpu_ioctl+0x550/0xa50 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3382 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:739 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 stack backtrace: CPU: 1 PID: 9615 Comm: syz-executor.5 Not tainted 5.9.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1d6/0x29e lib/dump_stack.c:118 print_irq_inversion_bug+0xa5c/0xd70 kernel/locking/lockdep.c:3817 check_usage_forwards kernel/locking/lockdep.c:191 [inline] mark_lock_irq kernel/locking/lockdep.c:3980 [inline] mark_lock+0xe80/0x2050 kernel/locking/lockdep.c:4408 mark_usage kernel/locking/lockdep.c:4305 [inline] __lock_acquire+0xa67/0x2bd0 kernel/locking/lockdep.c:4791 lock_acquire+0x160/0x710 kernel/locking/lockdep.c:5442 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xaa/0xd0 kernel/locking/spinlock.c:159 snd_pcm_period_elapsed+0x2c/0x210 sound/core/pcm_lib.c:1799 call_timer_fn+0x91/0x160 kernel/time/timer.c:1415 expire_timers kernel/time/timer.c:1460 [inline] __run_timers+0x65e/0x830 kernel/time/timer.c:1757 run_timer_softirq+0x46/0x80 kernel/time/timer.c:1770 __do_softirq+0x256/0x6e0 kernel/softirq.c:298 asm_call_irq_on_stack+0xf/0x20 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] do_softirq_own_stack+0x9a/0xf0 arch/x86/kernel/irq_64.c:77 invoke_softirq kernel/softirq.c:393 [inline] __irq_exit_rcu+0x21f/0x230 kernel/softirq.c:423 irq_exit_rcu+0x5/0x20 kernel/softirq.c:435 sysvec_apic_timer_interrupt+0xe0/0xf0 arch/x86/kernel/apic/apic.c:1091 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581 RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:653 [inline] RIP: 0010:console_unlock+0xdcf/0xe20 kernel/printk/printk.c:2505 Code: c1 e8 03 42 80 3c 20 00 74 0c 48 c7 c7 20 2e 8d 89 e8 e5 14 57 00 48 83 3d ad 9f 2e 08 00 74 53 e8 46 ea 16 00 48 89 df 57 9d <0f> 1f 44 00 00 e9 72 ff ff ff e8 32 ea 16 00 4c 89 f7 e9 60 ff ff RSP: 0018:ffffc900055c7a40 EFLAGS: 00000286 RAX: ffffffff815e8e7a RBX: 0000000000000286 RCX: 0000000000040000 RDX: ffffc90013f3c000 RSI: 0000000000005651 RDI: 0000000000000286 RBP: ffffc900055c7b10 R08: dffffc0000000000 R09: fffffbfff16e4aae R10: fffffbfff16e4aae R11: 0000000000000000 R12: dffffc0000000000 R13: 0000000000000000 R14: 0000000000000000 R15: ffffffff89b0bb10 vprintk_emit+0x205/0x370 kernel/printk/printk.c:2029 printk+0x62/0x83 kernel/printk/printk.c:2078 set_target_expiration arch/x86/kvm/lapic.c:1729 [inline] __start_apic_timer+0x842/0x8e0 arch/x86/kvm/lapic.c:1932 kvm_apic_set_state+0xd2a/0x1dd0 arch/x86/kvm/lapic.c:2589 kvm_vcpu_ioctl_set_lapic arch/x86/kvm/x86.c:3832 [inline] kvm_arch_vcpu_ioctl+0xea9/0x4470 arch/x86/kvm/x86.c:4451 kvm_vcpu_ioctl+0x550/0xa50 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3382 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:739 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x45de59 Code: 0d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f69834cbc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000012140 RCX: 000000000045de59 RDX: 0000000020000580 RSI: 000000004400ae8f RDI: 0000000000000007 RBP: 000000000118bf60 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118bf2c R13: 00007fff18dd3c9f R14: 00007f69834cc9c0 R15: 000000000118bf2c