====================================================== WARNING: possible circular locking dependency detected 5.15.104-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/13394 is trying to acquire lock: ffff8880526f3c98 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_lock_xattr fs/ext4/xattr.h:155 [inline] ffff8880526f3c98 (&ei->xattr_sem){++++}-{3:3}, at: ext4_xattr_set_handle+0x270/0x1560 fs/ext4/xattr.c:2322 but task is already holding lock: ffff88807f4ca990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12d5/0x1590 fs/jbd2/transaction.c:466 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 start_this_handle+0x12fd/0x1590 fs/jbd2/transaction.c:468 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:525 __ext4_journal_start_sb+0x175/0x370 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_truncate+0x780/0x1130 fs/ext4/inode.c:4218 ext4_setattr+0xfe8/0x1990 fs/ext4/inode.c:5523 notify_change+0xd4d/0x1000 fs/attr.c:488 do_truncate+0x21c/0x300 fs/open.c:65 do_sys_ftruncate+0x2eb/0x390 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #2 (mapping.invalidate_lock){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_write+0x97/0x170 kernel/locking/rwsem.c:1541 filemap_invalidate_lock include/linux/fs.h:832 [inline] ext4_setattr+0xdaa/0x1990 fs/ext4/inode.c:5446 notify_change+0xd4d/0x1000 fs/attr.c:488 do_truncate+0x21c/0x300 fs/open.c:65 handle_truncate fs/namei.c:3195 [inline] do_open fs/namei.c:3542 [inline] path_openat+0x28a0/0x2f20 fs/namei.c:3672 do_filp_open+0x21c/0x460 fs/namei.c:3699 do_sys_openat2+0x13b/0x500 fs/open.c:1211 do_sys_open fs/open.c:1227 [inline] __do_sys_creat fs/open.c:1301 [inline] __se_sys_creat fs/open.c:1295 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1295 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #1 (&ea_inode->i_rwsem#9/1){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_write+0x97/0x170 kernel/locking/rwsem.c:1541 inode_lock include/linux/fs.h:787 [inline] ext4_xattr_inode_create fs/ext4/xattr.c:1475 [inline] ext4_xattr_inode_lookup_create fs/ext4/xattr.c:1558 [inline] ext4_xattr_set_entry+0x33c5/0x3c00 fs/ext4/xattr.c:1686 ext4_xattr_block_set+0xb10/0x3680 fs/ext4/xattr.c:1992 ext4_xattr_set_handle+0xdac/0x1560 fs/ext4/xattr.c:2407 ext4_xattr_set+0x231/0x3d0 fs/ext4/xattr.c:2508 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216 vfs_setxattr+0x21d/0x420 fs/xattr.c:303 do_setxattr fs/xattr.c:588 [inline] setxattr+0x27e/0x2e0 fs/xattr.c:611 path_setxattr+0x1bc/0x2a0 fs/xattr.c:630 __do_sys_setxattr fs/xattr.c:646 [inline] __se_sys_setxattr fs/xattr.c:642 [inline] __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&ei->xattr_sem){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_write+0x97/0x170 kernel/locking/rwsem.c:1541 ext4_write_lock_xattr fs/ext4/xattr.h:155 [inline] ext4_xattr_set_handle+0x270/0x1560 fs/ext4/xattr.c:2322 __ext4_set_acl+0x4f5/0x5d0 fs/ext4/acl.c:217 ext4_set_acl+0x3c4/0x730 fs/ext4/acl.c:259 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x33b/0x3a0 fs/posix_acl.c:966 __vfs_removexattr+0x3ce/0x410 fs/xattr.c:470 __vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:505 vfs_removexattr+0xff/0x2a0 fs/xattr.c:527 ovl_workdir_create+0x3e3/0x7d0 fs/overlayfs/super.c:818 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1415 legacy_get_tree+0xeb/0x180 fs/fs_context.c:610 vfs_get_tree+0x88/0x270 fs/super.c:1499 do_new_mount+0x28b/0xad0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Chain exists of: &ei->xattr_sem --> mapping.invalidate_lock --> jbd2_handle Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(jbd2_handle); lock(mapping.invalidate_lock); lock(jbd2_handle); lock(&ei->xattr_sem); *** DEADLOCK *** 5 locks held by syz-executor.2/13394: #0: ffff888072d2e0e0 (&type->s_umount_key#110/1){+.+.}-{3:3}, at: alloc_super+0x210/0x940 fs/super.c:229 #1: ffff88807f4c6460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #2: ffff888052783fc0 (&type->i_mutex_dir_key#4/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline] #2: ffff888052783fc0 (&type->i_mutex_dir_key#4/1){+.+.}-{3:3}, at: ovl_workdir_create+0x12e/0x7d0 fs/overlayfs/super.c:768 #3: ffff8880526f3fc0 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #3: ffff8880526f3fc0 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: vfs_removexattr+0xe8/0x2a0 fs/xattr.c:526 #4: ffff88807f4ca990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12d5/0x1590 fs/jbd2/transaction.c:466 stack backtrace: CPU: 1 PID: 13394 Comm: syz-executor.2 Not tainted 5.15.104-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_write+0x97/0x170 kernel/locking/rwsem.c:1541 ext4_write_lock_xattr fs/ext4/xattr.h:155 [inline] ext4_xattr_set_handle+0x270/0x1560 fs/ext4/xattr.c:2322 __ext4_set_acl+0x4f5/0x5d0 fs/ext4/acl.c:217 ext4_set_acl+0x3c4/0x730 fs/ext4/acl.c:259 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x33b/0x3a0 fs/posix_acl.c:966 __vfs_removexattr+0x3ce/0x410 fs/xattr.c:470 __vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:505 vfs_removexattr+0xff/0x2a0 fs/xattr.c:527 ovl_workdir_create+0x3e3/0x7d0 fs/overlayfs/super.c:818 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1415 legacy_get_tree+0xeb/0x180 fs/fs_context.c:610 vfs_get_tree+0x88/0x270 fs/super.c:1499 do_new_mount+0x28b/0xad0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7ffa019760f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff9ffe85168 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007ffa01a961f0 RCX: 00007ffa019760f9 RDX: 0000000020000080 RSI: 0000000020000040 RDI: 0000000000000000 RBP: 00007ffa019d1b39 R08: 0000000020000280 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd2d2c7ccf R14: 00007ff9ffe85300 R15: 0000000000022000 overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.