====================================================== WARNING: possible circular locking dependency detected 4.14.295-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/9809 is trying to acquire lock: (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] inode_lock_shared include/linux/fs.h:729 [inline] (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [] lookup_slow+0x129/0x400 fs/namei.c:1674 but task is already holding lock: (&oi->lock){+.+.}, at: [] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&oi->lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318 ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:631 ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:686 ovl_rename+0x1a6/0xe50 fs/overlayfs/dir.c:943 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #1 (sb_writers#3){.+.+}: percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x64/0x260 fs/super.c:1342 sb_start_write include/linux/fs.h:1551 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 ovl_do_remove+0x67/0xb90 fs/overlayfs/dir.c:759 vfs_rmdir.part.0+0x144/0x390 fs/namei.c:3910 vfs_rmdir fs/namei.c:3895 [inline] do_rmdir+0x334/0x3c0 fs/namei.c:3970 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #0 (&ovl_i_mutex_dir_key[depth]#2){++++}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_read+0x36/0x80 kernel/locking/rwsem.c:24 inode_lock_shared include/linux/fs.h:729 [inline] lookup_slow+0x129/0x400 fs/namei.c:1674 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595 ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783 ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb other info that might help us debug this: Chain exists of: &ovl_i_mutex_dir_key[depth]#2 --> sb_writers#3 --> &oi->lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->lock); lock(sb_writers#3); lock(&oi->lock); lock(&ovl_i_mutex_dir_key[depth]#2); *** DEADLOCK *** 8 locks held by syz-executor.3/9809: #0: (sb_writers#13){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #0: (sb_writers#13){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #1: (&type->s_vfs_rename_key#2){+.+.}, at: [] lock_rename+0x54/0x280 fs/namei.c:2889 #2: (&ovl_i_mutex_dir_key[depth]#3/1){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #2: (&ovl_i_mutex_dir_key[depth]#3/1){+.+.}, at: [] lock_rename+0xa0/0x280 fs/namei.c:2893 #3: (&ovl_i_mutex_dir_key[depth]#3/2){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #3: (&ovl_i_mutex_dir_key[depth]#3/2){+.+.}, at: [] lock_rename+0xd4/0x280 fs/namei.c:2894 #4: (&ovl_i_mutex_key[depth]){+.+.}, at: [] inode_lock include/linux/fs.h:719 [inline] #4: (&ovl_i_mutex_key[depth]){+.+.}, at: [] lock_two_nondirectories+0xca/0xf0 fs/inode.c:990 #5: (&ovl_i_mutex_key[depth]/4){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #5: (&ovl_i_mutex_key[depth]/4){+.+.}, at: [] lock_two_nondirectories+0xb2/0xf0 fs/inode.c:992 #6: (sb_writers#3){.+.+}, at: [] sb_start_write include/linux/fs.h:1551 [inline] #6: (sb_writers#3){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #7: (&oi->lock){+.+.}, at: [] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523 stack backtrace: CPU: 1 PID: 9809 Comm: syz-executor.3 Not tainted 4.14.295-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x281 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_read+0x36/0x80 kernel/locking/rwsem.c:24 inode_lock_shared include/linux/fs.h:729 [inline] lookup_slow+0x129/0x400 fs/namei.c:1674 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595 ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783 ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968 vfs_rename+0x560/0x1820 fs/namei.c:4498 SYSC_renameat2 fs/namei.c:4646 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4535 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb RIP: 0033:0x7f50d834e5f9 RSP: 002b:00007f50d6cc1168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f50d846ef80 RCX: 00007f50d834e5f9 RDX: 0000000000000000 RSI: 0000000020000440 RDI: 0000000020000380 RBP: 00007f50d83a97b0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff981e468f R14: 00007f50d6cc1300 R15: 0000000000022000 overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. F2FS-fs (loop4): Invalid blocksize (65536), supports only 4KB F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock F2FS-fs (loop4): Found nat_bits in checkpoint F2FS-fs (loop4): Mounted with checkpoint version = 3e17dab1 overlayfs: fs on 'file0' does not support file handles, falling back to index=off. F2FS-fs (loop4): Invalid blocksize (65536), supports only 4KB F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock F2FS-fs (loop4): Found nat_bits in checkpoint overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. F2FS-fs (loop4): Mounted with checkpoint version = 3e17dab1 F2FS-fs (loop4): Invalid blocksize (65536), supports only 4KB F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock EXT4-fs error (device loop2): ext4_fill_super:4382: inode #2: comm syz-executor.2: iget: bogus i_mode (113000) EXT4-fs (loop2): Remounting filesystem read-only EXT4-fs (loop2): get root inode failed EXT4-fs (loop2): mount failed EXT4-fs error (device loop2): ext4_fill_super:4382: inode #2: comm syz-executor.2: iget: bogus i_mode (113000) EXT4-fs (loop2): Remounting filesystem read-only EXT4-fs (loop2): get root inode failed EXT4-fs (loop2): mount failed EXT4-fs error (device loop2): ext4_fill_super:4382: inode #2: comm syz-executor.2: iget: bogus i_mode (113000) EXT4-fs (loop2): Remounting filesystem read-only EXT4-fs (loop2): get root inode failed EXT4-fs (loop2): mount failed netlink: 56 bytes leftover after parsing attributes in process `syz-executor.3'. print_req_error: I/O error, dev loop2, sector 24 EXT4-fs error (device loop2): ext4_fill_super:4382: inode #2: comm syz-executor.2: iget: bogus i_mode (113000) EXT4-fs (loop2): Remounting filesystem read-only EXT4-fs (loop2): get root inode failed EXT4-fs (loop2): mount failed print_req_error: I/O error, dev loop2, sector 24 netlink: 348 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. XFS (loop0): device supports 512 byte sectors (not 0) __ntfs_error: 1 callbacks suppressed ntfs: (device loop3): parse_options(): Invalid mft_zone_multiplier. Using default value, i.e. 1. ntfs: (device loop3): ntfs_fill_super(): Unable to determine device size. Zero length message leads to an empty skb XFS (loop0): device supports 512 byte sectors (not 0) netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'. XFS (loop0): device supports 512 byte sectors (not 0) netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. XFS (loop0): device supports 512 byte sectors (not 0) netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. attempt to access beyond end of device loop5: rw=1, want=256, limit=64 netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. ====================================================== WARNING: the mand mount option is being deprecated and will be removed in v5.15! ====================================================== netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. audit: type=1800 audit(1666701014.433:13): pid=10508 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="file0" dev="sda1" ino=13861 res=0 block nbd2: Attempted send on invalid socket print_req_error: I/O error, dev nbd2, sector 0 (syz-executor.2,10512,1):ocfs2_get_sector:1825 ERROR: status = -5 (syz-executor.2,10512,1):ocfs2_sb_probe:782 ERROR: status = -5 (syz-executor.2,10512,1):ocfs2_fill_super:1023 ERROR: superblock probe failed! (syz-executor.2,10512,1):ocfs2_fill_super:1217 ERROR: status = -5 EXT4-fs (nullb0): VFS: Can't find ext4 filesystem ceph: device name is missing path (no : separator in /dev/nullb0) EXT4-fs (nullb0): VFS: Can't find ext4 filesystem ceph: device name is missing path (no : separator in /dev/nullb0) EXT4-fs (nullb0): VFS: Can't find ext4 filesystem EXT4-fs (nullb0): VFS: Can't find ext4 filesystem ceph: device name is missing path (no : separator in /dev/nullb0) ceph: device name is missing path (no : separator in /dev/nullb0) audit: type=1800 audit(1666701015.313:14): pid=10603 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="sda1" ino=14036 res=0 Error parsing options; rc = [-22] attempt to access beyond end of device loop1: rw=2049, want=124, limit=60 affs: No valid root block on device nullb0 attempt to access beyond end of device Error parsing options; rc = [-22] loop1: rw=2049, want=128, limit=60 Buffer I/O error on dev loop1, logical block 31, lost async page write EXT4-fs (loop3): couldn't mount RDWR because of unsupported optional features (8000) affs: No valid root block on device nullb0 Error parsing options; rc = [-22] affs: No valid root block on device nullb0 Error parsing options; rc = [-22] audit: type=1800 audit(1666701015.773:15): pid=10685 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="file0" dev="sda1" ino=14043 res=0 affs: No valid root block on device nullb0 EXT4-fs (loop1): mounting with "discard" option, but the device does not support discard EXT4-fs (loop1): mounted filesystem without journal. Opts: quota,data_err=abort,max_dir_size_kb=0x0000000000000005,abort,journal_ioprio=0x0000000000000000,journal_ioprio=0x0000000000000006,errors=remount-ro,block_validity,abort, audit: type=1800 audit(1666701015.833:16): pid=10695 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="sda1" ino=14044 res=0 print_req_error: I/O error, dev loop0, sector 64 isofs_fill_super: bread failed, dev=loop0, iso_blknum=16, block=32 overlayfs: missing 'lowerdir' EXT4-fs (loop2): mounting with "discard" option, but the device does not support discard EXT4-fs (loop1): mounting with "discard" option, but the device does not support discard EXT4-fs (loop3): couldn't mount RDWR because of unsupported optional features (8000) EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,data_err=abort,max_dir_size_kb=0x0000000000000005,abort,journal_ioprio=0x0000000000000000,journal_ioprio=0x0000000000000006,errors=remount-ro,block_validity,abort, EXT4-fs (loop1): mounted filesystem without journal. Opts: quota,data_err=abort,max_dir_size_kb=0x0000000000000005,abort,journal_ioprio=0x0000000000000000,journal_ioprio=0x0000000000000006,errors=remount-ro,block_validity,abort, EXT4-fs (loop0): couldn't mount RDWR because of unsupported optional features (8000) UDF-fs: error (device loop0): udf_process_sequence: Block 99 of volume descriptor sequence is corrupted or we could not read it EXT4-fs (loop2): mounting with "discard" option, but the device does not support discard EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,data_err=abort,max_dir_size_kb=0x0000000000000005,abort,journal_ioprio=0x0000000000000000,journal_ioprio=0x0000000000000006,errors=remount-ro,block_validity,abort, UDF-fs: error (device loop0): udf_process_sequence: Block 1984 of volume descriptor sequence is corrupted or we could not read it UDF-fs: error (device loop0): udf_read_tagged: read failed, block=512, location=512 audit: type=1800 audit(1666701017.863:17): pid=10896 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="sda1" ino=14006 res=0 syz-executor.3 (10913) used greatest stack depth: 24960 bytes left x_tables: ip_tables: TCPMSS target: only valid for protocol 6 x_tables: ip_tables: rpfilter match: used from hooks PREROUTING/INPUT/OUTPUT/POSTROUTING, but only valid from PREROUTING x_tables: ip_tables: TCPMSS target: only valid for protocol 6 nla_parse: 22 callbacks suppressed netlink: 2212 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 12 bytes leftover after parsing attributes in process `syz-executor.3'. x_tables: ip_tables: TCPMSS target: only valid for protocol 6 unregister_netdevice: waiting for ip6gre0 to become free. Usage count = -1 cannot load conntrack support for proto=10 x_tables: ip_tables: TCPMSS target: only valid for protocol 6