====================================================== WARNING: possible circular locking dependency detected 5.15.163-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.2242/12029 is trying to acquire lock: ffff88807ae2b048 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 but task is already holding lock: ffff88807ae2b3e0 (mapping.invalidate_lock#16){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:844 [inline] ffff88807ae2b3e0 (mapping.invalidate_lock#16){.+.+}-{3:3}, at: page_cache_ra_unbounded+0x1a6/0x930 mm/readahead.c:195 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (mapping.invalidate_lock#16){.+.+}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 filemap_invalidate_lock_shared include/linux/fs.h:844 [inline] filemap_fault+0x708/0x1470 mm/filemap.c:3081 __do_fault+0x139/0x340 mm/memory.c:3898 do_read_fault mm/memory.c:4234 [inline] do_fault mm/memory.c:4362 [inline] handle_pte_fault mm/memory.c:4621 [inline] __handle_mm_fault mm/memory.c:4756 [inline] handle_mm_fault+0x376f/0x5950 mm/memory.c:4854 do_user_addr_fault arch/x86/mm/fault.c:1357 [inline] handle_page_fault arch/x86/mm/fault.c:1445 [inline] exc_page_fault+0x271/0x700 arch/x86/mm/fault.c:1501 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568 -> #2 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 mmap_read_lock+0x1c/0x50 include/linux/mmap_lock.h:117 do_user_addr_fault arch/x86/mm/fault.c:1308 [inline] handle_page_fault arch/x86/mm/fault.c:1445 [inline] exc_page_fault+0x596/0x700 arch/x86/mm/fault.c:1501 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568 user_access_begin arch/x86/include/asm/uaccess.h:574 [inline] filldir+0x32b/0x720 fs/readdir.c:249 dir_emit_dot include/linux/fs.h:3678 [inline] hfsplus_readdir+0x484/0x12f0 fs/hfsplus/dir.c:159 iterate_dir+0x224/0x570 __do_sys_getdents fs/readdir.c:286 [inline] __se_sys_getdents+0x1e8/0x4c0 fs/readdir.c:271 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&tree->tree_lock#2){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x78f/0xb80 fs/hfsplus/extents.c:609 hfsplus_write_begin+0xce/0xd0 fs/hfsplus/inode.c:57 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785 __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2172 [inline] aio_write+0x566/0x780 fs/aio.c:1594 io_submit_one+0x768/0x18d0 fs/aio.c:2013 __do_sys_io_submit fs/aio.c:2072 [inline] __se_sys_io_submit+0x17b/0x2f0 fs/aio.c:2042 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&hip->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 read_pages+0x605/0x8e0 mm/readahead.c:145 page_cache_ra_unbounded+0x264/0x930 mm/readahead.c:211 do_sync_mmap_readahead+0x610/0x800 mm/filemap.c:2996 filemap_fault+0x77a/0x1470 mm/filemap.c:3089 __do_fault+0x139/0x340 mm/memory.c:3898 do_read_fault mm/memory.c:4234 [inline] do_fault mm/memory.c:4362 [inline] handle_pte_fault mm/memory.c:4621 [inline] __handle_mm_fault mm/memory.c:4756 [inline] handle_mm_fault+0x376f/0x5950 mm/memory.c:4854 faultin_page mm/gup.c:976 [inline] __get_user_pages+0x4ed/0x11d0 mm/gup.c:1197 __get_user_pages_locked mm/gup.c:1382 [inline] get_user_pages_unlocked+0x23b/0x8a0 mm/gup.c:2222 __gup_longterm_unlocked mm/gup.c:2823 [inline] internal_get_user_pages_fast+0x22fb/0x2810 mm/gup.c:2911 iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544 dio_refill_pages fs/direct-io.c:173 [inline] dio_get_page fs/direct-io.c:217 [inline] do_direct_IO fs/direct-io.c:938 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3303 [inline] hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x204/0x460 mm/filemap.c:3687 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacd/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &hip->extents_lock --> &mm->mmap_lock --> mapping.invalidate_lock#16 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#16); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#16); lock(&hip->extents_lock); *** DEADLOCK *** 4 locks held by syz.2.2242/12029: #0: ffff88805b2c20f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1088 #1: ffff888023a04460 (sb_writers#17){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590 #2: ffff88807ae2b240 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff88807ae2b240 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: generic_file_write_iter+0x7c/0x1b0 mm/filemap.c:3941 #3: ffff88807ae2b3e0 (mapping.invalidate_lock#16){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:844 [inline] #3: ffff88807ae2b3e0 (mapping.invalidate_lock#16){.+.+}-{3:3}, at: page_cache_ra_unbounded+0x1a6/0x930 mm/readahead.c:195 stack backtrace: CPU: 0 PID: 12029 Comm: syz.2.2242 Not tainted 5.15.163-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 read_pages+0x605/0x8e0 mm/readahead.c:145 page_cache_ra_unbounded+0x264/0x930 mm/readahead.c:211 do_sync_mmap_readahead+0x610/0x800 mm/filemap.c:2996 filemap_fault+0x77a/0x1470 mm/filemap.c:3089 __do_fault+0x139/0x340 mm/memory.c:3898 do_read_fault mm/memory.c:4234 [inline] do_fault mm/memory.c:4362 [inline] handle_pte_fault mm/memory.c:4621 [inline] __handle_mm_fault mm/memory.c:4756 [inline] handle_mm_fault+0x376f/0x5950 mm/memory.c:4854 faultin_page mm/gup.c:976 [inline] __get_user_pages+0x4ed/0x11d0 mm/gup.c:1197 __get_user_pages_locked mm/gup.c:1382 [inline] get_user_pages_unlocked+0x23b/0x8a0 mm/gup.c:2222 __gup_longterm_unlocked mm/gup.c:2823 [inline] internal_get_user_pages_fast+0x22fb/0x2810 mm/gup.c:2911 iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544 dio_refill_pages fs/direct-io.c:173 [inline] dio_get_page fs/direct-io.c:217 [inline] do_direct_IO fs/direct-io.c:938 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x1419/0x4f40 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3303 [inline] hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x204/0x460 mm/filemap.c:3687 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacd/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f291ca20299 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f291ae9f048 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f291cbaef80 RCX: 00007f291ca20299 RDX: 000000000000f000 RSI: 0000000020000200 RDI: 0000000000000005 RBP: 00007f291ca8d8e6 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f291cbaef80 R15: 00007ffc7a9cfe78