====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc5-syzkaller-00348-ge0b668b07034 #0 Not tainted ------------------------------------------------------ syz.1.563/10917 is trying to acquire lock: ffff88806f3c5578 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xff/0x1450 fs/hfs/extent.c:397 but task is already holding lock: ffff8880562d60b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x16e/0x1f0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock/1){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfs_find_init+0x16e/0x1f0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_extend_file+0x31b/0x1450 fs/hfs/extent.c:401 hfs_bmap_reserve+0xd9/0x400 fs/hfs/btree.c:234 hfs_cat_move+0x1bb/0x1010 fs/hfs/catalog.c:310 hfs_rename+0x1df/0x2d0 fs/hfs/dir.c:299 vfs_rename+0xbdb/0xf00 fs/namei.c:4887 do_renameat2+0xd94/0x13f0 fs/namei.c:5044 __do_sys_renameat2 fs/namei.c:5078 [inline] __se_sys_renameat2 fs/namei.c:5075 [inline] __x64_sys_renameat2+0xd2/0xf0 fs/namei.c:5075 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfs_extend_file+0xff/0x1450 fs/hfs/extent.c:397 hfs_bmap_reserve+0xd9/0x400 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x344/0x1450 fs/hfs/extent.c:401 hfs_get_block+0x3e4/0xb60 fs/hfs/extent.c:353 get_more_blocks fs/direct-io.c:649 [inline] do_direct_IO fs/direct-io.c:937 [inline] __blockdev_direct_IO+0x1d72/0x49d0 fs/direct-io.c:1249 blockdev_direct_IO include/linux/fs.h:3185 [inline] hfs_direct_IO+0xf8/0x1e0 fs/hfs/inode.c:133 generic_file_direct_write+0x130/0x350 mm/filemap.c:3940 __generic_file_write_iter+0x129/0x230 mm/filemap.c:4096 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4136 do_iter_readv_writev+0x5a4/0x800 vfs_writev+0x395/0xbe0 fs/read_write.c:971 do_pwritev fs/read_write.c:1072 [inline] __do_sys_pwritev fs/read_write.c:1119 [inline] __se_sys_pwritev fs/read_write.c:1114 [inline] __x64_sys_pwritev+0x1c7/0x2d0 fs/read_write.c:1114 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz.1.563/10917: #0: ffff888062678420 (sb_writers#20){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2854 [inline] #0: ffff888062678420 (sb_writers#20){.+.+}-{0:0}, at: vfs_writev+0x2d9/0xbe0 fs/read_write.c:969 #1: ffff88806f3c7128 (&sb->s_type->i_mutex_key#29){++++}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #1: ffff88806f3c7128 (&sb->s_type->i_mutex_key#29){++++}-{3:3}, at: generic_file_write_iter+0x83/0x310 mm/filemap.c:4133 #2: ffff88806f3c6f78 (&HFS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xff/0x1450 fs/hfs/extent.c:397 #3: ffff8880562d60b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x16e/0x1f0 stack backtrace: CPU: 1 PID: 10917 Comm: syz.1.563 Not tainted 6.10.0-rc5-syzkaller-00348-ge0b668b07034 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfs_extend_file+0xff/0x1450 fs/hfs/extent.c:397 hfs_bmap_reserve+0xd9/0x400 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x344/0x1450 fs/hfs/extent.c:401 hfs_get_block+0x3e4/0xb60 fs/hfs/extent.c:353 get_more_blocks fs/direct-io.c:649 [inline] do_direct_IO fs/direct-io.c:937 [inline] __blockdev_direct_IO+0x1d72/0x49d0 fs/direct-io.c:1249 blockdev_direct_IO include/linux/fs.h:3185 [inline] hfs_direct_IO+0xf8/0x1e0 fs/hfs/inode.c:133 generic_file_direct_write+0x130/0x350 mm/filemap.c:3940 __generic_file_write_iter+0x129/0x230 mm/filemap.c:4096 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4136 do_iter_readv_writev+0x5a4/0x800 vfs_writev+0x395/0xbe0 fs/read_write.c:971 do_pwritev fs/read_write.c:1072 [inline] __do_sys_pwritev fs/read_write.c:1119 [inline] __se_sys_pwritev fs/read_write.c:1114 [inline] __x64_sys_pwritev+0x1c7/0x2d0 fs/read_write.c:1114 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe39f775b99 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe3a04d0048 EFLAGS: 00000246 ORIG_RAX: 0000000000000128 RAX: ffffffffffffffda RBX: 00007fe39f904078 RCX: 00007fe39f775b99 RDX: 0000000000000003 RSI: 00000000200004c0 RDI: 0000000000000005 RBP: 00007fe39f7f677e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007fe39f904078 R15: 00007ffea4efde28