loop0: detected capacity change from 0 to 40427 F2FS-fs (loop0): Found nat_bits in checkpoint F2FS-fs (loop0): Mounted with checkpoint version = 48b305e5 ====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc2-syzkaller-00322-g725d444db6b0 #0 Not tainted ------------------------------------------------------ syz-executor291/5018 is trying to acquire lock: ffff888078158e00 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] ffff888078158e00 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_add_inline_entry+0x300/0x6f0 fs/f2fs/inline.c:644 but task is already holding lock: ffff888078159978 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] ffff888078159978 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry+0x92/0x230 fs/f2fs/dir.c:783 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&fi->i_xattr_sem){.+.+}-{3:3}: down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] f2fs_getxattr+0xb1e/0x12c0 fs/f2fs/xattr.c:532 __f2fs_get_acl+0x5a/0x900 fs/f2fs/acl.c:179 f2fs_acl_create fs/f2fs/acl.c:377 [inline] f2fs_init_acl+0x15c/0xb30 fs/f2fs/acl.c:420 f2fs_init_inode_metadata+0x159/0x1290 fs/f2fs/dir.c:558 f2fs_add_regular_entry+0x79e/0xb90 fs/f2fs/dir.c:740 f2fs_add_dentry+0x1de/0x230 fs/f2fs/dir.c:788 f2fs_do_add_link+0x190/0x280 fs/f2fs/dir.c:827 f2fs_add_link fs/f2fs/f2fs.h:3554 [inline] f2fs_mkdir+0x377/0x620 fs/f2fs/namei.c:781 vfs_mkdir+0x532/0x7e0 fs/namei.c:4117 do_mkdirat+0x2a9/0x330 fs/namei.c:4140 __do_sys_mkdirat fs/namei.c:4155 [inline] __se_sys_mkdirat fs/namei.c:4153 [inline] __x64_sys_mkdirat+0x115/0x170 fs/namei.c:4153 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&fi->i_sem){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 down_write+0x93/0x200 kernel/locking/rwsem.c:1573 f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] f2fs_add_inline_entry+0x300/0x6f0 fs/f2fs/inline.c:644 f2fs_add_dentry+0xa6/0x230 fs/f2fs/dir.c:784 f2fs_do_add_link+0x190/0x280 fs/f2fs/dir.c:827 f2fs_add_link fs/f2fs/f2fs.h:3554 [inline] f2fs_rename fs/f2fs/namei.c:1071 [inline] f2fs_rename2 fs/f2fs/namei.c:1332 [inline] f2fs_rename2+0x1a27/0x27f0 fs/f2fs/namei.c:1309 vfs_rename+0x13e0/0x1c30 fs/namei.c:4857 do_renameat2+0xc3c/0xdc0 fs/namei.c:5009 __do_sys_renameat2 fs/namei.c:5042 [inline] __se_sys_renameat2 fs/namei.c:5039 [inline] __x64_sys_renameat2+0xeb/0x130 fs/namei.c:5039 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(&fi->i_xattr_sem); lock(&fi->i_sem); lock(&fi->i_xattr_sem); lock(&fi->i_sem); *** DEADLOCK *** 7 locks held by syz-executor291/5018: #0: ffff88807727c410 (sb_writers#9){.+.+}-{0:0}, at: do_renameat2+0x3d5/0xdc0 fs/namei.c:4943 #1: ffff88807727c6f8 (&type->s_vfs_rename_key){+.+.}-{3:3}, at: lock_rename fs/namei.c:3046 [inline] #1: ffff88807727c6f8 (&type->s_vfs_rename_key){+.+.}-{3:3}, at: do_renameat2+0x4ec/0xdc0 fs/namei.c:4948 #2: ffff888075840a28 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #2: ffff888075840a28 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_two_directories+0x65/0x1d0 fs/namei.c:3019 #3: ffff888078159300 (&type->i_mutex_dir_key#7/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #3: ffff888078159300 (&type->i_mutex_dir_key#7/2){+.+.}-{3:3}, at: lock_two_directories+0x99/0x1d0 fs/namei.c:3020 #4: ffff888078158a28 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #4: ffff888078158a28 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: lock_two_inodes+0x1b2/0x1e0 fs/inode.c:1143 #5: ffff88802a5c43b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] #5: ffff88802a5c43b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_lock_op fs/f2fs/f2fs.h:2151 [inline] #5: ffff88802a5c43b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_rename fs/f2fs/namei.c:1069 [inline] #5: ffff88802a5c43b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_rename2 fs/f2fs/namei.c:1332 [inline] #5: ffff88802a5c43b0 (&sbi->cp_rwsem){.+.+}-{3:3}, at: f2fs_rename2+0x192a/0x27f0 fs/f2fs/namei.c:1309 #6: ffff888078159978 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] #6: ffff888078159978 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry+0x92/0x230 fs/f2fs/dir.c:783 stack backtrace: CPU: 0 PID: 5018 Comm: syz-executor291 Not tainted 6.5.0-rc2-syzkaller-00322-g725d444db6b0 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 down_write+0x93/0x200 kernel/locking/rwsem.c:1573 f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] f2fs_add_inline_entry+0x300/0x6f0 fs/f2fs/inline.c:644 f2fs_add_dentry+0xa6/0x230 fs/f2fs/dir.c:784 f2fs_do_add_link+0x190/0x280 fs/f2fs/dir.c:827 f2fs_add_link fs/f2fs/f2fs.h:3554 [inline] f2fs_rename fs/f2fs/namei.c:1071 [inline] f2fs_rename2 fs/f2fs/namei.c:1332 [inline] f2fs_rename2+0x1a27/0x27f0 fs/f2fs/namei.c:1309 vfs_rename+0x13e0/0x1c30 fs/namei.c:4857 do_renameat2+0xc3c/0xdc0 fs/namei.c:5009 __do_sys_renameat2 fs/namei.c:5042 [inline] __se_sys_renameat2 fs/namei.c:5039 [inline] __x64_sys_renameat2+0xeb/0x130 fs/namei.c:5039 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f56fa9eb779 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd06912498 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffd