====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc5-next-20241101-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor964/5875 is trying to acquire lock: ffff8880271080b0 (&tree->tree_lock){+.+.}-{4:4}, at: hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28 but task is already holding lock: ffff88807b5638f8 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:817 [inline] ffff88807b5638f8 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: hfsplus_file_fsync+0xe8/0x4d0 fs/hfsplus/inode.c:311 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:817 [inline] hfsplus_file_fsync+0xe8/0x4d0 fs/hfsplus/inode.c:311 __loop_update_dio+0x1a4/0x500 drivers/block/loop.c:204 loop_set_status+0x62b/0x8f0 drivers/block/loop.c:1290 lo_ioctl+0xcbc/0x1f50 blkdev_ioctl+0x57d/0x6a0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&q->q_usage_counter(io)#17){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 bio_queue_enter block/blk.h:75 [inline] blk_mq_submit_bio+0x1510/0x2490 block/blk-mq.c:3069 __submit_bio+0x2c2/0x560 block/blk-core.c:629 __submit_bio_noacct_mq block/blk-core.c:710 [inline] submit_bio_noacct_nocheck+0x4d3/0xe30 block/blk-core.c:739 submit_bh fs/buffer.c:2819 [inline] block_read_full_folio+0x93b/0xcd0 fs/buffer.c:2446 filemap_read_folio+0x14b/0x630 mm/filemap.c:2366 do_read_cache_folio+0x3f5/0x850 mm/filemap.c:3826 do_read_cache_page+0x30/0x200 mm/filemap.c:3892 read_mapping_page include/linux/pagemap.h:1005 [inline] __hfs_bnode_create+0x487/0x770 fs/hfsplus/bnode.c:440 hfsplus_bnode_find+0x237/0x10c0 fs/hfsplus/bnode.c:486 hfsplus_brec_find+0x183/0x570 fs/hfsplus/bfind.c:172 hfsplus_brec_read+0x2b/0x110 fs/hfsplus/bfind.c:211 hfsplus_find_cat+0x17f/0x5d0 fs/hfsplus/catalog.c:202 hfsplus_iget+0x483/0x680 fs/hfsplus/super.c:83 hfsplus_fill_super+0xc4d/0x1be0 fs/hfsplus/super.c:504 get_tree_bdev_flags+0x48c/0x5c0 fs/super.c:1636 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&tree->tree_lock){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28 hfsplus_cat_write_inode+0x1df/0x1070 fs/hfsplus/inode.c:589 write_inode fs/fs-writeback.c:1501 [inline] __writeback_single_inode+0x711/0x10d0 fs/fs-writeback.c:1721 writeback_single_inode+0x1f3/0x660 fs/fs-writeback.c:1777 sync_inode_metadata+0xc4/0x120 fs/fs-writeback.c:2847 hfsplus_file_fsync+0xf5/0x4d0 fs/hfsplus/inode.c:316 __loop_update_dio+0x1a4/0x500 drivers/block/loop.c:204 loop_set_status+0x62b/0x8f0 drivers/block/loop.c:1290 lo_ioctl+0xcbc/0x1f50 blkdev_ioctl+0x57d/0x6a0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &tree->tree_lock --> &q->q_usage_counter(io)#17 --> &sb->s_type->i_mutex_key#15 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sb->s_type->i_mutex_key#15); lock(&q->q_usage_counter(io)#17); lock(&sb->s_type->i_mutex_key#15); lock(&tree->tree_lock); *** DEADLOCK *** 4 locks held by syz-executor964/5875: #0: ffff8881427f3360 (&lo->lo_mutex){+.+.}-{4:4}, at: loop_set_status+0x2a/0x8f0 drivers/block/loop.c:1252 #1: ffff888143381db8 (&q->q_usage_counter(io)#17){++++}-{0:0}, at: blk_freeze_queue block/blk-mq.c:177 [inline] #1: ffff888143381db8 (&q->q_usage_counter(io)#17){++++}-{0:0}, at: blk_mq_freeze_queue+0x15/0x20 block/blk-mq.c:187 #2: ffff888143381df0 (&q->q_usage_counter(queue)){+.+.}-{0:0}, at: blk_freeze_queue block/blk-mq.c:177 [inline] #2: ffff888143381df0 (&q->q_usage_counter(queue)){+.+.}-{0:0}, at: blk_mq_freeze_queue+0x15/0x20 block/blk-mq.c:187 #3: ffff88807b5638f8 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:817 [inline] #3: ffff88807b5638f8 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: hfsplus_file_fsync+0xe8/0x4d0 fs/hfsplus/inode.c:311 stack backtrace: CPU: 1 UID: 0 PID: 5875 Comm: syz-executor964 Not tainted 6.12.0-rc5-next-20241101-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28 hfsplus_cat_write_inode+0x1df/0x1070 fs/hfsplus/inode.c:589 write_inode fs/fs-writeback.c:1501 [inline] __writeback_single_inode+0x711/0x10d0 fs/fs-writeback.c:1721 writeback_single_inode+0x1f3/0x660 fs/fs-writeback.c:1777 sync_inode_metadata+0xc4/0x120 fs/fs-writeback.c:2847 hfsplus_file_fsync+0xf5/0x4d0 fs/hfsplus/inode.c:316 __loop_update_dio+0x1a4/0x500 drivers/block/loop.c:204 loop_set_status+0x62b/0x8f0 drivers/block/loop.c:1290 lo_ioctl+0xcbc/0x1f50 blkdev_ioctl+0x57d/0x6a0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f9b5a770659 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffcf71a2de8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f9b5a7b90a0 RCX: 00007f9b5a770659 RDX: 0000000020001300 RSI: 0000000000004c04 RDI: 0000000000000004 RBP: 0000000000000000 R08: 0000000000000000 R09: 00007ffcf71a2e20 R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffcf71a2e0c R13: 0000000000000004 R14: 431bde82d7b634db R15: 00007ffcf71a2e40