ocfs2: Finishing quota recovery on device (7,4) for slot 0
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc7-syzkaller-g1950a0af2d55 #0 Not tainted
------------------------------------------------------
kworker/u8:11/868 is trying to acquire lock:
ffff0000ed6140e0 (&type->s_umount_key#51){++++}-{4:4}, at: ocfs2_finish_quota_recovery+0x198/0x1f94 fs/ocfs2/quota_local.c:603

but task is already holding lock:
ffff80009dd47c20 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_one_work+0x6a4/0x15cc kernel/workqueue.c:3210

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}:
       process_one_work+0x6cc/0x15cc kernel/workqueue.c:3212
       process_scheduled_works kernel/workqueue.c:3317 [inline]
       worker_thread+0x97c/0xeec kernel/workqueue.c:3398
       kthread+0x288/0x310 kernel/kthread.c:389
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862

-> #1 ((wq_completion)ocfs2_wq){+.+.}-{0:0}:
       touch_wq_lockdep_map+0xa8/0x164 kernel/workqueue.c:3905
       __flush_workqueue+0x120/0x1234 kernel/workqueue.c:3947
       ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:380
       ocfs2_dismount_volume+0x1f4/0x920 fs/ocfs2/super.c:1877
       ocfs2_put_super+0xec/0x368 fs/ocfs2/super.c:1608
       generic_shutdown_super+0x12c/0x2bc fs/super.c:642
       kill_block_super+0x44/0x90 fs/super.c:1710
       deactivate_locked_super+0xc4/0x12c fs/super.c:473
       deactivate_super+0xe0/0x100 fs/super.c:506
       cleanup_mnt+0x34c/0x3dc fs/namespace.c:1373
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1380
       task_work_run+0x230/0x2e0 kernel/task_work.c:239
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       do_notify_resume+0x178/0x1f4 arch/arm64/kernel/entry-common.c:151
       exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline]
       el0_svc+0xac/0x168 arch/arm64/kernel/entry-common.c:745
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (&type->s_umount_key#51
){++++}-{4:4}
:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226
       lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849
       down_read+0x58/0x2fc kernel/locking/rwsem.c:1524
       ocfs2_finish_quota_recovery+0x198/0x1f94 fs/ocfs2/quota_local.c:603
       ocfs2_complete_recovery+0x1610/0x2368 fs/ocfs2/journal.c:1357
       process_one_work+0x7a8/0x15cc kernel/workqueue.c:3236
       process_scheduled_works kernel/workqueue.c:3317 [inline]
       worker_thread+0x97c/0xeec kernel/workqueue.c:3398
       kthread+0x288/0x310 kernel/kthread.c:389
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862

other info that might help us debug this:

Chain exists of:
  &type->s_umount_key#51 --> (wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work)

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock((work_completion)(&journal->j_recovery_work));
                               lock((wq_completion)ocfs2_wq
);
                               lock((work_completion)(&journal->j_recovery_work)
);
  rlock(&type->s_umount_key
#51);

 *** DEADLOCK ***

2 locks held by kworker/u8:11/868:
 #0: ffff0000cd116948
 (
(wq_completion)ocfs2_wq){+.+.}-{0:0}
, at: process_one_work+0x60c/0x15cc kernel/workqueue.c:3210
 #1: 
ffff80009dd47c20 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_one_work+0x6a4/0x15cc kernel/workqueue.c:3210

stack backtrace:
CPU: 1 UID: 0 PID: 868 Comm: kworker/u8:11 Not tainted 6.13.0-rc7-syzkaller-g1950a0af2d55 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Workqueue: ocfs2_wq ocfs2_complete_recovery
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074
 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226
 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849
 down_read+0x58/0x2fc kernel/locking/rwsem.c:1524
 ocfs2_finish_quota_recovery+0x198/0x1f94 fs/ocfs2/quota_local.c:603
 ocfs2_complete_recovery+0x1610/0x2368 fs/ocfs2/journal.c:1357
 process_one_work+0x7a8/0x15cc kernel/workqueue.c:3236
 process_scheduled_works kernel/workqueue.c:3317 [inline]
 worker_thread+0x97c/0xeec kernel/workqueue.c:3398
 kthread+0x288/0x310 kernel/kthread.c:389
 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862