====================================================== WARNING: possible circular locking dependency detected 6.1.83-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/7155 is trying to acquire lock: ffff888070be48c0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 but task is already holding lock: ffff888065802208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1516 ext4_rename fs/ext4/namei.c:3825 [inline] ext4_rename2+0x957/0x4420 fs/ext4/namei.c:4215 vfs_rename+0xd32/0x10f0 fs/namei.c:4876 do_renameat2+0xde0/0x1440 fs/namei.c:5029 __do_sys_renameat2 fs/namei.c:5062 [inline] __se_sys_renameat2 fs/namei.c:5059 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5059 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1751 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1160/0x4820 fs/ext4/mballoc.c:5658 ext4_ext_map_blocks+0x1c3a/0x7b60 fs/ext4/extents.c:4316 ext4_map_blocks+0xa3c/0x1ca0 fs/ext4/inode.c:651 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:2981 ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3027 vfs_mkdir+0x3b6/0x590 fs/namei.c:4108 do_mkdirat+0x225/0x360 fs/namei.c:4133 __do_sys_mkdirat fs/namei.c:4148 [inline] __se_sys_mkdirat fs/namei.c:4146 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4146 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:130 do_insert_tree+0x299/0x1ae0 fs/quota/quota_tree.c:340 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1516 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664 get_tree_bdev+0x3fe/0x620 fs/super.c:1355 vfs_get_tree+0x88/0x270 fs/super.c:1562 do_new_mount+0x2ba/0xb40 fs/namespace.c:3051 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.0/7155: #0: ffff8880658020e0 (&type->s_umount_key#28/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228 #1: ffff8880595d9928 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #2: ffff888065802208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 stack backtrace: CPU: 1 PID: 7155 Comm: syz-executor.0 Not tainted 6.1.83-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:130 do_insert_tree+0x299/0x1ae0 fs/quota/quota_tree.c:340 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1516 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664 get_tree_bdev+0x3fe/0x620 fs/super.c:1355 vfs_get_tree+0x88/0x270 fs/super.c:1562 do_new_mount+0x2ba/0xb40 fs/namespace.c:3051 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7effea27f4aa Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007effeb084ef8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007effeb084f80 RCX: 00007effea27f4aa RDX: 0000000020000100 RSI: 0000000020000200 RDI: 00007effeb084f40 RBP: 0000000020000100 R08: 00007effeb084f80 R09: 0000000000000040 R10: 0000000000000040 R11: 0000000000000202 R12: 0000000020000200 R13: 00007effeb084f40 R14: 0000000000000509 R15: 0000000020000080 EXT4-fs error (device loop0): ext4_do_update_inode:5210: inode #3: comm syz-executor.0: corrupted inode contents EXT4-fs error (device loop0): ext4_dirty_inode:6072: inode #3: comm syz-executor.0: mark_inode_dirty error EXT4-fs error (device loop0): ext4_do_update_inode:5210: inode #3: comm syz-executor.0: corrupted inode contents EXT4-fs error (device loop0): __ext4_ext_dirty:202: inode #3: comm syz-executor.0: mark_inode_dirty error Quota error (device loop0): write_blk: dquota write failed Quota error (device loop0): qtree_write_dquot: Error -117 occurred while creating quota Quota error (device loop0): do_check_range: Getting dqdh_prev_free 134217728 out of range 0-7 Quota error (device loop0): qtree_write_dquot: Error -117 occurred while creating quota Quota error (device loop0): do_check_range: Getting dqdh_prev_free 134217728 out of range 0-7 Quota error (device loop0): qtree_write_dquot: Error -117 occurred while creating quota EXT4-fs (loop0): 1 orphan inode deleted EXT4-fs (loop0): mounted filesystem without journal. Quota mode: writeback. ext4 filesystem being mounted at /root/syzkaller-testdir2262160435/syzkaller.NPNYic/180/file1 supports timestamps until 2038 (0x7fffffff) EXT4-fs error (device loop0): ext4_xattr_block_get:546: inode #15: comm syz-executor.0: corrupted xattr block 19