====================================================== WARNING: possible circular locking dependency detected 6.1.16-syzkaller #0 Not tainted ------------------------------------------------------ kworker/1:7/3749 is trying to acquire lock: ffff88802172c350 (&q->queue_lock){..-.}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:375 [inline] ffff88802172c350 (&q->queue_lock){..-.}-{2:2}, at: throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 but task is already holding lock: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:41 [inline] ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbd/0x840 kernel/time/timer.c:1464 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 ((&sq->pending_timer)){+.-.}-{0:0}: lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 del_timer_sync+0x111/0x2e0 kernel/time/timer.c:1417 throtl_pd_free+0x15/0x40 block/blk-throttle.c:493 blkcg_deactivate_policy+0x32d/0x550 block/blk-cgroup.c:1499 blk_throtl_exit+0xa6/0x140 block/blk-throttle.c:2406 disk_release+0x1dd/0x380 block/genhd.c:1171 device_release+0x91/0x1c0 kobject_cleanup lib/kobject.c:681 [inline] kobject_release lib/kobject.c:712 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0x224/0x460 lib/kobject.c:729 do_floppy_init+0x373/0xc59 drivers/block/floppy.c:4758 async_run_entry_fn+0xa2/0x410 kernel/async.c:127 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #1 (&blkcg->lock){....}-{2:2}: lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:350 [inline] blkg_create+0xa94/0x1280 block/blk-cgroup.c:336 blkcg_init_disk+0xee/0x350 block/blk-cgroup.c:1260 __alloc_disk_node+0x2ce/0x590 block/genhd.c:1385 __blk_mq_alloc_disk+0x11e/0x1e0 block/blk-mq.c:4081 floppy_alloc_disk+0x54/0x360 drivers/block/floppy.c:4514 do_floppy_init+0x1af/0xc59 drivers/block/floppy.c:4595 async_run_entry_fn+0xa2/0x410 kernel/async.c:127 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #0 (&q->queue_lock){..-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:119 [inline] _raw_spin_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:170 spin_lock_irq include/linux/spinlock.h:375 [inline] throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 call_timer_fn+0x200/0x840 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers+0x67c/0x890 kernel/time/timer.c:1790 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1803 __do_softirq+0x30d/0xb1b kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x155/0x240 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649 debug_lockdep_rcu_enabled+0x25/0x30 kernel/rcu/update.c:281 rcu_read_lock_held_common kernel/rcu/update.c:104 [inline] rcu_read_lock_sched_held+0x5f/0x130 kernel/rcu/update.c:123 trace_lock_acquire include/trace/events/lock.h:24 [inline] lock_acquire+0x12f/0x630 kernel/locking/lockdep.c:5640 rcu_lock_acquire+0x2a/0x30 include/linux/rcupdate.h:306 rcu_read_lock include/linux/rcupdate.h:747 [inline] gc_worker+0x289/0x14b0 net/netfilter/nf_conntrack_core.c:1497 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 other info that might help us debug this: Chain exists of: &q->queue_lock --> &blkcg->lock --> (&sq->pending_timer) Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock((&sq->pending_timer)); lock(&blkcg->lock); lock((&sq->pending_timer)); lock(&q->queue_lock); *** DEADLOCK *** 3 locks held by kworker/1:7/3749: #0: ffff888012465d38 ((wq_completion)events_power_efficient){+.+.}-{0:0}, at: process_one_work+0x77b/0x1380 #1: ffffc90005437d20 ((work_completion)(&(&gc_work->dwork)->work)){+.+.}-{0:0}, at: process_one_work+0x7be/0x1380 kernel/workqueue.c:2264 #2: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:41 [inline] #2: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbd/0x840 kernel/time/timer.c:1464 stack backtrace: CPU: 1 PID: 3749 Comm: kworker/1:7 Not tainted 6.1.16-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Workqueue: events_power_efficient gc_worker Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:119 [inline] _raw_spin_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:170 spin_lock_irq include/linux/spinlock.h:375 [inline] throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 call_timer_fn+0x200/0x840 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers+0x67c/0x890 kernel/time/timer.c:1790 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1803 __do_softirq+0x30d/0xb1b kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x155/0x240 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649 RIP: 0010:debug_lockdep_rcu_enabled+0x25/0x30 kernel/rcu/update.c:281 Code: cc cc cc cc cc 31 c0 83 3d 77 d9 c8 03 00 74 1d 83 3d 02 0d c9 03 00 74 14 65 48 8b 0d 54 ab 78 75 31 c0 83 b9 4c 0a 00 00 00 <0f> 94 c0 c3 cc cc cc cc cc cc cc 53 48 8b 7c 24 08 e8 55 fb ff ff RSP: 0018:ffffc900054378d8 EFLAGS: 00000246 RAX: 0000000000000000 RBX: 1ffff92000a86f1c RCX: ffff8880217a1d40 RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffffffff8e529c28 RBP: ffffc90005437970 R08: dffffc0000000000 R09: fffffbfff1ca5386 R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffff92000a86f38 R13: dffffc0000000000 R14: dffffc0000000000 R15: 0000000000004000 rcu_read_lock_held_common kernel/rcu/update.c:104 [inline] rcu_read_lock_sched_held+0x5f/0x130 kernel/rcu/update.c:123 trace_lock_acquire include/trace/events/lock.h:24 [inline] lock_acquire+0x12f/0x630 kernel/locking/lockdep.c:5640 rcu_lock_acquire+0x2a/0x30 include/linux/rcupdate.h:306 rcu_read_lock include/linux/rcupdate.h:747 [inline] gc_worker+0x289/0x14b0 net/netfilter/nf_conntrack_core.c:1497 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 ---------------- Code disassembly (best guess): 0: cc int3 1: cc int3 2: cc int3 3: cc int3 4: cc int3 5: 31 c0 xor %eax,%eax 7: 83 3d 77 d9 c8 03 00 cmpl $0x0,0x3c8d977(%rip) # 0x3c8d985 e: 74 1d je 0x2d 10: 83 3d 02 0d c9 03 00 cmpl $0x0,0x3c90d02(%rip) # 0x3c90d19 17: 74 14 je 0x2d 19: 65 48 8b 0d 54 ab 78 mov %gs:0x7578ab54(%rip),%rcx # 0x7578ab75 20: 75 21: 31 c0 xor %eax,%eax 23: 83 b9 4c 0a 00 00 00 cmpl $0x0,0xa4c(%rcx) * 2a: 0f 94 c0 sete %al <-- trapping instruction 2d: c3 retq 2e: cc int3 2f: cc int3 30: cc int3 31: cc int3 32: cc int3 33: cc int3 34: cc int3 35: 53 push %rbx 36: 48 8b 7c 24 08 mov 0x8(%rsp),%rdi 3b: e8 55 fb ff ff callq 0xfffffb95