======================================================
WARNING: possible circular locking dependency detected
4.14.302-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/14696 is trying to acquire lock:
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818931d9>] inode_lock_shared include/linux/fs.h:729 [inline]
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818931d9>] lookup_slow+0x129/0x400 fs/namei.c:1674

but task is already holding lock:
 (&oi->lock){+.+.}, at: [<ffffffff823184ef>] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318
       ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:631
       ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:686
       ovl_xattr_set+0x18c/0x290 fs/overlayfs/inode.c:227
       __vfs_setxattr+0xdc/0x130 fs/xattr.c:150
       __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181
       __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239
       vfs_setxattr+0xcf/0x230 fs/xattr.c:256
       setxattr+0x1a9/0x300 fs/xattr.c:523
       path_setxattr+0x118/0x130 fs/xattr.c:542
       SYSC_setxattr fs/xattr.c:557 [inline]
       SyS_setxattr+0x36/0x50 fs/xattr.c:553
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #1 (sb_writers#3){.+.+}:
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1551 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_rename+0x11b/0xe50 fs/overlayfs/dir.c:935
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (&ovl_i_mutex_dir_key[depth]){++++}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       down_read+0x36/0x80 kernel/locking/rwsem.c:24
       inode_lock_shared include/linux/fs.h:729 [inline]
       lookup_slow+0x129/0x400 fs/namei.c:1674
       lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
       ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
       ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

Chain exists of:
  &ovl_i_mutex_dir_key[depth] --> sb_writers#3 --> &oi->lock

 Possible unsafe locking scenario:

overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
       CPU0                    CPU1
       ----                    ----
  lock(&oi->lock);
                               lock(sb_writers#3);
                               lock(&oi->lock);
  lock(&ovl_i_mutex_dir_key[depth]);

 *** DEADLOCK ***

8 locks held by syz-executor.5/14696:
 #0:  (sb_writers#15){.+.+}, at: [<ffffffff818e1ffa>] sb_start_write include/linux/fs.h:1551 [inline]
 #0:  (sb_writers#15){.+.+}, at: [<ffffffff818e1ffa>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #1:  (&type->s_vfs_rename_key#2){+.+.}, at: [<ffffffff81893504>] lock_rename+0x54/0x280 fs/namei.c:2889
 #2:  (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [<ffffffff81893550>] inode_lock_nested include/linux/fs.h:754 [inline]
 #2:  (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [<ffffffff81893550>] lock_rename+0xa0/0x280 fs/namei.c:2893
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
 #3:  (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [<ffffffff81893584>] inode_lock_nested include/linux/fs.h:754 [inline]
 #3:  (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [<ffffffff81893584>] lock_rename+0xd4/0x280 fs/namei.c:2894
 #4:  (&ovl_i_mutex_key[depth]#2){+.+.}, at: [<ffffffff818ccd0a>] inode_lock include/linux/fs.h:719 [inline]
 #4:  (&ovl_i_mutex_key[depth]#2){+.+.}, at: [<ffffffff818ccd0a>] lock_two_nondirectories+0xca/0xf0 fs/inode.c:989
 #5:  (&ovl_i_mutex_key[depth]#2/4){+.+.}, at: [<ffffffff818cccf2>] inode_lock_nested include/linux/fs.h:754 [inline]
 #5:  (&ovl_i_mutex_key[depth]#2/4){+.+.}, at: [<ffffffff818cccf2>] lock_two_nondirectories+0xb2/0xf0 fs/inode.c:991
 #6:  (sb_writers#3){.+.+}, at: [<ffffffff818e1ffa>] sb_start_write include/linux/fs.h:1551 [inline]
 #6:  (sb_writers#3){.+.+}, at: [<ffffffff818e1ffa>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #7:  (&oi->lock){+.+.}, at: [<ffffffff823184ef>] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523

stack backtrace:
CPU: 1 PID: 14696 Comm: syz-executor.5 Not tainted 4.14.302-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 down_read+0x36/0x80 kernel/locking/rwsem.c:24
 inode_lock_shared include/linux/fs.h:729 [inline]
 lookup_slow+0x129/0x400 fs/namei.c:1674
 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
 ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
 ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
 vfs_rename+0x560/0x1820 fs/namei.c:4498
 SYSC_renameat2 fs/namei.c:4646 [inline]
 SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7f2c381ae0d9
RSP: 002b:00007f2c36720168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f2c382cdf80 RCX: 00007f2c381ae0d9
RDX: 0000000000000000 RSI: 0000000020000500 RDI: 00000000200003c0
RBP: 00007f2c38209ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffe27fa35af R14: 00007f2c36720300 R15: 0000000000022000
Bluetooth: hci0 command 0x0406 tx timeout
Bluetooth: hci1 command 0x0406 tx timeout
Bluetooth: hci2 command 0x0406 tx timeout
Bluetooth: hci3 command 0x0406 tx timeout
Bluetooth: hci5 command 0x0406 tx timeout
Bluetooth: hci4 command 0x0406 tx timeout
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
EXT4-fs warning (device sda1): ext4_resize_begin:82: There are errors in the filesystem, so online resizing is not allowed
audit: type=1800 audit(6949499682.981:83): pid=14893 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="sda1" ino=14592 res=0
audit: type=1804 audit(6949499683.055:84): pid=14893 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir654859835/syzkaller.MXaM81/173/file0" dev="sda1" ino=14592 res=1
RDS: rds_bind could not find a transport for 10.1.1.2, load rds_tcp or rds_rdma?
audit: type=1804 audit(6949499683.086:85): pid=14893 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.0" name="/root/syzkaller-testdir654859835/syzkaller.MXaM81/173/file0" dev="sda1" ino=14592 res=1
EXT4-fs warning (device sda1): ext4_resize_begin:82: There are errors in the filesystem, so online resizing is not allowed
audit: type=1800 audit(6949499685.174:86): pid=14911 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="sda1" ino=13880 res=0
audit: type=1804 audit(6949499685.290:87): pid=14911 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir654859835/syzkaller.MXaM81/174/file0" dev="sda1" ino=13880 res=1
audit: type=1804 audit(6949499685.374:88): pid=14911 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="ToMToU" comm="syz-executor.0" name="/root/syzkaller-testdir654859835/syzkaller.MXaM81/174/file0" dev="sda1" ino=13880 res=1
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
unregister_netdevice: waiting for ip6gre0 to become free. Usage count = -1
9pnet: Insufficient options for proto=fd
EXT4-fs warning (device sda1): ext4_resize_begin:82: There are errors in the filesystem, so online resizing is not allowed
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
audit: type=1800 audit(6949499687.735:89): pid=14959 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="sda1" ino=14597 res=0
audit: type=1804 audit(6949499688.039:90): pid=14959 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir654859835/syzkaller.MXaM81/175/file0" dev="sda1" ino=14597 res=1