====================================================== WARNING: possible circular locking dependency detected 5.2.0+ #66 Not tainted ------------------------------------------------------ syz-executor.3/26328 is trying to acquire lock: 0000000094a53d3d (&xs->mutex){+.+.}, at: xsk_notifier+0x145/0x2a0 /net/xdp/xsk.c:764 but task is already holding lock: 00000000a315f587 (&net->xdp.lock){+.+.}, at: xsk_notifier+0xa3/0x2a0 /net/xdp/xsk.c:760 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&net->xdp.lock){+.+.}: __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 xsk_notifier+0xa3/0x2a0 /net/xdp/xsk.c:760 notifier_call_chain+0xc2/0x230 /kernel/notifier.c:95 __raw_notifier_call_chain /kernel/notifier.c:396 [inline] raw_notifier_call_chain+0x2e/0x40 /kernel/notifier.c:403 call_netdevice_notifiers_info+0x3f/0x90 /net/core/dev.c:1749 call_netdevice_notifiers_extack /net/core/dev.c:1761 [inline] call_netdevice_notifiers /net/core/dev.c:1775 [inline] rollback_registered_many+0x9b9/0xfc0 /net/core/dev.c:8196 unregister_netdevice_many.part.0+0x1b/0x1f0 /net/core/dev.c:9304 unregister_netdevice_many+0x3b/0x50 /net/core/dev.c:9303 rtnl_delete_link+0xda/0x130 /net/core/rtnetlink.c:2814 rtnl_dellink+0x35a/0x970 /net/core/rtnetlink.c:2869 rtnetlink_rcv_msg+0x463/0xb00 /net/core/rtnetlink.c:5223 netlink_rcv_skb+0x177/0x450 /net/netlink/af_netlink.c:2477 rtnetlink_rcv+0x1d/0x30 /net/core/rtnetlink.c:5241 netlink_unicast_kernel /net/netlink/af_netlink.c:1302 [inline] netlink_unicast+0x531/0x710 /net/netlink/af_netlink.c:1328 netlink_sendmsg+0x8ae/0xd70 /net/netlink/af_netlink.c:1917 sock_sendmsg_nosec /net/socket.c:633 [inline] sock_sendmsg+0xd7/0x130 /net/socket.c:653 ___sys_sendmsg+0x803/0x920 /net/socket.c:2307 __sys_sendmsg+0x105/0x1d0 /net/socket.c:2352 __do_sys_sendmsg /net/socket.c:2361 [inline] __se_sys_sendmsg /net/socket.c:2359 [inline] __x64_sys_sendmsg+0x78/0xb0 /net/socket.c:2359 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #1 (rtnl_mutex){+.+.}: __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 rtnl_lock+0x17/0x20 /net/core/rtnetlink.c:72 xdp_umem_assign_dev+0xbe/0x8f0 /net/xdp/xdp_umem.c:96 xsk_bind+0x4d7/0xe80 /net/xdp/xsk.c:502 __sys_bind+0x239/0x290 /net/socket.c:1643 __do_sys_bind /net/socket.c:1654 [inline] __se_sys_bind /net/socket.c:1652 [inline] __x64_sys_bind+0x73/0xb0 /net/socket.c:1652 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&xs->mutex){+.+.}: check_prev_add /kernel/locking/lockdep.c:2405 [inline] check_prevs_add /kernel/locking/lockdep.c:2507 [inline] validate_chain /kernel/locking/lockdep.c:2897 [inline] __lock_acquire+0x25a0/0x4690 /kernel/locking/lockdep.c:3880 lock_acquire+0x190/0x410 /kernel/locking/lockdep.c:4413 __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 xsk_notifier+0x145/0x2a0 /net/xdp/xsk.c:764 notifier_call_chain+0xc2/0x230 /kernel/notifier.c:95 __raw_notifier_call_chain /kernel/notifier.c:396 [inline] raw_notifier_call_chain+0x2e/0x40 /kernel/notifier.c:403 call_netdevice_notifiers_info+0x3f/0x90 /net/core/dev.c:1749 call_netdevice_notifiers_extack /net/core/dev.c:1761 [inline] call_netdevice_notifiers /net/core/dev.c:1775 [inline] rollback_registered_many+0x9b9/0xfc0 /net/core/dev.c:8196 rollback_registered+0x109/0x1d0 /net/core/dev.c:8238 unregister_netdevice_queue /net/core/dev.c:9285 [inline] unregister_netdevice_queue+0x1ee/0x2c0 /net/core/dev.c:9278 br_dev_delete+0x145/0x1a0 /net/bridge/br_if.c:383 br_del_bridge+0xd7/0x120 /net/bridge/br_if.c:483 br_ioctl_deviceless_stub+0x2b0/0x7c0 /net/bridge/br_ioctl.c:376 sock_ioctl+0x44b/0x790 /net/socket.c:1132 vfs_ioctl /fs/ioctl.c:46 [inline] file_ioctl /fs/ioctl.c:509 [inline] do_vfs_ioctl+0xd5f/0x1380 /fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713 __do_sys_ioctl /fs/ioctl.c:720 [inline] __se_sys_ioctl /fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: &xs->mutex --> rtnl_mutex --> &net->xdp.lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&net->xdp.lock); lock(rtnl_mutex); lock(&net->xdp.lock); lock(&xs->mutex); *** DEADLOCK *** 3 locks held by syz-executor.3/26328: #0: 00000000cb1668fd (br_ioctl_mutex){+.+.}, at: sock_ioctl+0x427/0x790 /net/socket.c:1130 #1: 0000000048998f55 (rtnl_mutex){+.+.}, at: rtnl_lock+0x17/0x20 /net/core/rtnetlink.c:72 #2: 00000000a315f587 (&net->xdp.lock){+.+.}, at: xsk_notifier+0xa3/0x2a0 /net/xdp/xsk.c:760 stack backtrace: CPU: 1 PID: 26328 Comm: syz-executor.3 Not tainted 5.2.0+ #66 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack /lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 /lib/dump_stack.c:113 print_circular_bug.cold+0x163/0x172 /kernel/locking/lockdep.c:1617 check_noncircular+0x345/0x3e0 /kernel/locking/lockdep.c:1741 check_prev_add /kernel/locking/lockdep.c:2405 [inline] check_prevs_add /kernel/locking/lockdep.c:2507 [inline] validate_chain /kernel/locking/lockdep.c:2897 [inline] __lock_acquire+0x25a0/0x4690 /kernel/locking/lockdep.c:3880 lock_acquire+0x190/0x410 /kernel/locking/lockdep.c:4413 __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 xsk_notifier+0x145/0x2a0 /net/xdp/xsk.c:764 notifier_call_chain+0xc2/0x230 /kernel/notifier.c:95 __raw_notifier_call_chain /kernel/notifier.c:396 [inline] raw_notifier_call_chain+0x2e/0x40 /kernel/notifier.c:403 call_netdevice_notifiers_info+0x3f/0x90 /net/core/dev.c:1749 call_netdevice_notifiers_extack /net/core/dev.c:1761 [inline] call_netdevice_notifiers /net/core/dev.c:1775 [inline] rollback_registered_many+0x9b9/0xfc0 /net/core/dev.c:8196 rollback_registered+0x109/0x1d0 /net/core/dev.c:8238 unregister_netdevice_queue /net/core/dev.c:9285 [inline] unregister_netdevice_queue+0x1ee/0x2c0 /net/core/dev.c:9278 br_dev_delete+0x145/0x1a0 /net/bridge/br_if.c:383 br_del_bridge+0xd7/0x120 /net/bridge/br_if.c:483 br_ioctl_deviceless_stub+0x2b0/0x7c0 /net/bridge/br_ioctl.c:376 sock_ioctl+0x44b/0x790 /net/socket.c:1132 vfs_ioctl /fs/ioctl.c:46 [inline] file_ioctl /fs/ioctl.c:509 [inline] do_vfs_ioctl+0xd5f/0x1380 /fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713 __do_sys_ioctl /fs/ioctl.c:720 [inline] __se_sys_ioctl /fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x459819 Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fa247611c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819 RDX: 0000000020000180 RSI: 00000000000089a1 RDI: 0000000000000004 RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fa2476126d4 R13: 00000000004c5165 R14: 00000000004d93e8 R15: 00000000ffffffff kobject: 'batman_adv' (00000000870f886e): kobject_uevent_env kobject: 'batman_adv' (00000000870f886e): kobject_uevent_env: filter function caused the event to drop! kobject: 'batman_adv' (00000000870f886e): kobject_cleanup, parent 00000000773e956e kobject: 'batman_adv' (00000000870f886e): calling ktype release kobject: (00000000870f886e): dynamic_kobj_release kobject: 'batman_adv': free name kobject: 'rx-0' (00000000c4dbe817): kobject_cleanup, parent 000000005d0ede73 kobject: 'rx-0' (00000000c4dbe817): auto cleanup 'remove' event kobject: 'rx-0' (00000000c4dbe817): kobject_uevent_env kobject: 'rx-0' (00000000c4dbe817): fill_kobj_path: path = '/devices/virtual/net/bcsf0/queues/rx-0' kobject: 'rx-0' (00000000c4dbe817): auto cleanup kobject_del kobject: 'rx-0' (00000000c4dbe817): calling ktype release kobject: 'rx-0': free name kobject: 'tx-0' (00000000afc9442a): kobject_cleanup, parent 000000005d0ede73 kobject: 'tx-0' (00000000afc9442a): auto cleanup 'remove' event kobject: 'tx-0' (00000000afc9442a): kobject_uevent_env kobject: 'tx-0' (00000000afc9442a): fill_kobj_path: path = '/devices/virtual/net/bcsf0/queues/tx-0' kobject: 'tx-0' (00000000afc9442a): auto cleanup kobject_del kobject: 'tx-0' (00000000afc9442a): calling ktype release kobject: 'tx-0': free name kobject: 'queues' (000000005d0ede73): kobject_cleanup, parent 00000000773e956e kobject: 'queues' (000000005d0ede73): calling ktype release kobject: 'queues' (000000005d0ede73): kset_release kobject: 'queues': free name kobject: 'bcsf0' (000000004975c0d9): kobject_uevent_env kobject: 'bcsf0' (000000004975c0d9): fill_kobj_path: path = '/devices/virtual/net/bcsf0' kobject: 'bcsf0' (000000004975c0d9): kobject_cleanup, parent 00000000773e956e kobject: 'bcsf0' (000000004975c0d9): calling ktype release kobject: 'bcsf0': free name