====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc5-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/23984 is trying to acquire lock: ffff88801cfc58f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff88802b7c5608 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x226/0x1120 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 hfsplus_get_block+0x277/0x9e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x3df/0xae0 fs/buffer.c:2400 filemap_read_folio+0xe9/0x2c0 mm/filemap.c:2382 do_read_cache_folio+0x205/0x540 mm/filemap.c:3742 do_read_cache_page mm/filemap.c:3808 [inline] read_cache_page+0x5b/0x230 mm/filemap.c:3817 read_mapping_page include/linux/pagemap.h:860 [inline] hfsplus_block_allocate+0x144/0x990 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_get_block+0x1ae/0x9e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x3c0/0x1560 fs/buffer.c:2120 __block_write_begin fs/buffer.c:2169 [inline] block_write_begin+0xb1/0x490 fs/buffer.c:2228 cont_write_begin+0x52f/0x730 fs/buffer.c:2585 hfsplus_write_begin+0x87/0x140 fs/hfsplus/inode.c:52 generic_perform_write+0x278/0x600 mm/filemap.c:3969 __generic_file_write_iter+0x1f9/0x240 mm/filemap.c:4064 generic_file_write_iter+0xe3/0x350 mm/filemap.c:4090 call_write_iter include/linux/fs.h:1956 [inline] do_iter_readv_writev+0x21e/0x3c0 fs/read_write.c:735 do_iter_write+0x17f/0x830 fs/read_write.c:860 vfs_writev+0x221/0x700 fs/read_write.c:933 do_pwritev+0x1af/0x260 fs/read_write.c:1030 __do_sys_pwritev2 fs/read_write.c:1089 [inline] __se_sys_pwritev2 fs/read_write.c:1080 [inline] __x64_sys_pwritev2+0xef/0x150 fs/read_write.c:1080 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a2/0x510 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xe7f/0x1120 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x18f/0x220 fs/hfsplus/inode.c:454 hfsplus_unlink+0x57f/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f1/0x900 fs/namei.c:4332 do_unlinkat+0x3da/0x6d0 fs/namei.c:4398 __do_sys_unlink fs/namei.c:4446 [inline] __se_sys_unlink fs/namei.c:4444 [inline] __x64_sys_unlink+0xc8/0x110 fs/namei.c:4444 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 5 locks held by syz-executor.1/23984: #0: ffff88801a932410 (sb_writers#27){.+.+}-{0:0}, at: do_unlinkat+0x1ca/0x6d0 fs/namei.c:4379 #1: ffff88805fb277c0 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #1: ffff88805fb277c0 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}, at: do_unlinkat+0x27c/0x6d0 fs/namei.c:4383 #2: ffff88802b7c5800 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] ffff88802b7c5800 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: vfs_unlink+0xd3/0x900 fs/namei.c:4321 #3: ffff88801cfc5998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x184/0x7f0 fs/hfsplus/dir.c:370 #4: ffff88802b7c5608 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x226/0x1120 fs/hfsplus/extents.c:576 stack backtrace: CPU: 2 PID: 23984 Comm: syz-executor.1 Not tainted 6.6.0-rc5-syzkaller #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a2/0x510 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xe7f/0x1120 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x18f/0x220 fs/hfsplus/inode.c:454 hfsplus_unlink+0x57f/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x2f1/0x900 fs/namei.c:4332 do_unlinkat+0x3da/0x6d0 fs/namei.c:4398 __do_sys_unlink fs/namei.c:4446 [inline] __se_sys_unlink fs/namei.c:4444 [inline] __x64_sys_unlink+0xc8/0x110 fs/namei.c:4444 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f1ed467cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1ed53020c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 00007f1ed479bf80 RCX: 00007f1ed467cae9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000300 RBP: 00007f1ed46c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f1ed479bf80 R15: 00007ffe99b8cef8