====================================================== WARNING: possible circular locking dependency detected 5.15.173-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.262/5550 is trying to acquire lock: ffff0000c7bddd18 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa0/0x128 mm/memory.c:5354 but task is already holding lock: ffff0000e8d5ea20 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x2a8/0xc78 fs/ocfs2/extent_map.c:755 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_read_virt_blocks+0x298/0x960 fs/ocfs2/extent_map.c:976 ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline] ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline] ocfs2_find_entry+0x3ac/0x2450 fs/ocfs2/dir.c:1080 ocfs2_find_files_on_disk+0x10c/0x3d0 fs/ocfs2/dir.c:1982 ocfs2_lookup_ino_from_name+0xb8/0x1d4 fs/ocfs2/dir.c:2004 _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline] ocfs2_get_system_file_inode+0x2c8/0x6b8 fs/ocfs2/sysfile.c:112 ocfs2_init_global_system_inodes+0x2bc/0x618 fs/ocfs2/super.c:458 ocfs2_initialize_super fs/ocfs2/super.c:2276 [inline] ocfs2_fill_super+0x394c/0x498c fs/ocfs2/super.c:995 mount_bdev+0x274/0x370 fs/super.c:1400 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #5 (&osb->system_file_mutex){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ocfs2_get_system_file_inode+0x180/0x6b8 fs/ocfs2/sysfile.c:101 ocfs2_reserve_local_alloc_bits+0xe4/0x2474 fs/ocfs2/localalloc.c:626 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588 ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030 ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2824 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #4 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ocfs2_create_local_dquot+0x194/0x1618 fs/ocfs2/quota_local.c:1231 ocfs2_acquire_dquot+0x6f8/0xa90 fs/ocfs2/quota_global.c:866 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2824 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #3 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x1f8/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5739 ext4_new_meta_blocks+0x1ac/0x430 fs/ext4/balloc.c:738 ext4_xattr_block_set+0x1c94/0x2dcc fs/ext4/xattr.c:2099 ext4_xattr_set_handle+0xb04/0x12d8 fs/ext4/xattr.c:2412 ext4_xattr_set+0x220/0x340 fs/ext4/xattr.c:2513 ext4_xattr_user_set+0xd4/0xfc fs/ext4/xattr_user.c:41 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:303 do_setxattr fs/xattr.c:588 [inline] setxattr+0x250/0x2b4 fs/xattr.c:611 path_setxattr+0x17c/0x258 fs/xattr.c:630 __do_sys_setxattr fs/xattr.c:646 [inline] __se_sys_setxattr fs/xattr.c:642 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:642 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #2 (&ei->xattr_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ext4_readpage_inline+0x38/0x244 fs/ext4/inline.c:518 ext4_readpage+0x15c/0x3b8 fs/ext4/inode.c:3225 filemap_read_page+0x150/0x454 mm/filemap.c:2386 filemap_update_page mm/filemap.c:2464 [inline] filemap_get_pages mm/filemap.c:2574 [inline] filemap_read+0xe3c/0x1bd8 mm/filemap.c:2634 generic_file_read_iter+0xa0/0x3c4 mm/filemap.c:2794 ext4_file_read_iter+0x30c/0x540 call_read_iter include/linux/fs.h:2168 [inline] generic_file_splice_read+0x3a0/0x60c fs/splice.c:311 do_splice_to fs/splice.c:796 [inline] splice_direct_to_actor+0x354/0x9a0 fs/splice.c:870 do_splice_direct+0x1f4/0x334 fs/splice.c:979 ovl_copy_up_data+0x420/0x5f4 fs/overlayfs/copy_up.c:275 ovl_copy_up_meta_inode_data fs/overlayfs/copy_up.c:918 [inline] ovl_copy_up_one fs/overlayfs/copy_up.c:1005 [inline] ovl_copy_up_flags+0xe68/0x213c fs/overlayfs/copy_up.c:1047 ovl_maybe_copy_up+0x160/0x17c fs/overlayfs/copy_up.c:1079 ovl_open+0x98/0x1e0 fs/overlayfs/file.c:149 do_dentry_open+0x780/0xed8 fs/open.c:826 vfs_open+0x7c/0x90 fs/open.c:956 do_open fs/namei.c:3608 [inline] path_openat+0x1ea0/0x26cc fs/namei.c:3742 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (mapping.invalidate_lock){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 filemap_invalidate_lock_shared include/linux/fs.h:844 [inline] filemap_fault+0x52c/0xf5c mm/filemap.c:3081 __do_fault+0x120/0x5d0 mm/memory.c:3926 do_read_fault mm/memory.c:4262 [inline] do_fault mm/memory.c:4390 [inline] handle_pte_fault mm/memory.c:4648 [inline] __handle_mm_fault mm/memory.c:4783 [inline] handle_mm_fault+0x21e8/0x33a8 mm/memory.c:4881 __do_page_fault arch/arm64/mm/fault.c:505 [inline] do_page_fault+0x700/0xb60 arch/arm64/mm/fault.c:605 do_translation_fault+0xe8/0x138 arch/arm64/mm/fault.c:686 do_mem_abort+0x70/0x1d8 arch/arm64/mm/fault.c:819 el0_da+0x94/0x20c arch/arm64/kernel/entry-common.c:494 el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __might_fault+0xc8/0x128 mm/memory.c:5355 _copy_to_user include/linux/uaccess.h:174 [inline] copy_to_user include/linux/uaccess.h:200 [inline] fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144 ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline] ocfs2_fiemap+0x994/0xc78 fs/ocfs2/extent_map.c:762 ioctl_fiemap fs/ioctl.c:219 [inline] do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814 __do_sys_ioctl fs/ioctl.c:872 [inline] __se_sys_ioctl fs/ioctl.c:860 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(&osb->system_file_mutex); lock(&ocfs2_file_ip_alloc_sem_key); lock(&mm->mmap_lock); *** DEADLOCK *** 1 lock held by syz.4.262/5550: #0: ffff0000e8d5ea20 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x2a8/0xc78 fs/ocfs2/extent_map.c:755 stack backtrace: CPU: 0 PID: 5550 Comm: syz.4.262 Not tainted 5.15.173-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __might_fault+0xc8/0x128 mm/memory.c:5355 _copy_to_user include/linux/uaccess.h:174 [inline] copy_to_user include/linux/uaccess.h:200 [inline] fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144 ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline] ocfs2_fiemap+0x994/0xc78 fs/ocfs2/extent_map.c:762 ioctl_fiemap fs/ioctl.c:219 [inline] do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814 __do_sys_ioctl fs/ioctl.c:872 [inline] __se_sys_ioctl fs/ioctl.c:860 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584