loop0: detected capacity change from 0 to 1024 ip6gretap1: entered allmulticast mode bridge0: port 3(ip6gretap1) entered blocking state bridge0: port 3(ip6gretap1) entered disabled state ip6gretap1: entered promiscuous mode bridge0: port 3(ip6gretap1) entered blocking state bridge0: port 3(ip6gretap1) entered forwarding state hfsplus: invalid extended attribute record ====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc1-syzkaller-00236-g8c6bc74c7f89 #0 Not tainted ------------------------------------------------------ syz.0.0/5326 is trying to acquire lock: ffff888052d448f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xbe/0x550 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff888052d73048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x294/0xb40 fs/hfsplus/extents.c:577 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 hfsplus_get_block+0x39e/0x1530 fs/hfsplus/extents.c:260 block_read_full_folio+0x29c/0x830 fs/buffer.c:2427 filemap_read_folio+0x114/0x380 mm/filemap.c:2412 do_read_cache_folio+0x350/0x590 mm/filemap.c:3894 do_read_cache_page mm/filemap.c:3960 [inline] read_cache_page+0x5d/0x170 mm/filemap.c:3969 read_mapping_page include/linux/pagemap.h:966 [inline] hfsplus_block_allocate+0xe4/0x9b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xae3/0x1990 fs/hfsplus/extents.c:469 hfsplus_get_block+0x411/0x1530 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6b2/0x1900 fs/buffer.c:2151 block_write_begin fs/buffer.c:2262 [inline] cont_write_begin+0x789/0xb50 fs/buffer.c:2601 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:46 cont_expand_zero fs/buffer.c:2528 [inline] cont_write_begin+0x2fa/0xb50 fs/buffer.c:2591 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x2c4/0x910 mm/filemap.c:4112 generic_file_write_iter+0x10f/0x540 mm/filemap.c:4255 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x548/0xa90 fs/read_write.c:686 ksys_write+0x145/0x250 fs/read_write.c:738 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 hfsplus_block_free+0xbe/0x550 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x176/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x736/0xb40 fs/hfsplus/extents.c:592 hfsplus_delete_inode+0x180/0x230 fs/hfsplus/inode.c:-1 hfsplus_unlink+0x4e3/0x730 fs/hfsplus/dir.c:405 hfsplus_rename+0xcb/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xb99/0xec0 fs/namei.c:5128 do_renameat2+0x878/0xc50 fs/namei.c:5277 __do_sys_rename fs/namei.c:5324 [inline] __se_sys_rename fs/namei.c:5322 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5322 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 6 locks held by syz.0.0/5326: #0: ffff8880332b0428 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:557 #1: ffff888052d71df8 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:912 [inline] #1: ffff888052d71df8 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: lock_rename fs/namei.c:3272 [inline] #1: ffff888052d71df8 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: do_renameat2+0x3dd/0xc50 fs/namei.c:5223 #2: ffff888052d72b78 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #2: ffff888052d72b78 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: lock_two_nondirectories+0xe7/0x180 fs/inode.c:1233 #3: ffff888052d73238 (&sb->s_type->i_mutex_key#20/4){+.+.}-{4:4}, at: vfs_rename+0x69a/0xec0 fs/namei.c:5099 #4: ffff888052d44998 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_unlink+0x160/0x730 fs/hfsplus/dir.c:370 #5: ffff888052d73048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x294/0xb40 fs/hfsplus/extents.c:577 stack backtrace: CPU: 0 UID: 0 PID: 5326 Comm: syz.0.0 Not tainted 6.16.0-rc1-syzkaller-00236-g8c6bc74c7f89 #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 hfsplus_block_free+0xbe/0x550 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x176/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x736/0xb40 fs/hfsplus/extents.c:592 hfsplus_delete_inode+0x180/0x230 fs/hfsplus/inode.c:-1 hfsplus_unlink+0x4e3/0x730 fs/hfsplus/dir.c:405 hfsplus_rename+0xcb/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xb99/0xec0 fs/namei.c:5128 do_renameat2+0x878/0xc50 fs/namei.c:5277 __do_sys_rename fs/namei.c:5324 [inline] __se_sys_rename fs/namei.c:5322 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5322 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f1f4d78e929 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1f4e6c1038 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f1f4d9b5fa0 RCX: 00007f1f4d78e929 RDX: 0000000000000000 RSI: 0000200000000240 RDI: 0000200000000180 RBP: 00007f1f4d810b39 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f1f4d9b5fa0 R15: 00007ffe46b9dd08 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent