====================================================== WARNING: possible circular locking dependency detected 5.15.161-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.792/6584 is trying to acquire lock: ffff88807464dc30 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_move_extents+0x3a1/0xe80 fs/ext4/move_extent.c:610 but task is already holding lock: ffff888074649668 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ei->i_data_sem/2){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1516 ext4_unlink+0x16c/0x530 fs/ext4/namei.c:3320 vfs_unlink+0x359/0x5f0 fs/namei.c:4280 do_unlinkat+0x4a3/0x950 fs/namei.c:4348 __do_sys_unlink fs/namei.c:4396 [inline] __se_sys_unlink fs/namei.c:4394 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4394 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x74e/0xe30 fs/quota/dquot.c:986 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2825 quota_setquota+0x6d3/0x840 fs/quota/quota.c:309 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:915 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1751 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12d8/0x4d60 fs/ext4/mballoc.c:5743 ext4_new_meta_blocks+0x206/0x4f0 fs/ext4/balloc.c:738 ext4_ext_grow_indepth fs/ext4/extents.c:1323 [inline] ext4_ext_create_new_leaf fs/ext4/extents.c:1429 [inline] ext4_ext_insert_extent+0xf43/0x4e60 fs/ext4/extents.c:2099 ext4_split_extent_at+0x80e/0x10f0 fs/ext4/extents.c:3229 ext4_force_split_extent_at fs/ext4/extents.c:319 [inline] ext4_swap_extents+0x136e/0x2340 fs/ext4/extents.c:5752 move_extent_per_page+0x18b6/0x3010 fs/ext4/move_extent.c:360 ext4_move_extents+0x9e2/0xe80 fs/ext4/move_extent.c:674 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x2fcb/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ei->i_data_sem/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 ext4_move_extents+0x3a1/0xe80 fs/ext4/move_extent.c:610 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x2fcb/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&ei->i_data_sem/1); *** DEADLOCK *** 4 locks held by syz.0.792/6584: #0: ffff888024a38460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421 #1: ffff8880746497e0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff8880746497e0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1083 #2: ffff88807464dda8 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: ext4_move_extents+0x386/0xe80 fs/ext4/move_extent.c:603 #3: ffff888074649668 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 stack backtrace: CPU: 0 PID: 6584 Comm: syz.0.792 Not tainted 5.15.161-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 ext4_move_extents+0x3a1/0xe80 fs/ext4/move_extent.c:610 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x2fcb/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fbb915fad39 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbb9007b048 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fbb91788fa0 RCX: 00007fbb915fad39 RDX: 0000000020000080 RSI: 00000000c028660f RDI: 0000000000000004 RBP: 00007fbb9167b766 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fbb91788fa0 R15: 00007ffd84a91948