====================================================== WARNING: possible circular locking dependency detected 6.4.0-rc7-syzkaller-00226-ga92b7d26c743 #0 Not tainted ------------------------------------------------------ syz-executor107/4992 is trying to acquire lock: ffff888017b94ec8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1bf/0xf90 fs/hfsplus/extents.c:457 but task is already holding lock: ffff88807a3fc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1bb/0x230 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 hfsplus_file_truncate+0xe93/0x10e0 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1f2/0x320 fs/hfsplus/inode.c:269 notify_change+0xb2c/0x1180 fs/attr.c:483 do_truncate+0x143/0x200 fs/open.c:66 handle_truncate fs/namei.c:3295 [inline] do_open fs/namei.c:3640 [inline] path_openat+0x2083/0x2750 fs/namei.c:3791 do_filp_open+0x1ba/0x410 fs/namei.c:3818 do_sys_openat2+0x16d/0x4c0 fs/open.c:1356 do_sys_open fs/open.c:1372 [inline] __do_sys_creat fs/open.c:1448 [inline] __se_sys_creat fs/open.c:1442 [inline] __x64_sys_creat+0xcd/0x120 fs/open.c:1442 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain kernel/locking/lockdep.c:3847 [inline] __lock_acquire+0x2fcd/0x5f30 kernel/locking/lockdep.c:5088 lock_acquire kernel/locking/lockdep.c:5705 [inline] lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5670 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1bf/0xf90 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x271/0x1270 fs/hfsplus/catalog.c:456 hfsplus_rename+0x11d/0x210 fs/hfsplus/dir.c:552 vfs_rename+0xef6/0x17a0 fs/namei.c:4849 do_renameat2+0xc04/0xd40 fs/namei.c:5002 __do_sys_renameat2 fs/namei.c:5035 [inline] __se_sys_renameat2 fs/namei.c:5032 [inline] __x64_sys_renameat2+0xe8/0x120 fs/namei.c:5032 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 7 locks held by syz-executor107/4992: #0: ffff888019350460 (sb_writers#10){.+.+}-{0:0}, at: do_renameat2+0x386/0xd40 fs/namei.c:4936 #1: ffff888019350748 (&type->s_vfs_rename_key#2){+.+.}-{3:3}, at: lock_rename fs/namei.c:3046 [inline] #1: ffff888019350748 (&type->s_vfs_rename_key#2){+.+.}-{3:3}, at: do_renameat2+0x686/0xd40 fs/namei.c:4941 #2: ffff888019bf57c0 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:810 [inline] #2: ffff888019bf57c0 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_two_directories+0x5b/0x1e0 fs/namei.c:3019 #3: ffff888019bf4a40 (&sb->s_type->i_mutex_key#15/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:810 [inline] #3: ffff888019bf4a40 (&sb->s_type->i_mutex_key#15/2){+.+.}-{3:3}, at: lock_two_directories+0x8f/0x1e0 fs/namei.c:3020 #4: ffff8880728b9140 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:775 [inline] #4: ffff8880728b9140 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: lock_two_nondirectories+0xf0/0x110 fs/inode.c:1121 #5: ffff8880728b9800 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:810 [inline] #5: ffff8880728b9800 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: lock_two_nondirectories+0xd5/0x110 fs/inode.c:1123 #6: ffff88807a3fc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1bb/0x230 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 0 PID: 4992 Comm: syz-executor107 Not tainted 6.4.0-rc7-syzkaller-00226-ga92b7d26c743 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2188 check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain kernel/locking/lockdep.c:3847 [inline] __lock_acquire+0x2fcd/0x5f30 kernel/locking/lockdep.c:5088 lock_acquire kernel/locking/lockdep.c:5705 [inline] lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5670 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1bf/0xf90 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x271/0x1270 fs/hfsplus/catalog.c:456 hfsplus_rename+0x11d/0x210 fs/hfsplus/dir.c:552 vfs_rename+0xef6/0x17a0 fs/namei.c:4849 do_renameat2+0xc04/0xd40 fs/namei.c:5002 __do_sys_renameat2 fs/namei.c:5035 [inline] __se_sys_renameat2 fs/namei.c:5032 [inline] __x64_sys_renameat2+0xe8/0x120 fs/namei.c:5032 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f2c1eae4a19 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffefade96f8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 2f30656c69662f2e RCX: 00007f2c1eae4a19 RDX: 0000000000000007 RSI: 00000000200001c0 RDI: 0000000000000007 RBP: 00007f2c1eaa42b0 R08: 0000000000000000 R09: 0000000000000000 R10: 00000000200002c0 R11: 0000000000000246 R12: 00007f2c1eaa4340 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000