======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.9/5779 is trying to acquire lock:
ffffffff8f1defd8 (tpg_instances_lock){+.+.}-{4:4}, at: tcm_alloc+0x21/0x2f0 drivers/usb/gadget/function/f_tcm.c:2733

but task is already holding lock:
ffff888038ea4388 (&gi->lock){+.+.}-{4:4}, at: config_usb_cfg_link+0x59/0x260 drivers/usb/gadget/configfs.c:439

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&gi->lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       config_usb_cfg_link+0x59/0x260 drivers/usb/gadget/configfs.c:439
       configfs_symlink+0x59a/0x1030 fs/configfs/symlink.c:196
       vfs_symlink+0x18b/0x330 fs/namei.c:5654
       filename_symlinkat+0x1cd/0x420 fs/namei.c:5679
       __do_sys_symlinkat fs/namei.c:5699 [inline]
       __se_sys_symlinkat+0x4e/0x2b0 fs/namei.c:5694
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x17b/0x530 arch/x86/entry/syscall_64.c:85
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&sb->s_type->i_mutex_key#25){++++}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       inode_lock include/linux/fs.h:1024 [inline]
       configfs_depend_item_unlocked+0x153/0x420 fs/configfs/dir.c:1259
       usbg_make_tpg+0x1f6/0x590 drivers/usb/gadget/function/f_tcm.c:1686
       target_fabric_make_tpg+0xa8/0x6d0 drivers/target/target_core_fabric_configfs.c:939
       configfs_mkdir+0x4f6/0x9e0 fs/configfs/dir.c:1360
       vfs_mkdir+0x408/0x620 fs/namei.c:5270
       filename_mkdirat+0x289/0x520 fs/namei.c:5303
       __do_sys_mkdirat fs/namei.c:5324 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5321
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x17b/0x530 arch/x86/entry/syscall_64.c:85
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&opts->dep_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       usbg_make_tpg+0x147/0x590 drivers/usb/gadget/function/f_tcm.c:1678
       target_fabric_make_tpg+0xa8/0x6d0 drivers/target/target_core_fabric_configfs.c:939
       configfs_mkdir+0x4f6/0x9e0 fs/configfs/dir.c:1360
       vfs_mkdir+0x408/0x620 fs/namei.c:5270
       filename_mkdirat+0x289/0x520 fs/namei.c:5303
       __do_sys_mkdirat fs/namei.c:5324 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5321
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x17b/0x530 arch/x86/entry/syscall_64.c:85
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (tpg_instances_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3181 [inline]
       check_prevs_add kernel/locking/lockdep.c:3300 [inline]
       validate_chain kernel/locking/lockdep.c:3924 [inline]
       __lock_acquire+0x15ff/0x2e40 kernel/locking/lockdep.c:5254
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5906
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       tcm_alloc+0x21/0x2f0 drivers/usb/gadget/function/f_tcm.c:2733
       usb_get_function+0x63/0xb0 drivers/usb/gadget/functions.c:61
       config_usb_cfg_link+0x148/0x260 drivers/usb/gadget/configfs.c:469
       configfs_symlink+0x59a/0x1030 fs/configfs/symlink.c:196
       vfs_symlink+0x18b/0x330 fs/namei.c:5654
       filename_symlinkat+0x1cd/0x420 fs/namei.c:5679
       __do_sys_symlinkat fs/namei.c:5699 [inline]
       __se_sys_symlinkat+0x4e/0x2b0 fs/namei.c:5694
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x17b/0x530 arch/x86/entry/syscall_64.c:85
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  tpg_instances_lock --> &sb->s_type->i_mutex_key#25 --> &gi->lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&gi->lock);
                               lock(&sb->s_type->i_mutex_key#25
);
                               lock(&gi->lock
);
  lock(tpg_instances_lock);

 *** DEADLOCK ***

locks held by syz.2.9/5779: 3, last CPU#1:
 #0: 
ffff88801eb56510 (sb_writers#14){.+.+}-{0:0}
, at: mnt_want_write+0x41/0x90 fs/namespace.c:494
 #1: ffff88803dac06e0 (
&sb->s_type->i_mutex_key#25){++++}-{4:4}
, at: inode_lock include/linux/fs.h:1024 [inline]
, at: configfs_symlink+0x3af/0x1030 fs/configfs/symlink.c:186
 #2: 
ffff888038ea4388
 (&gi->lock
){+.+.}-{4:4}
, at: config_usb_cfg_link+0x59/0x260 drivers/usb/gadget/configfs.c:439

stack backtrace:
CPU: 1 UID: 0 PID: 5779 Comm: syz.2.9 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2059
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2191
 check_prev_add kernel/locking/lockdep.c:3181 [inline]
 check_prevs_add kernel/locking/lockdep.c:3300 [inline]
 validate_chain kernel/locking/lockdep.c:3924 [inline]
 __lock_acquire+0x15ff/0x2e40 kernel/locking/lockdep.c:5254
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5906
 __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
 mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
 tcm_alloc+0x21/0x2f0 drivers/usb/gadget/function/f_tcm.c:2733
 usb_get_function+0x63/0xb0 drivers/usb/gadget/functions.c:61
 config_usb_cfg_link+0x148/0x260 drivers/usb/gadget/configfs.c:469
 configfs_symlink+0x59a/0x1030 fs/configfs/symlink.c:196
 vfs_symlink+0x18b/0x330 fs/namei.c:5654
 filename_symlinkat+0x1cd/0x420 fs/namei.c:5679
 __do_sys_symlinkat fs/namei.c:5699 [inline]
 __se_sys_symlinkat+0x4e/0x2b0 fs/namei.c:5694
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x17b/0x530 arch/x86/entry/syscall_64.c:85
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fcdfe1ee019