====================================================== WARNING: possible circular locking dependency detected 6.2.0-next-20230306-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/25462 is trying to acquire lock: ffff88804e3fdae8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x51/0x570 fs/quota/dquot.c:479 but task is already holding lock: ffff88804f1cdcd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x707/0x18d0 fs/ext4/inode.c:644 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ei->i_data_sem/2){++++}-{3:3}: down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x267/0x18d0 fs/ext4/inode.c:574 ext4_getblk+0x16b/0x850 fs/ext4/inode.c:863 ext4_bread+0x2e/0x190 fs/ext4/inode.c:919 ext4_quota_read+0x249/0x330 fs/ext4/super.c:7055 find_tree_dqentry+0x7b/0x7f0 fs/quota/quota_tree.c:624 find_tree_dqentry+0x598/0x7f0 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x362/0x760 fs/quota/quota_tree.c:672 v2_read_dquot+0xd2/0x120 fs/quota/quota_v2.c:333 dquot_acquire+0x1b3/0x6c0 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6736 dqget+0x67d/0x1080 fs/quota/dquot.c:914 __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492 ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0xa707/0xadf0 fs/ext4/super.c:5637 get_tree_bdev+0x444/0x760 fs/super.c:1294 vfs_get_tree+0x8d/0x350 fs/super.c:1501 do_new_mount fs/namespace.c:3042 [inline] path_mount+0x1342/0x1e40 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __x64_sys_mount+0x283/0x300 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4d/0x120 fs/quota/quota_v2.c:332 dquot_acquire+0x1b3/0x6c0 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6736 dqget+0x67d/0x1080 fs/quota/dquot.c:914 __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492 ext4_create+0x94/0x4e0 fs/ext4/namei.c:2802 lookup_open.isra.0+0x105a/0x1400 fs/namei.c:3416 open_last_lookups fs/namei.c:3484 [inline] path_openat+0x975/0x2750 fs/namei.c:3712 do_filp_open+0x1ba/0x410 fs/namei.c:3742 do_sys_openat2+0x16d/0x4c0 fs/open.c:1348 do_sys_open fs/open.c:1364 [inline] __do_sys_openat fs/open.c:1380 [inline] __se_sys_openat fs/open.c:1375 [inline] __x64_sys_openat+0x143/0x1f0 fs/open.c:1375 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&dquot->dq_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 dquot_commit+0x51/0x570 fs/quota/dquot.c:479 ext4_write_dquot+0x25f/0x330 fs/ext4/super.c:6720 ext4_mark_dquot_dirty fs/ext4/super.c:6768 [inline] ext4_mark_dquot_dirty+0x115/0x1b0 fs/ext4/super.c:6762 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0x5f9/0xb80 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x60f/0x51f0 fs/ext4/mballoc.c:5571 ext4_ext_map_blocks+0x233d/0x6310 fs/ext4/extents.c:4286 ext4_map_blocks+0x779/0x18d0 fs/ext4/inode.c:651 ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863 ext4_bread+0x2e/0x190 fs/ext4/inode.c:919 ext4_append+0x23b/0x540 fs/ext4/namei.c:83 ext4_init_new_dir+0x262/0x4c0 fs/ext4/namei.c:2956 ext4_mkdir+0x3d3/0xb20 fs/ext4/namei.c:3002 vfs_mkdir+0x242/0x460 fs/namei.c:4038 do_mkdirat+0x28d/0x310 fs/namei.c:4061 __do_sys_mkdir fs/namei.c:4081 [inline] __se_sys_mkdir fs/namei.c:4079 [inline] __x64_sys_mkdir+0xf6/0x140 fs/namei.c:4079 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&dquot->dq_lock); *** DEADLOCK *** 4 locks held by syz-executor.3/25462: #0: ffff88801cf78460 (sb_writers#4){.+.+}-{0:0}, at: filename_create+0xf1/0x4a0 fs/namei.c:3801 #1: ffff888049cbd440 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff888049cbd440 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: filename_create+0x1aa/0x4a0 fs/namei.c:3808 #2: ffff88804f1cdcd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x707/0x18d0 fs/ext4/inode.c:644 #3: ffffffff8c991388 (dquot_srcu){....}-{0:0}, at: i_dquot fs/quota/dquot.c:939 [inline] #3: ffffffff8c991388 (dquot_srcu){....}-{0:0}, at: __dquot_alloc_space+0x1b8/0xb80 fs/quota/dquot.c:1684 stack backtrace: CPU: 1 PID: 25462 Comm: syz-executor.3 Not tainted 6.2.0-next-20230306-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire.part.0+0x11a/0x370 kernel/locking/lockdep.c:5669 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 dquot_commit+0x51/0x570 fs/quota/dquot.c:479 ext4_write_dquot+0x25f/0x330 fs/ext4/super.c:6720 ext4_mark_dquot_dirty fs/ext4/super.c:6768 [inline] ext4_mark_dquot_dirty+0x115/0x1b0 fs/ext4/super.c:6762 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0x5f9/0xb80 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x60f/0x51f0 fs/ext4/mballoc.c:5571 ext4_ext_map_blocks+0x233d/0x6310 fs/ext4/extents.c:4286 ext4_map_blocks+0x779/0x18d0 fs/ext4/inode.c:651 ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863 ext4_bread+0x2e/0x190 fs/ext4/inode.c:919 ext4_append+0x23b/0x540 fs/ext4/namei.c:83 ext4_init_new_dir+0x262/0x4c0 fs/ext4/namei.c:2956 ext4_mkdir+0x3d3/0xb20 fs/ext4/namei.c:3002 vfs_mkdir+0x242/0x460 fs/namei.c:4038 do_mkdirat+0x28d/0x310 fs/namei.c:4061 __do_sys_mkdir fs/namei.c:4081 [inline] __se_sys_mkdir fs/namei.c:4079 [inline] __x64_sys_mkdir+0xf6/0x140 fs/namei.c:4079 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f86b8e8c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f86b9bc9168 EFLAGS: 00000246 ORIG_RAX: 0000000000000053 RAX: ffffffffffffffda RBX: 00007f86b8fabf80 RCX: 00007f86b8e8c0f9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000300 RBP: 00007f86b8ee7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcee003c5f R14: 00007f86b9bc9300 R15: 0000000000022000