====================================================== WARNING: possible circular locking dependency detected 6.7.0-syzkaller-11889-g86c4d58a99ab #0 Not tainted ------------------------------------------------------ syz-executor.0/14927 is trying to acquire lock: ffff88802580b8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff888054c72988 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x422/0xe10 fs/buffer.c:2382 filemap_read_folio+0x19c/0x780 mm/filemap.c:2324 do_read_cache_folio+0x134/0x810 mm/filemap.c:3701 do_read_cache_page+0x30/0x200 mm/filemap.c:3767 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50b/0x1a70 fs/buffer.c:2103 __block_write_begin fs/buffer.c:2152 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2211 cont_write_begin+0x643/0x880 fs/buffer.c:2565 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 page_symlink+0x2c5/0x4e0 fs/namei.c:5228 hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x12f/0x2a0 fs/namei.c:4480 do_symlinkat+0x222/0x3a0 fs/namei.c:4506 __do_sys_symlink fs/namei.c:4527 [inline] __se_sys_symlink fs/namei.c:4525 [inline] __x64_sys_symlink+0x7e/0x90 fs/namei.c:4525 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50b/0x1a70 fs/buffer.c:2103 __block_write_begin fs/buffer.c:2152 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2211 cont_write_begin+0x643/0x880 fs/buffer.c:2565 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 generic_perform_write+0x31b/0x630 mm/filemap.c:3928 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4049 call_write_iter include/linux/fs.h:2085 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x783/0xaf0 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 4 locks held by syz-executor.0/14927: #0: ffff888059665748 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x258/0x320 fs/file.c:1191 #1: ffff888059870420 (sb_writers#21){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2795 [inline] #1: ffff888059870420 (sb_writers#21){.+.+}-{0:0}, at: vfs_write+0x224/0xaf0 fs/read_write.c:586 #2: ffff888054c72b80 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #2: ffff888054c72b80 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: generic_file_write_iter+0x83/0x310 mm/filemap.c:4046 #3: ffff888054c72988 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 14927 Comm: syz-executor.0 Not tainted 6.7.0-syzkaller-11889-g86c4d58a99ab #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50b/0x1a70 fs/buffer.c:2103 __block_write_begin fs/buffer.c:2152 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2211 cont_write_begin+0x643/0x880 fs/buffer.c:2565 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 generic_perform_write+0x31b/0x630 mm/filemap.c:3928 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4049 call_write_iter include/linux/fs.h:2085 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x783/0xaf0 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f09fd67cda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f09fe4410c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f09fd7abf80 RCX: 00007f09fd67cda9 RDX: 000000000000fdef RSI: 0000000020004200 RDI: 0000000000000004 RBP: 00007f09fd6c947a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f09fd7abf80 R15: 00007ffe25845248