====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/1684 is trying to acquire lock: 00000000abb6c801 (&dquot->dq_lock){+.+.}, at: dquot_commit+0x4d/0x400 fs/quota/dquot.c:469 but task is already holding lock: 0000000019f80dac (&ei->i_data_sem/2){++++}, at: ext4_truncate+0x746/0x1380 fs/ext4/inode.c:4552 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ei->i_data_sem/2){++++}: ext4_map_blocks+0x33e/0x1a50 fs/ext4/inode.c:578 ext4_getblk+0xad/0x4f0 fs/ext4/inode.c:993 ext4_bread+0x7c/0x210 fs/ext4/inode.c:1043 ext4_quota_write+0x205/0x530 fs/ext4/super.c:6008 write_blk+0x10a/0x200 fs/quota/quota_tree.c:72 get_free_dqblk+0xff/0x2d0 fs/quota/quota_tree.c:101 do_insert_tree+0x79c/0x1150 fs/quota/quota_tree.c:308 do_insert_tree+0xf5c/0x1150 fs/quota/quota_tree.c:339 do_insert_tree+0x85b/0x1150 fs/quota/quota_tree.c:339 dq_insert_tree fs/quota/quota_tree.c:365 [inline] qtree_write_dquot+0x1cb/0x570 fs/quota/quota_tree.c:384 v2_write_dquot+0x11c/0x250 fs/quota/quota_v2.c:359 dquot_acquire+0x25c/0x490 fs/quota/dquot.c:436 ext4_acquire_dquot+0x1e7/0x2d0 fs/ext4/super.c:5666 dqget+0x785/0xfc0 fs/quota/dquot.c:896 __dquot_initialize+0x3bd/0xb70 fs/quota/dquot.c:1470 ext4_orphan_cleanup fs/ext4/super.c:2681 [inline] ext4_fill_super+0x8202/0xc850 fs/ext4/super.c:4549 mount_bdev+0x2fc/0x3b0 fs/super.c:1158 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount fs/namespace.c:951 [inline] do_new_mount fs/namespace.c:2492 [inline] do_mount+0x115c/0x2f50 fs/namespace.c:2822 ksys_mount+0xcf/0x130 fs/namespace.c:3038 __do_sys_mount fs/namespace.c:3052 [inline] __se_sys_mount fs/namespace.c:3049 [inline] __x64_sys_mount+0xba/0x150 fs/namespace.c:3049 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #1 (&s->s_dquot.dqio_sem){++++}: v2_read_dquot+0x49/0x120 fs/quota/quota_v2.c:333 dquot_acquire+0x121/0x490 fs/quota/dquot.c:428 ext4_acquire_dquot+0x1e7/0x2d0 fs/ext4/super.c:5666 dqget+0x785/0xfc0 fs/quota/dquot.c:896 __dquot_initialize+0x3bd/0xb70 fs/quota/dquot.c:1470 ext4_xattr_set+0xbd/0x2a0 fs/ext4/xattr.c:2499 __vfs_setxattr+0x10e/0x170 fs/xattr.c:149 __vfs_setxattr_noperm+0x11a/0x420 fs/xattr.c:180 __vfs_setxattr_locked+0x176/0x250 fs/xattr.c:238 vfs_setxattr+0xe5/0x270 fs/xattr.c:255 setxattr+0x23d/0x330 fs/xattr.c:520 path_setxattr+0x170/0x190 fs/xattr.c:539 __do_sys_setxattr fs/xattr.c:554 [inline] __se_sys_setxattr fs/xattr.c:550 [inline] __x64_sys_setxattr+0xc0/0x160 fs/xattr.c:550 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&dquot->dq_lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 dquot_commit+0x4d/0x400 fs/quota/dquot.c:469 ext4_write_dquot+0x1e7/0x280 fs/ext4/super.c:5650 ext4_mark_dquot_dirty+0x111/0x1a0 fs/ext4/super.c:5701 mark_dquot_dirty fs/quota/dquot.c:341 [inline] mark_all_dquot_dirty fs/quota/dquot.c:379 [inline] __dquot_free_space+0x5d4/0x9c0 fs/quota/dquot.c:1887 dquot_free_space_nodirty include/linux/quotaops.h:377 [inline] dquot_free_space include/linux/quotaops.h:382 [inline] dquot_free_block include/linux/quotaops.h:393 [inline] ext4_free_blocks+0x1922/0x2ac0 fs/ext4/mballoc.c:4950 ext4_remove_blocks fs/ext4/extents.c:2584 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2740 [inline] ext4_ext_remove_space+0x26ef/0x3e80 fs/ext4/extents.c:2973 ext4_ext_truncate+0x1ae/0x200 fs/ext4/extents.c:4670 ext4_truncate+0xe27/0x1380 fs/ext4/inode.c:4557 ext4_evict_inode+0x934/0x17b0 fs/ext4/inode.c:305 evict+0x2ed/0x760 fs/inode.c:559 iput_final fs/inode.c:1555 [inline] iput+0x4f1/0x860 fs/inode.c:1581 do_unlinkat+0x40b/0x660 fs/namei.c:4071 __do_sys_unlinkat fs/namei.c:4107 [inline] __se_sys_unlinkat fs/namei.c:4099 [inline] __x64_sys_unlinkat+0xbd/0x120 fs/namei.c:4099 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&dquot->dq_lock); *** DEADLOCK *** 4 locks held by syz-executor.2/1684: #0: 000000009b5083fa (sb_writers#3){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 000000009b5083fa (sb_writers#3){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 #1: 0000000064830998 (sb_internal){.+.+}, at: sb_start_intwrite include/linux/fs.h:1626 [inline] #1: 0000000064830998 (sb_internal){.+.+}, at: ext4_evict_inode+0x1311/0x17b0 fs/ext4/inode.c:259 #2: 0000000019f80dac (&ei->i_data_sem/2){++++}, at: ext4_truncate+0x746/0x1380 fs/ext4/inode.c:4552 #3: 00000000303b966b (dquot_srcu){....}, at: i_dquot fs/quota/dquot.c:921 [inline] #3: 00000000303b966b (dquot_srcu){....}, at: __dquot_free_space+0x19b/0x9c0 fs/quota/dquot.c:1860 stack backtrace: CPU: 1 PID: 1684 Comm: syz-executor.2 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 dquot_commit+0x4d/0x400 fs/quota/dquot.c:469 ext4_write_dquot+0x1e7/0x280 fs/ext4/super.c:5650 ext4_mark_dquot_dirty+0x111/0x1a0 fs/ext4/super.c:5701 mark_dquot_dirty fs/quota/dquot.c:341 [inline] mark_all_dquot_dirty fs/quota/dquot.c:379 [inline] __dquot_free_space+0x5d4/0x9c0 fs/quota/dquot.c:1887 dquot_free_space_nodirty include/linux/quotaops.h:377 [inline] dquot_free_space include/linux/quotaops.h:382 [inline] dquot_free_block include/linux/quotaops.h:393 [inline] ext4_free_blocks+0x1922/0x2ac0 fs/ext4/mballoc.c:4950 ext4_remove_blocks fs/ext4/extents.c:2584 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2740 [inline] ext4_ext_remove_space+0x26ef/0x3e80 fs/ext4/extents.c:2973 ext4_ext_truncate+0x1ae/0x200 fs/ext4/extents.c:4670 ext4_truncate+0xe27/0x1380 fs/ext4/inode.c:4557 ext4_evict_inode+0x934/0x17b0 fs/ext4/inode.c:305 evict+0x2ed/0x760 fs/inode.c:559 iput_final fs/inode.c:1555 [inline] iput+0x4f1/0x860 fs/inode.c:1581 do_unlinkat+0x40b/0x660 fs/namei.c:4071 __do_sys_unlinkat fs/namei.c:4107 [inline] __se_sys_unlinkat fs/namei.c:4099 [inline] __x64_sys_unlinkat+0xbd/0x120 fs/namei.c:4099 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f3d115d50f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3d0fb47168 EFLAGS: 00000246 ORIG_RAX: 0000000000000107 RAX: ffffffffffffffda RBX: 00007f3d116f4f80 RCX: 00007f3d115d50f9 RDX: 0000000000000000 RSI: 0000000020000200 RDI: 0000000000000005 RBP: 00007f3d11630ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fffb0a6fbef R14: 00007f3d0fb47300 R15: 0000000000022000 EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue EXT4-fs (loop2): Quota format mount options ignored when QUOTA feature is enabled EXT4-fs (loop2): mounted filesystem without journal. Opts: quota,jqfmt=vfsv0,nouid32,,errors=continue