====================================================== WARNING: possible circular locking dependency detected 6.1.44-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/15228 is trying to acquire lock: ffff00010d8dbc00 (&ni->ni_lock){+.+.}-{3:3}, at: ntfs_set_state+0x1a4/0x5c4 fs/ntfs3/fsntfs.c:920 but task is already holding lock: ffff00010d8f4ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1109 [inline] ffff00010d8f4ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_unlink_inode+0x270/0x65c fs/ntfs3/inode.c:1724 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock/4){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1109 [inline] mi_read+0x278/0x488 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x360/0x2bd4 fs/ntfs3/inode.c:524 ni_update_parent+0x688/0xa58 fs/ntfs3/frecord.c:3196 ni_write_inode+0xc4c/0xfb8 fs/ntfs3/frecord.c:3291 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1030 write_inode fs/fs-writeback.c:1443 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1655 writeback_sb_inodes+0x978/0x16c0 fs/fs-writeback.c:1881 __writeback_inodes_wb+0x110/0x39c fs/fs-writeback.c:1952 wb_writeback+0x428/0x1130 fs/fs-writeback.c:2057 wb_check_start_all fs/fs-writeback.c:2179 [inline] wb_do_writeback fs/fs-writeback.c:2205 [inline] wb_workfn+0xa20/0x1034 fs/fs-writeback.c:2238 process_one_work+0x7ac/0x1404 kernel/workqueue.c:2292 worker_thread+0x8e4/0xfec kernel/workqueue.c:2439 kthread+0x250/0x2d8 kernel/kthread.c:376 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860 -> #0 (&ni->ni_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x5c4 fs/ntfs3/fsntfs.c:920 ni_remove_name+0x230/0x7a4 fs/ntfs3/frecord.c:2921 ntfs_unlink_inode+0x318/0x65c fs/ntfs3/inode.c:1736 ntfs_rename+0x384/0xaf8 fs/ntfs3/namei.c:286 vfs_rename+0x8b8/0xd04 fs/namei.c:4785 do_renameat2+0x980/0x1040 fs/namei.c:4935 __do_sys_renameat2 fs/namei.c:4968 [inline] __se_sys_renameat2 fs/namei.c:4965 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4965 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); *** DEADLOCK *** 8 locks held by syz-executor.2/15228: #0: ffff0000d2fea460 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000d2fea748 (&type->s_vfs_rename_key#5){+.+.}-{3:3}, at: lock_rename+0x54/0x198 fs/namei.c:2994 #2: ffff00010d8df9a0 (&type->i_mutex_dir_key#11/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #2: ffff00010d8df9a0 (&type->i_mutex_dir_key#11/1){+.+.}-{3:3}, at: lock_rename+0x124/0x198 fs/namei.c:3005 #3: ffff00010d8dcd60 (&type->i_mutex_dir_key#11/2){+.+.}-{3:3}, at: lock_rename+0x14c/0x198 #4: ffff00010d8dafe0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #4: ffff00010d8dafe0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: lock_two_inodes+0xdc/0x158 fs/inode.c:1143 #5: ffff00010d8f4d60 (&sb->s_type->i_mutex_key#21/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #5: ffff00010d8f4d60 (&sb->s_type->i_mutex_key#21/4){+.+.}-{3:3}, at: lock_two_inodes+0xf8/0x158 fs/inode.c:1145 #6: ffff00010d8df700 (&ni->ni_lock/5){+.+.}-{3:3}, at: ni_lock_dir fs/ntfs3/ntfs_fs.h:1114 [inline] #6: ffff00010d8df700 (&ni->ni_lock/5){+.+.}-{3:3}, at: ntfs_rename+0x378/0xaf8 fs/ntfs3/namei.c:285 #7: ffff00010d8f4ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1109 [inline] #7: ffff00010d8f4ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_unlink_inode+0x270/0x65c fs/ntfs3/inode.c:1724 stack backtrace: CPU: 0 PID: 15228 Comm: syz-executor.2 Not tainted 6.1.44-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x5c4 fs/ntfs3/fsntfs.c:920 ni_remove_name+0x230/0x7a4 fs/ntfs3/frecord.c:2921 ntfs_unlink_inode+0x318/0x65c fs/ntfs3/inode.c:1736 ntfs_rename+0x384/0xaf8 fs/ntfs3/namei.c:286 vfs_rename+0x8b8/0xd04 fs/namei.c:4785 do_renameat2+0x980/0x1040 fs/namei.c:4935 __do_sys_renameat2 fs/namei.c:4968 [inline] __se_sys_renameat2 fs/namei.c:4965 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4965 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581