====================================================== WARNING: possible circular locking dependency detected 6.16.0-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.5823/21318 is trying to acquire lock: ffff888079cd48f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0xe5/0xa40 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff888058b1a2c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1ca/0x10f0 fs/hfsplus/extents.c:458 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x199/0xb90 kernel/locking/mutex.c:747 hfsplus_get_block+0x272/0x9d0 fs/hfsplus/extents.c:260 block_read_full_folio+0x457/0x850 fs/buffer.c:2427 filemap_read_folio+0xc8/0x2a0 mm/filemap.c:2412 do_read_cache_folio+0x263/0x5c0 mm/filemap.c:3894 do_read_cache_page mm/filemap.c:3960 [inline] read_cache_page+0x5b/0x160 mm/filemap.c:3969 read_mapping_page include/linux/pagemap.h:966 [inline] hfsplus_block_allocate+0x144/0xa40 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x459/0x10f0 fs/hfsplus/extents.c:469 hfsplus_get_block+0x1a9/0x9d0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x4f4/0x16d0 fs/buffer.c:2151 block_write_begin+0x9a/0x1d0 fs/buffer.c:2262 cont_write_begin+0x61b/0x950 fs/buffer.c:2601 hfsplus_write_begin+0x64/0x120 fs/hfsplus/inode.c:46 page_symlink+0x3fc/0x4c0 fs/namei.c:5520 hfsplus_symlink+0xd3/0x2b0 fs/hfsplus/dir.c:449 vfs_symlink fs/namei.c:4739 [inline] vfs_symlink+0x403/0x680 fs/namei.c:4723 do_symlinkat+0x261/0x310 fs/namei.c:4765 __do_sys_symlink fs/namei.c:4786 [inline] __se_sys_symlink fs/namei.c:4784 [inline] __x64_sys_symlink+0x75/0x90 fs/namei.c:4784 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240 lock_acquire kernel/locking/lockdep.c:5871 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x199/0xb90 kernel/locking/mutex.c:747 hfsplus_block_allocate+0xe5/0xa40 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x459/0x10f0 fs/hfsplus/extents.c:469 hfsplus_bmap_reserve+0x31f/0x420 fs/hfsplus/btree.c:358 hfsplus_delete_attr+0x1ac/0x300 fs/hfsplus/attributes.c:326 hfsplus_removexattr fs/hfsplus/xattr.c:792 [inline] __hfsplus_setxattr+0x88a/0x2210 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0x10c/0x180 fs/hfsplus/xattr.c:432 __vfs_removexattr+0x155/0x1c0 fs/xattr.c:518 __vfs_removexattr_locked+0x166/0x480 fs/xattr.c:553 vfs_removexattr+0xd1/0x270 fs/xattr.c:575 removexattr fs/xattr.c:1023 [inline] filename_removexattr fs/xattr.c:1052 [inline] path_removexattrat+0x38e/0x5e0 fs/xattr.c:1088 __do_sys_removexattr fs/xattr.c:1100 [inline] __se_sys_removexattr fs/xattr.c:1097 [inline] __x64_sys_removexattr+0x5b/0x80 fs/xattr.c:1097 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 5 locks held by syz.1.5823/21318: #0: ffff88807b99a428 (sb_writers#30){.+.+}-{0:0}, at: filename_removexattr fs/xattr.c:1050 [inline] #0: ffff88807b99a428 (sb_writers#30){.+.+}-{0:0}, at: path_removexattrat+0x20d/0x5e0 fs/xattr.c:1088 #1: ffff88807775bfb8 (&type->i_mutex_dir_key#21){++++}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #1: ffff88807775bfb8 (&type->i_mutex_dir_key#21){++++}-{4:4}, at: vfs_removexattr+0xbd/0x270 fs/xattr.c:574 #2: ffff8880538d60b0 (&tree->tree_lock#2){+.+.}-{4:4}, at: hfsplus_find_init+0x17b/0x1f0 fs/hfsplus/bfind.c:28 #3: ffff8880538d20b0 (&tree->tree_lock#2/2){+.+.}-{4:4}, at: hfsplus_find_init+0x17b/0x1f0 fs/hfsplus/bfind.c:28 #4: ffff888058b1a2c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1ca/0x10f0 fs/hfsplus/extents.c:458 stack backtrace: CPU: 1 UID: 0 PID: 21318 Comm: syz.1.5823 Not tainted 6.16.0-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2046 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240 lock_acquire kernel/locking/lockdep.c:5871 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x199/0xb90 kernel/locking/mutex.c:747 hfsplus_block_allocate+0xe5/0xa40 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x459/0x10f0 fs/hfsplus/extents.c:469 hfsplus_bmap_reserve+0x31f/0x420 fs/hfsplus/btree.c:358 hfsplus_delete_attr+0x1ac/0x300 fs/hfsplus/attributes.c:326 hfsplus_removexattr fs/hfsplus/xattr.c:792 [inline] __hfsplus_setxattr+0x88a/0x2210 fs/hfsplus/xattr.c:275 hfsplus_setxattr+0x10c/0x180 fs/hfsplus/xattr.c:432 __vfs_removexattr+0x155/0x1c0 fs/xattr.c:518 __vfs_removexattr_locked+0x166/0x480 fs/xattr.c:553 vfs_removexattr+0xd1/0x270 fs/xattr.c:575 removexattr fs/xattr.c:1023 [inline] filename_removexattr fs/xattr.c:1052 [inline] path_removexattrat+0x38e/0x5e0 fs/xattr.c:1088 __do_sys_removexattr fs/xattr.c:1100 [inline] __se_sys_removexattr fs/xattr.c:1097 [inline] __x64_sys_removexattr+0x5b/0x80 fs/xattr.c:1097 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fcf7e98e9a9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fcf7f713038 EFLAGS: 00000246 ORIG_RAX: 00000000000000c5 RAX: ffffffffffffffda RBX: 00007fcf7ebb5fa0 RCX: 00007fcf7e98e9a9 RDX: 0000000000000000 RSI: 0000200000000140 RDI: 0000200000000040 RBP: 00007fcf7ea10d69 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fcf7ebb5fa0 R15: 00007ffdc44db3e8