====================================================== WARNING: possible circular locking dependency detected 6.1.111-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.244/5483 is trying to acquire lock: ffff888066e648c0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 but task is already holding lock: ffff88805b9bc208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6796 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3057 vfs_mkdir+0x3b6/0x590 fs/namei.c:4108 do_mkdirat+0x225/0x360 fs/namei.c:4133 __do_sys_mkdirat fs/namei.c:4148 [inline] __se_sys_mkdirat fs/namei.c:4146 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4146 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6776 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1940 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6145 [inline] ext4_free_blocks+0x1fb8/0x3020 fs/ext4/mballoc.c:6275 ext4_remove_blocks fs/ext4/extents.c:2503 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2687 [inline] ext4_ext_remove_space+0x25e8/0x4f30 fs/ext4/extents.c:2935 ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4448 ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288 ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286 evict+0x529/0x930 fs/inode.c:701 do_unlinkat+0x509/0x820 fs/namei.c:4399 __do_sys_unlink fs/namei.c:4440 [inline] __se_sys_unlink fs/namei.c:4438 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4438 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7170 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6796 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_create+0xb1/0x550 fs/ext4/namei.c:2874 lookup_open fs/namei.c:3484 [inline] open_last_lookups fs/namei.c:3552 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3782 do_filp_open+0x230/0x480 fs/namei.c:3812 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 4 locks held by syz.3.244/5483: #0: ffff88805b9bc460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff888066e63628 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff888066e63628 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: open_last_lookups fs/namei.c:3549 [inline] #1: ffff888066e63628 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: path_openat+0x7b6/0x2e60 fs/namei.c:3782 #2: ffff88805786e7a8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #3: ffff88805b9bc208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 stack backtrace: CPU: 1 PID: 5483 Comm: syz.3.244 Not tainted 6.1.111-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7170 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6796 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_create+0xb1/0x550 fs/ext4/namei.c:2874 lookup_open fs/namei.c:3484 [inline] open_last_lookups fs/namei.c:3552 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3782 do_filp_open+0x230/0x480 fs/namei.c:3812 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f347bd7def9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f347caaa038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 00007f347bf35f80 RCX: 00007f347bd7def9 RDX: 00000000000026e1 RSI: 0000000020000100 RDI: ffffffffffffff9c RBP: 00007f347bdf0b76 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f347bf35f80 R15: 00007ffdf7f9fc28 EXT4-fs error (device loop3): ext4_validate_block_bitmap:438: comm syz.3.244: bg 0: block 65: padding at end of block bitmap is not set __quota_error: 14 callbacks suppressed Quota error (device loop3): write_blk: dquota write failed Quota error (device loop3): qtree_write_dquot: Error -117 occurred while creating quota EXT4-fs error (device loop3): ext4_acquire_dquot:6800: comm syz.3.244: Failed to acquire dquot type 0