====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc4-syzkaller-00016-g5e62ed3b1c8a #0 Not tainted ------------------------------------------------------ syz-executor.1/9915 is trying to acquire lock: ffff88802c4c40e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock fs/super.c:58 [inline] ffff88802c4c40e0 (&type->s_umount_key#31){++++}-{3:3}, at: super_lock+0x23c/0x380 fs/super.c:117 but task is already holding lock: ffff888104520348 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] ffff888104520348 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x14e9/0x1ce0 block/ioctl.c:502 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&bdev->bd_holder_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 bd_finish_claiming block/bdev.c:566 [inline] blkdev_get_by_dev.part.0+0x374/0xb20 block/bdev.c:799 blkdev_get_by_dev+0x75/0x80 block/bdev.c:829 setup_bdev_super+0x78/0x6f0 fs/super.c:1484 mount_bdev+0x1c0/0x2e0 fs/super.c:1626 legacy_get_tree+0x109/0x220 fs/fs_context.c:638 vfs_get_tree+0x8c/0x370 fs/super.c:1750 do_new_mount fs/namespace.c:3335 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3662 init_mount+0xbf/0x110 fs/init.c:25 do_mount_root+0xdd/0x2c0 init/do_mounts.c:166 mount_root_generic+0x19a/0x460 init/do_mounts.c:205 mount_block_root init/do_mounts.c:378 [inline] mount_root+0x241/0x480 init/do_mounts.c:405 prepare_namespace+0xe3/0x3f0 init/do_mounts.c:489 kernel_init_freeable+0x703/0x900 init/main.c:1560 kernel_init+0x1c/0x2a0 init/main.c:1437 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #3 (bdev_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 bd_prepare_to_claim+0x1a4/0x280 block/bdev.c:508 truncate_bdev_range+0x48/0x270 block/bdev.c:105 blkdev_fallocate+0x201/0x3e0 block/fops.c:776 vfs_fallocate+0x46c/0xe80 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xd5/0x140 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (mapping.invalidate_lock#2){++++}-{3:3}: down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] page_cache_ra_unbounded+0x13a/0x5e0 mm/readahead.c:225 do_page_cache_ra mm/readahead.c:299 [inline] page_cache_ra_order+0x72b/0xa80 mm/readahead.c:546 ondemand_readahead+0x493/0x1130 mm/readahead.c:668 page_cache_sync_ra+0x174/0x1d0 mm/readahead.c:695 page_cache_sync_readahead.constprop.0+0xb3/0xf0 include/linux/pagemap.h:1293 ext4_readdir+0x88c/0x3720 fs/ext4/dir.c:194 iterate_dir+0x1e5/0x5f0 fs/readdir.c:106 ovl_dir_read fs/overlayfs/readdir.c:309 [inline] ovl_check_d_type_supported+0x11f/0x220 fs/overlayfs/readdir.c:1065 ovl_make_workdir fs/overlayfs/super.c:735 [inline] ovl_get_workdir fs/overlayfs/super.c:876 [inline] ovl_fill_super+0xe6b/0x6360 fs/overlayfs/super.c:1412 vfs_get_super fs/super.c:1335 [inline] get_tree_nodev+0xd6/0x180 fs/super.c:1354 vfs_get_tree+0x8c/0x370 fs/super.c:1750 do_new_mount fs/namespace.c:3335 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3662 do_mount fs/namespace.c:3675 [inline] __do_sys_mount fs/namespace.c:3884 [inline] __se_sys_mount fs/namespace.c:3861 [inline] __x64_sys_mount+0x293/0x310 fs/namespace.c:3861 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&type->i_mutex_dir_key#3){++++}-{3:3}: down_write+0x93/0x200 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:802 [inline] ext4_process_orphan+0x105/0x410 fs/ext4/orphan.c:337 ext4_orphan_cleanup+0x70f/0x11d0 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5582 [inline] ext4_fill_super+0x966c/0xad30 fs/ext4/super.c:5703 get_tree_bdev+0x3b5/0x650 fs/super.c:1577 vfs_get_tree+0x8c/0x370 fs/super.c:1750 do_new_mount fs/namespace.c:3335 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3662 do_mount fs/namespace.c:3675 [inline] __do_sys_mount fs/namespace.c:3884 [inline] __se_sys_mount fs/namespace.c:3861 [inline] __x64_sys_mount+0x293/0x310 fs/namespace.c:3861 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&type->s_umount_key#31){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x23c/0x380 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0x94/0x1b0 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x1550/0x1ce0 block/ioctl.c:502 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &type->s_umount_key#31 --> bdev_lock --> &bdev->bd_holder_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&bdev->bd_holder_lock); lock(bdev_lock); lock(&bdev->bd_holder_lock); rlock(&type->s_umount_key#31); *** DEADLOCK *** 1 lock held by syz-executor.1/9915: #0: ffff888104520348 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] #0: ffff888104520348 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x14e9/0x1ce0 block/ioctl.c:502 stack backtrace: CPU: 1 PID: 9915 Comm: syz-executor.1 Not tainted 6.6.0-rc4-syzkaller-00016-g5e62ed3b1c8a #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x23c/0x380 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0x94/0x1b0 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x1550/0x1ce0 block/ioctl.c:502 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f244627cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f244705e0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f244639bf80 RCX: 00007f244627cae9 RDX: 0000000000000000 RSI: 0000000000001261 RDI: 0000000000000003 RBP: 00007f24462c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f244639bf80 R15: 00007fff7f0bd5a8