====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc5-syzkaller-00199-g5af6ce704936 #0 Not tainted ------------------------------------------------------ syz-executor.1/24265 is trying to acquire lock: ffff88823bd300b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x167/0x1e0 but task is already holding lock: ffff88801dc5b4f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_get_block+0x27e/0xbb0 fs/hfs/extent.c:365 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 hfs_extend_file+0xde/0x1420 fs/hfs/extent.c:397 hfs_bmap_reserve+0xfa/0x410 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x1ea/0x460 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x67/0x980 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x323/0x1420 fs/hfs/extent.c:401 hfs_get_block+0x3fc/0xbb0 fs/hfs/extent.c:353 __block_write_begin_int+0x54c/0x1a80 fs/buffer.c:1991 __block_write_begin fs/buffer.c:2041 [inline] block_write_begin+0x93/0x1e0 fs/buffer.c:2102 cont_write_begin+0x606/0x860 fs/buffer.c:2456 hfs_write_begin+0x86/0xd0 fs/hfs/inode.c:58 cont_expand_zero fs/buffer.c:2383 [inline] cont_write_begin+0x2cf/0x860 fs/buffer.c:2446 hfs_write_begin+0x86/0xd0 fs/hfs/inode.c:58 generic_perform_write+0x2e4/0x5e0 mm/filemap.c:3772 __generic_file_write_iter+0x176/0x400 mm/filemap.c:3900 generic_file_write_iter+0xab/0x310 mm/filemap.c:3932 call_write_iter include/linux/fs.h:2189 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x7dc/0xc50 fs/read_write.c:584 ksys_write+0x177/0x2a0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&tree->tree_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 hfs_find_init+0x167/0x1e0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_get_block+0x519/0xbb0 fs/hfs/extent.c:366 block_read_full_folio+0x3b3/0xfa0 fs/buffer.c:2271 filemap_read_folio+0x187/0x7d0 mm/filemap.c:2426 do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3553 do_read_cache_page mm/filemap.c:3595 [inline] read_cache_page+0x56/0x270 mm/filemap.c:3604 read_mapping_page include/linux/pagemap.h:755 [inline] hfs_btree_open+0x50c/0xf20 fs/hfs/btree.c:78 hfs_mdb_get+0x148f/0x21a0 fs/hfs/mdb.c:204 hfs_fill_super+0xfc7/0x1690 fs/hfs/super.c:406 mount_bdev+0x26c/0x3a0 fs/super.c:1359 legacy_get_tree+0xea/0x180 fs/fs_context.c:610 vfs_get_tree+0x88/0x270 fs/super.c:1489 do_new_mount+0x289/0xad0 fs/namespace.c:3145 do_mount fs/namespace.c:3488 [inline] __do_sys_mount fs/namespace.c:3697 [inline] __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3674 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); *** DEADLOCK *** 2 locks held by syz-executor.1/24265: #0: ffff888030f220e0 (&type->s_umount_key#68/1){+.+.}-{3:3}, at: alloc_super+0x212/0x920 fs/super.c:228 #1: ffff88801dc5b4f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_get_block+0x27e/0xbb0 fs/hfs/extent.c:365 stack backtrace: CPU: 0 PID: 24265 Comm: syz-executor.1 Not tainted 6.2.0-rc5-syzkaller-00199-g5af6ce704936 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x290 lib/dump_stack.c:106 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 hfs_find_init+0x167/0x1e0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_get_block+0x519/0xbb0 fs/hfs/extent.c:366 block_read_full_folio+0x3b3/0xfa0 fs/buffer.c:2271 filemap_read_folio+0x187/0x7d0 mm/filemap.c:2426 do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3553 do_read_cache_page mm/filemap.c:3595 [inline] read_cache_page+0x56/0x270 mm/filemap.c:3604 read_mapping_page include/linux/pagemap.h:755 [inline] hfs_btree_open+0x50c/0xf20 fs/hfs/btree.c:78 hfs_mdb_get+0x148f/0x21a0 fs/hfs/mdb.c:204 hfs_fill_super+0xfc7/0x1690 fs/hfs/super.c:406 mount_bdev+0x26c/0x3a0 fs/super.c:1359 legacy_get_tree+0xea/0x180 fs/fs_context.c:610 vfs_get_tree+0x88/0x270 fs/super.c:1489 do_new_mount+0x289/0xad0 fs/namespace.c:3145 do_mount fs/namespace.c:3488 [inline] __do_sys_mount fs/namespace.c:3697 [inline] __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3674 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f1e6368d5fa Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1e64416f88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00000000000002b8 RCX: 00007f1e6368d5fa RDX: 0000000020000440 RSI: 0000000020001140 RDI: 00007f1e64416fe0 RBP: 00007f1e64417020 R08: 00007f1e64417020 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000202 R12: 0000000020000440 R13: 0000000020001140 R14: 00007f1e64416fe0 R15: 0000000020000100 hfs: unable to open catalog tree hfs: can't find a HFS filesystem on dev loop1