====================================================== WARNING: possible circular locking dependency detected 6.1.68-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/7400 is trying to acquire lock: ffff8880729a52c8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 but task is already holding lock: ffff88809123e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:461 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x74e/0xe30 fs/quota/dquot.c:984 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1562 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3010 vfs_mkdir+0x3b6/0x590 fs/namei.c:4037 do_mkdirat+0x225/0x360 fs/namei.c:4062 __do_sys_mkdirat fs/namei.c:4077 [inline] __se_sys_mkdirat fs/namei.c:4075 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4075 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:505 ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty fs/quota/dquot.c:410 [inline] __dquot_alloc_space+0x574/0xf80 fs/quota/dquot.c:1792 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1160/0x4820 fs/ext4/mballoc.c:5628 ext4_ext_map_blocks+0x1b0c/0x77c0 fs/ext4/extents.c:4287 ext4_map_blocks+0xa3c/0x1ca0 fs/ext4/inode.c:651 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:2981 ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3027 vfs_mkdir+0x3b6/0x590 fs/namei.c:4037 do_mkdirat+0x225/0x360 fs/namei.c:4062 __do_sys_mkdirat fs/namei.c:4077 [inline] __se_sys_mkdirat fs/namei.c:4075 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4075 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:7089 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x190/0xc10 fs/quota/quota_tree.c:624 find_tree_dqentry+0x48a/0xc10 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:672 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333 dquot_acquire+0x188/0x680 fs/quota/dquot.c:461 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x74e/0xe30 fs/quota/dquot.c:984 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1562 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664 get_tree_bdev+0x3fe/0x620 fs/super.c:1355 vfs_get_tree+0x88/0x270 fs/super.c:1562 do_new_mount+0x28b/0xae0 fs/namespace.c:3040 do_mount fs/namespace.c:3383 [inline] __do_sys_mount fs/namespace.c:3591 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.5/7400: #0: ffff88809123e0e0 (&type->s_umount_key#27/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228 #1: ffff888090a28268 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:458 #2: ffff88809123e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 stack backtrace: CPU: 0 PID: 7400 Comm: syz-executor.5 Not tainted 6.1.68-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:7089 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x190/0xc10 fs/quota/quota_tree.c:624 find_tree_dqentry+0x48a/0xc10 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:672 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333 dquot_acquire+0x188/0x680 fs/quota/dquot.c:461 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6769 dqget+0x74e/0xe30 fs/quota/dquot.c:984 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1562 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664 get_tree_bdev+0x3fe/0x620 fs/super.c:1355 vfs_get_tree+0x88/0x270 fs/super.c:1562 do_new_mount+0x28b/0xae0 fs/namespace.c:3040 do_mount fs/namespace.c:3383 [inline] __do_sys_mount fs/namespace.c:3591 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f3f5b67e2aa Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3f5c447ee8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f3f5c447f80 RCX: 00007f3f5b67e2aa RDX: 0000000020000040 RSI: 0000000020000500 RDI: 00007f3f5c447f40 RBP: 0000000020000040 R08: 00007f3f5c447f80 R09: 000000000000c906 R10: 000000000000c906 R11: 0000000000000202 R12: 0000000020000500 R13: 00007f3f5c447f40 R14: 00000000000004d2 R15: 000000000000002c EXT4-fs (loop5): 1 orphan inode deleted EXT4-fs (loop5): mounted filesystem without journal. Quota mode: writeback. EXT4-fs error (device loop5): ext4_mb_mark_diskspace_used:3816: comm syz-executor.5: Allocating blocks 50-51 which overlap fs metadata EXT4-fs (loop5): Remounting filesystem read-only