====================================================== WARNING: possible circular locking dependency detected 6.1.87-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/7450 is trying to acquire lock: ffff8880707fc5e8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x57/0x510 fs/quota/dquot.c:507 but task is already holding lock: ffff888058f266d8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4272 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ei->i_data_sem/2){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ext4_map_blocks+0x963/0x1ca0 fs/ext4/inode.c:644 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7147 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:130 do_insert_tree+0x299/0x1ae0 fs/quota/quota_tree.c:340 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6773 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1516 ext4_rmdir+0x147/0xad0 fs/ext4/namei.c:3155 vfs_rmdir+0x35b/0x4b0 fs/namei.c:4193 do_rmdir+0x3a2/0x590 fs/namei.c:4254 __do_sys_rmdir fs/namei.c:4273 [inline] __se_sys_rmdir fs/namei.c:4271 [inline] __x64_sys_rmdir+0x45/0x50 fs/namei.c:4271 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6773 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1516 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664 get_tree_bdev+0x3fe/0x620 fs/super.c:1355 vfs_get_tree+0x88/0x270 fs/super.c:1562 do_new_mount+0x2ba/0xb40 fs/namespace.c:3051 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&dquot->dq_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1941 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6144 [inline] ext4_free_blocks+0x1fb8/0x3020 fs/ext4/mballoc.c:6274 ext4_remove_blocks fs/ext4/extents.c:2521 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2687 [inline] ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2935 ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4446 ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4277 ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286 evict+0x2a4/0x620 fs/inode.c:666 d_delete_notify include/linux/fsnotify.h:261 [inline] vfs_rmdir+0x381/0x4b0 fs/namei.c:4206 do_rmdir+0x3a2/0x590 fs/namei.c:4254 __do_sys_unlinkat fs/namei.c:4434 [inline] __se_sys_unlinkat fs/namei.c:4428 [inline] __x64_sys_unlinkat+0xdc/0xf0 fs/namei.c:4428 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&dquot->dq_lock); *** DEADLOCK *** 5 locks held by syz-executor.0/7450: #0: ffff888027c6e460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff8880461c1810 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff8880461c1810 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: do_rmdir+0x251/0x590 fs/namei.c:4241 #2: ffff888027c6e650 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1891 [inline] #2: ffff888027c6e650 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:2013 [inline] #2: ffff888027c6e650 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240 #3: ffff888058f266d8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4272 #4: ffffffff8d2716a8 (dquot_srcu){....}-{0:0}, at: rcu_lock_acquire include/linux/rcupdate.h:350 [inline] #4: ffffffff8d2716a8 (dquot_srcu){....}-{0:0}, at: srcu_read_lock include/linux/srcu.h:165 [inline] #4: ffffffff8d2716a8 (dquot_srcu){....}-{0:0}, at: __dquot_free_space+0x1da/0xe70 fs/quota/dquot.c:1914 stack backtrace: CPU: 0 PID: 7450 Comm: syz-executor.0 Not tainted 6.1.87-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1941 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6144 [inline] ext4_free_blocks+0x1fb8/0x3020 fs/ext4/mballoc.c:6274 ext4_remove_blocks fs/ext4/extents.c:2521 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2687 [inline] ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2935 ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4446 ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4277 ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286 evict+0x2a4/0x620 fs/inode.c:666 d_delete_notify include/linux/fsnotify.h:261 [inline] vfs_rmdir+0x381/0x4b0 fs/namei.c:4206 do_rmdir+0x3a2/0x590 fs/namei.c:4254 __do_sys_unlinkat fs/namei.c:4434 [inline] __se_sys_unlinkat fs/namei.c:4428 [inline] __x64_sys_unlinkat+0xdc/0xf0 fs/namei.c:4428 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fe191e7d687 Code: 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 07 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffc7bea4fb8 EFLAGS: 00000207 ORIG_RAX: 0000000000000107 RAX: ffffffffffffffda RBX: 0000000000000065 RCX: 00007fe191e7d687 RDX: 0000000000000200 RSI: 00007ffc7bea6160 RDI: 00000000ffffff9c RBP: 00007fe191ec93b9 R08: 0000555556ed69db R09: 0000000000000000 R10: 0000000000001000 R11: 0000000000000207 R12: 00007ffc7bea6160 R13: 00007fe191ec93b9 R14: 00000000000737c5 R15: 0000000000000018 EXT4-fs error (device loop0): ext4_readdir:260: inode #12: block 32: comm syz-executor.0: path /root/syzkaller-testdir4215373944/syzkaller.Nx1Hwd/150/file1/file0: bad entry in directory: rec_len is smaller than minimal - offset=0, inode=3, rec_len=0, size=2048 fake=0