====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc2-syzkaller-g9aa9b43d689e #0 Not tainted ------------------------------------------------------ syz.5.232/8113 is trying to acquire lock: ffff0000fa281548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_get_block+0x2bc/0x1154 fs/hfsplus/extents.c:260 but task is already holding lock: ffff0000d7b648f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0x88/0x70c fs/hfsplus/bitmap.c:35 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&sbi->alloc_mutex){+.+.}-{4:4}: __mutex_lock_common+0x1d0/0x2190 kernel/locking/mutex.c:602 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_block_allocate+0x88/0x70c fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x770/0x1388 fs/hfsplus/extents.c:469 hfsplus_bmap_reserve+0xe8/0x494 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x190/0x368 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x910/0x1e88 fs/hfsplus/xattr.c:354 hfsplus_initxattrs+0x18c/0x244 fs/hfsplus/xattr_security.c:59 security_inode_init_security+0x6dc/0x7f4 security/security.c:1852 hfsplus_init_security+0x40/0x54 fs/hfsplus/xattr_security.c:71 hfsplus_fill_super+0x109c/0x1714 fs/hfsplus/super.c:568 get_tree_bdev_flags+0x360/0x414 fs/super.c:1679 get_tree_bdev+0x2c/0x3c fs/super.c:1702 hfsplus_get_tree+0x28/0x38 fs/hfsplus/super.c:640 vfs_get_tree+0x90/0x28c fs/super.c:1802 do_new_mount+0x228/0x814 fs/namespace.c:3885 path_mount+0x5b4/0xde0 fs/namespace.c:4209 do_mount fs/namespace.c:4222 [inline] __do_sys_mount fs/namespace.c:4433 [inline] __se_sys_mount fs/namespace.c:4410 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4410 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871 __mutex_lock_common+0x1d0/0x2190 kernel/locking/mutex.c:602 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_get_block+0x2bc/0x1154 fs/hfsplus/extents.c:260 block_read_full_folio+0x2ec/0x824 fs/buffer.c:2427 hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28 filemap_read_folio+0xec/0x2f8 mm/filemap.c:2412 do_read_cache_folio+0x364/0x5bc mm/filemap.c:3894 do_read_cache_page mm/filemap.c:3960 [inline] read_cache_page+0x6c/0x160 mm/filemap.c:3969 read_mapping_page include/linux/pagemap.h:966 [inline] hfsplus_block_allocate+0xdc/0x70c fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x770/0x1388 fs/hfsplus/extents.c:469 hfsplus_get_block+0x314/0x1154 fs/hfsplus/extents.c:245 __block_write_begin_int+0x53c/0x15e8 fs/buffer.c:2151 block_write_begin fs/buffer.c:2262 [inline] cont_write_begin+0x62c/0x968 fs/buffer.c:2601 hfsplus_write_begin+0x7c/0xc4 fs/hfsplus/inode.c:46 generic_perform_write+0x23c/0x79c mm/filemap.c:4112 __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4229 generic_file_write_iter+0x104/0x470 mm/filemap.c:4255 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x62c/0x97c fs/read_write.c:686 ksys_write+0x120/0x210 fs/read_write.c:738 __do_sys_write fs/read_write.c:749 [inline] __se_sys_write fs/read_write.c:746 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:746 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz.5.232/8113: #0: ffff0000d8b250b8 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x1fc/0x2a0 fs/file.c:1213 #1: ffff0000cb88a428 (sb_writers#13){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3094 [inline] #1: ffff0000cb88a428 (sb_writers#13){.+.+}-{0:0}, at: vfs_write+0x244/0x97c fs/read_write.c:682 #2: ffff0000fa283238 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #2: ffff0000fa283238 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: generic_file_write_iter+0xd4/0x470 mm/filemap.c:4252 #3: ffff0000fa283048 (&hip->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1b8/0x1388 fs/hfsplus/extents.c:458 #4: ffff0000d7b648f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0x88/0x70c fs/hfsplus/bitmap.c:35 stack backtrace: CPU: 1 UID: 0 PID: 8113 Comm: syz.5.232 Not tainted 6.16.0-rc2-syzkaller-g9aa9b43d689e #0 PREEMPT Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:501 (C) __dump_stack+0x30/0x40 lib/dump_stack.c:94 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2046 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871 __mutex_lock_common+0x1d0/0x2190 kernel/locking/mutex.c:602 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:799 hfsplus_get_block+0x2bc/0x1154 fs/hfsplus/extents.c:260 block_read_full_folio+0x2ec/0x824 fs/buffer.c:2427 hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28 filemap_read_folio+0xec/0x2f8 mm/filemap.c:2412 do_read_cache_folio+0x364/0x5bc mm/filemap.c:3894 do_read_cache_page mm/filemap.c:3960 [inline] read_cache_page+0x6c/0x160 mm/filemap.c:3969 read_mapping_page include/linux/pagemap.h:966 [inline] hfsplus_block_allocate+0xdc/0x70c fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x770/0x1388 fs/hfsplus/extents.c:469 hfsplus_get_block+0x314/0x1154 fs/hfsplus/extents.c:245 __block_write_begin_int+0x53c/0x15e8 fs/buffer.c:2151 block_write_begin fs/buffer.c:2262 [inline] cont_write_begin+0x62c/0x968 fs/buffer.c:2601 hfsplus_write_begin+0x7c/0xc4 fs/hfsplus/inode.c:46 generic_perform_write+0x23c/0x79c mm/filemap.c:4112 __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4229 generic_file_write_iter+0x104/0x470 mm/filemap.c:4255 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x62c/0x97c fs/read_write.c:686 ksys_write+0x120/0x210 fs/read_write.c:738 __do_sys_write fs/read_write.c:749 [inline] __se_sys_write fs/read_write.c:746 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:746 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600