bisecting fixing commit since 8961076ed318dfd22aa357b41589f07bf67e73b6 building syzkaller on 0767f13fbd87c99aea7893eb64199b76be42cd61 testing commit 8961076ed318dfd22aa357b41589f07bf67e73b6 with gcc (GCC) 8.1.0 kernel signature: 7847cfa98f6fe2abf24a05993b1a3dcb414e7977306671d5b13ef0715613bb0f run #0: crashed: WARNING: locking bug in rhashtable_free_and_destroy run #1: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #2: crashed: general protection fault in get_work_pool run #3: crashed: BUG: sleeping function called from invalid context in __do_page_fault run #4: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #5: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #6: crashed: general protection fault in get_work_pool run #7: crashed: general protection fault in get_work_pool run #8: crashed: INFO: task hung in rtnl_lock run #9: crashed: INFO: task hung in rtnl_lock testing current HEAD 1752938529c614a8ed4432ecce6ebc95d3b87207 testing commit 1752938529c614a8ed4432ecce6ebc95d3b87207 with gcc (GCC) 8.1.0 kernel signature: 8cfc0493c059ac3440689b92791d1178a157847d11a684a9d20195e09773dcc7 all runs: OK # git bisect start 1752938529c614a8ed4432ecce6ebc95d3b87207 8961076ed318dfd22aa357b41589f07bf67e73b6 Bisecting: 210 revisions left to test after this (roughly 8 steps) [17d28c91822e93ef45cdf4a22489536fb1767b46] USB: UAS: introduce a quirk to set no_write_same testing commit 17d28c91822e93ef45cdf4a22489536fb1767b46 with gcc (GCC) 8.1.0 kernel signature: 6d0566fbf32f6664aa1601648d99c3c160578e6be70434625a1aab42a4a846e0 all runs: OK # git bisect bad 17d28c91822e93ef45cdf4a22489536fb1767b46 Bisecting: 105 revisions left to test after this (roughly 7 steps) [752eed3e89208a0b585047f36dfb2d5bdf1cb129] batman-adv: set .owner to THIS_MODULE testing commit 752eed3e89208a0b585047f36dfb2d5bdf1cb129 with gcc (GCC) 8.1.0 kernel signature: 93774c22332594f6717194ecea3cc12e233b077eb519866ad129a2ac2a479c43 run #0: crashed: BUG: sleeping function called from invalid context in __do_page_fault run #1: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #2: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #3: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #4: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #5: crashed: BUG: sleeping function called from invalid context in __do_page_fault run #6: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #7: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #8: crashed: INFO: task hung in rtnl_lock run #9: crashed: INFO: task hung in rtnl_lock # git bisect good 752eed3e89208a0b585047f36dfb2d5bdf1cb129 Bisecting: 52 revisions left to test after this (roughly 6 steps) [bc435a0dfb3c81b18ed8d9d4cfab42597416750e] USB: serial: option: add Fibocom NL668 variants testing commit bc435a0dfb3c81b18ed8d9d4cfab42597416750e with gcc (GCC) 8.1.0 kernel signature: f73efcbf51531bb8124080a6e5dbad6defee4bdf0442de76c8cd18e538a4981e run #0: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #1: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #2: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #3: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #4: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #5: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #6: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #7: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #8: crashed: INFO: task hung in rtnl_lock run #9: crashed: INFO: task hung in rtnl_lock # git bisect good bc435a0dfb3c81b18ed8d9d4cfab42597416750e Bisecting: 26 revisions left to test after this (roughly 5 steps) [c04d5a3d004273878029cbbc238d7c16881df36f] iwlwifi: pcie: limit memory read spin time testing commit c04d5a3d004273878029cbbc238d7c16881df36f with gcc (GCC) 8.1.0 kernel signature: d48f15dd44a4b5261118f5975ad629aafacbced978daba3704da26df52380103 run #0: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #1: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #2: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #3: crashed: BUG: sleeping function called from invalid context in __do_page_fault run #4: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #5: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #6: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #7: crashed: BUG: sleeping function called from invalid context in __do_page_fault run #8: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #9: crashed: general protection fault in get_work_pool # git bisect good c04d5a3d004273878029cbbc238d7c16881df36f Bisecting: 13 revisions left to test after this (roughly 4 steps) [a4dafa88e55dc4cd908421dea960f15feb1d0510] PCI: qcom: Add missing reset for ipq806x testing commit a4dafa88e55dc4cd908421dea960f15feb1d0510 with gcc (GCC) 8.1.0 kernel signature: 01261589e4cb426888c48c095c58d1e57932d5c7c134b5eec3392957ae45d127 run #0: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #1: crashed: general protection fault in __bfs run #2: crashed: general protection fault in get_work_pool run #3: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #4: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #5: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #6: crashed: general protection fault in get_work_pool run #7: crashed: INFO: task hung in rtnl_lock run #8: crashed: INFO: task hung in rtnl_lock run #9: crashed: INFO: task hung in rtnl_lock # git bisect good a4dafa88e55dc4cd908421dea960f15feb1d0510 Bisecting: 6 revisions left to test after this (roughly 3 steps) [97b46062905025f53570a72e4e1274af36446833] net: bridge: vlan: fix error return code in __vlan_add() testing commit 97b46062905025f53570a72e4e1274af36446833 with gcc (GCC) 8.1.0 kernel signature: 9e97ccabbfce24c46020fc320db1ba385c5782582cbd51a08c1f991a93e3659f run #0: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #1: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #2: crashed: BUG: sleeping function called from invalid context in __do_page_fault run #3: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #4: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #5: crashed: general protection fault in get_work_pool run #6: crashed: general protection fault in get_work_pool run #7: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #8: crashed: INFO: trying to register non-static key in rhashtable_free_and_destroy run #9: crashed: INFO: task hung in rtnl_lock # git bisect good 97b46062905025f53570a72e4e1274af36446833 Bisecting: 3 revisions left to test after this (roughly 2 steps) [230f33f3cb954aacadc2cb90396f10269129b19c] USB: add RESET_RESUME quirk for Snapscan 1212 testing commit 230f33f3cb954aacadc2cb90396f10269129b19c with gcc (GCC) 8.1.0 kernel signature: 09560370583bf9b8218ce036376d7921c1dc08d5f894e9a744584b48b3847d8f all runs: OK # git bisect bad 230f33f3cb954aacadc2cb90396f10269129b19c Bisecting: 0 revisions left to test after this (roughly 1 step) [7dce946e51e3979db4191e49f524f53f3c5a95ac] USB: dummy-hcd: Fix uninitialized array use in init() testing commit 7dce946e51e3979db4191e49f524f53f3c5a95ac with gcc (GCC) 8.1.0 kernel signature: 25a8b39f502a373a817f18c930cc803104c0edbcf00998146574e52147e2fc3f all runs: OK # git bisect bad 7dce946e51e3979db4191e49f524f53f3c5a95ac Bisecting: 0 revisions left to test after this (roughly 0 steps) [42a387dc80c334ad78e604e0522b3d7a3f7113a5] mac80211: mesh: fix mesh_pathtbl_init() error path testing commit 42a387dc80c334ad78e604e0522b3d7a3f7113a5 with gcc (GCC) 8.1.0 kernel signature: 6cdc7d19936e41702ccf9462a13fcc7fedff105a3f277c1c33d47974381919fb all runs: OK # git bisect bad 42a387dc80c334ad78e604e0522b3d7a3f7113a5 42a387dc80c334ad78e604e0522b3d7a3f7113a5 is the first bad commit commit 42a387dc80c334ad78e604e0522b3d7a3f7113a5 Author: Eric Dumazet Date: Fri Dec 4 08:24:28 2020 -0800 mac80211: mesh: fix mesh_pathtbl_init() error path [ Upstream commit 905b2032fa424f253d9126271439cc1db2b01130 ] If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path) while tbl_path rhashtable has not yet been initialized, which causes panics. Simply factorize the rhashtable_init() call into mesh_table_alloc() WARNING: CPU: 1 PID: 8474 at kernel/workqueue.c:3040 __flush_work kernel/workqueue.c:3040 [inline] WARNING: CPU: 1 PID: 8474 at kernel/workqueue.c:3040 __cancel_work_timer+0x514/0x540 kernel/workqueue.c:3136 Modules linked in: CPU: 1 PID: 8474 Comm: syz-executor663 Not tainted 5.10.0-rc6-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:__flush_work kernel/workqueue.c:3040 [inline] RIP: 0010:__cancel_work_timer+0x514/0x540 kernel/workqueue.c:3136 Code: 5d c3 e8 bf ae 29 00 0f 0b e9 f0 fd ff ff e8 b3 ae 29 00 0f 0b 43 80 3c 3e 00 0f 85 31 ff ff ff e9 34 ff ff ff e8 9c ae 29 00 <0f> 0b e9 dc fe ff ff 89 e9 80 e1 07 80 c1 03 38 c1 0f 8c 7d fd ff RSP: 0018:ffffc9000165f5a0 EFLAGS: 00010293 RAX: ffffffff814b7064 RBX: 0000000000000001 RCX: ffff888021c80000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffff888024039ca0 R08: dffffc0000000000 R09: fffffbfff1dd3e64 R10: fffffbfff1dd3e64 R11: 0000000000000000 R12: 1ffff920002cbebd R13: ffff888024039c88 R14: 1ffff11004807391 R15: dffffc0000000000 FS: 0000000001347880(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020000140 CR3: 000000002cc0a000 CR4: 00000000001506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: rhashtable_free_and_destroy+0x25/0x9c0 lib/rhashtable.c:1137 mesh_table_free net/mac80211/mesh_pathtbl.c:69 [inline] mesh_pathtbl_init+0x287/0x2e0 net/mac80211/mesh_pathtbl.c:785 ieee80211_mesh_init_sdata+0x2ee/0x530 net/mac80211/mesh.c:1591 ieee80211_setup_sdata+0x733/0xc40 net/mac80211/iface.c:1569 ieee80211_if_add+0xd5c/0x1cd0 net/mac80211/iface.c:1987 ieee80211_add_iface+0x59/0x130 net/mac80211/cfg.c:125 rdev_add_virtual_intf net/wireless/rdev-ops.h:45 [inline] nl80211_new_interface+0x563/0xb40 net/wireless/nl80211.c:3855 genl_family_rcv_msg_doit net/netlink/genetlink.c:739 [inline] genl_family_rcv_msg net/netlink/genetlink.c:783 [inline] genl_rcv_msg+0xe4e/0x1280 net/netlink/genetlink.c:800 netlink_rcv_skb+0x190/0x3a0 net/netlink/af_netlink.c:2494 genl_rcv+0x24/0x40 net/netlink/genetlink.c:811 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline] netlink_unicast+0x780/0x930 net/netlink/af_netlink.c:1330 netlink_sendmsg+0x9a8/0xd40 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:651 [inline] sock_sendmsg net/socket.c:671 [inline] ____sys_sendmsg+0x519/0x800 net/socket.c:2353 ___sys_sendmsg net/socket.c:2407 [inline] __sys_sendmsg+0x2b1/0x360 net/socket.c:2440 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: 60854fd94573 ("mac80211: mesh: convert path table to rhashtable") Signed-off-by: Eric Dumazet Reported-by: syzbot Reviewed-by: Johannes Berg Link: https://lore.kernel.org/r/20201204162428.2583119-1-eric.dumazet@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman net/mac80211/mesh_pathtbl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) culprit signature: 6cdc7d19936e41702ccf9462a13fcc7fedff105a3f277c1c33d47974381919fb parent signature: 9e97ccabbfce24c46020fc320db1ba385c5782582cbd51a08c1f991a93e3659f revisions tested: 11, total time: 3h0m10.086713287s (build: 1h27m59.348045929s, test: 1h31m0.287142369s) first good commit: 42a387dc80c334ad78e604e0522b3d7a3f7113a5 mac80211: mesh: fix mesh_pathtbl_init() error path recipients (to): ["edumazet@google.com" "gregkh@linuxfoundation.org" "johannes@sipsolutions.net" "kuba@kernel.org"] recipients (cc): []