bisecting cause commit starting from 996e435fd401de35df62ac943ab9402cfe85c430 building syzkaller on 2c1f2513486f21d26b1942ce77ffc782677fbf4e testing commit 996e435fd401de35df62ac943ab9402cfe85c430 with gcc (GCC) 8.1.0 kernel signature: 7655733407d0800f6d09e6afe9a91ea2fb6baf5375cd2b93fdc7ca9996ad9fa7 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.10 testing commit 2c85ebc57b3e1817b6ce1a6b703928e113a90442 with gcc (GCC) 8.1.0 kernel signature: 395a614079c9030036488f72c030c4708fae86b9aba956ca15d15003efd3a593 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.9 testing commit bbf5c979011a099af5dc76498918ed7df445635b with gcc (GCC) 8.1.0 kernel signature: 267e4e72ea6151d6ca484a7d3cc70be89ff7365b860f2a296ca76a677664b0bf all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.8 testing commit bcf876870b95592b52519ed4aafcf9d95999bc9c with gcc (GCC) 8.1.0 kernel signature: e1b748eb2406e6b7622d3ac2ddd4d5444e7de9e64fd85ab34f83bf371b1755d5 run #0: crashed: WARNING in sta_info_insert_rcu run #1: crashed: WARNING in sta_info_insert_rcu run #2: crashed: WARNING in corrupted run #3: crashed: WARNING in sta_info_insert_rcu run #4: crashed: WARNING in sta_info_insert_rcu run #5: crashed: WARNING in sta_info_insert_rcu run #6: crashed: WARNING in sta_info_insert_rcu run #7: crashed: WARNING in sta_info_insert_rcu run #8: crashed: WARNING in sta_info_insert_rcu run #9: crashed: WARNING in sta_info_insert_rcu testing release v5.7 testing commit 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162 with gcc (GCC) 8.1.0 kernel signature: 47862bb6707373f5ffcdd61ba6af4294f0c423a6cb2ee4daa5590631048de304 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.6 testing commit 7111951b8d4973bda27ff663f2cf18b663d15b48 with gcc (GCC) 8.1.0 kernel signature: 61d2f47e590b5f5b9af99913aeee4a183890a5a3a42d33ead5af338d6fce77b0 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.5 testing commit d5226fa6dbae0569ee43ecfc08bdcd6770fc4755 with gcc (GCC) 8.1.0 kernel signature: c02e30c85a426c1e8f9c3abeaf54f05a4c728b21f645f4db12a4be37adab4f4f all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.4 testing commit 219d54332a09e8d8741c1e1982f5eae56099de85 with gcc (GCC) 8.1.0 kernel signature: 418d776f3a3a1cc9254eb5d6ca3b32cfdd18be0b9d67b015b468405fb2daecff all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.3 testing commit 4d856f72c10ecb060868ed10ff1b1453943fc6c8 with gcc (GCC) 8.1.0 kernel signature: e249628c1ee34f77f2aa319be282abb58f3d9140778e2d153979f2cd76c9b777 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.2 testing commit 0ecfebd2b52404ae0c54a878c872bb93363ada36 with gcc (GCC) 8.1.0 kernel signature: a6a68d9583d3a8125b02c95fc9622169e78400904b09f46799b9f3c98b341f31 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.1 testing commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd with gcc (GCC) 8.1.0 kernel signature: f8444d7f606701f2cba2c2b1e79ec64e2e00a9604951e8f29c97fd39394d2e63 all runs: crashed: WARNING in sta_info_insert_rcu testing release v5.0 testing commit 1c163f4c7b3f621efff9b28a47abb36f7378d783 with gcc (GCC) 8.1.0 kernel signature: d1de21bb044e544efe5b0b18676c1120101c7d2ac339371f47a9b257538ce7cb all runs: crashed: WARNING in sta_info_insert_rcu testing release v4.20 testing commit 8fe28cb58bcb235034b64cbbb7550a8a43fd88be with gcc (GCC) 8.1.0 kernel signature: 77abee1c149c79a6aaed80e62a0582d8b3706a751c07086d91533f8c7718c290 all runs: crashed: WARNING in sta_info_insert_rcu testing release v4.19 testing commit 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d with gcc (GCC) 8.1.0 kernel signature: a0c3f689e27e93f7cc9f5290fded85009770aaae03cddc7bfcefb790afab84c5 all runs: crashed: WARNING in sta_info_insert_rcu testing release v4.18 testing commit 94710cac0ef4ee177a63b5227664b38c95bbf703 with gcc (GCC) 8.1.0 kernel signature: ac15ad7a2352a97587f3df0295cbbb58ed835d65704d2095ff5081224ce84a3d all runs: OK # git bisect start 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d 94710cac0ef4ee177a63b5227664b38c95bbf703 Bisecting: 7596 revisions left to test after this (roughly 13 steps) [db06f826ec12bf0701ea7fc0a3c0aa00b84417c8] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux testing commit db06f826ec12bf0701ea7fc0a3c0aa00b84417c8 with gcc (GCC) 8.1.0 kernel signature: d44ee4c1ca715e67fc075ea0bf4a80886d889d5c220acb82fe8531c8b1b1ccf2 all runs: OK # git bisect good db06f826ec12bf0701ea7fc0a3c0aa00b84417c8 Bisecting: 3768 revisions left to test after this (roughly 12 steps) [cd9b44f90763c3367e8dd0601849ffb028e8ba52] Merge branch 'akpm' (patches from Andrew) testing commit cd9b44f90763c3367e8dd0601849ffb028e8ba52 with gcc (GCC) 8.1.0 kernel signature: 67e460f590d67cd3789183a25554bc08247e3c60da024aa2334985f5b45d9f67 all runs: OK # git bisect good cd9b44f90763c3367e8dd0601849ffb028e8ba52 Bisecting: 1886 revisions left to test after this (roughly 11 steps) [4290d5b9ca018be10c7582524f7500df731bfab0] Merge tag 'for-linus-4.19b-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip testing commit 4290d5b9ca018be10c7582524f7500df731bfab0 with gcc (GCC) 8.1.0 kernel signature: 81ee6183ee69629fdff83a3d8f50ca6fefb58211395d45a36a842b1d6bb3be65 run #0: basic kernel testing failed: general protection fault in batadv_iv_ogm_queue_add run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 4290d5b9ca018be10c7582524f7500df731bfab0 Bisecting: 942 revisions left to test after this (roughly 10 steps) [576156bb01a62c1f64b32b416593862bb34bddaa] Merge branch 'for-upstream/malidp-fixes' of git://linux-arm.org/linux-ld into drm-fixes testing commit 576156bb01a62c1f64b32b416593862bb34bddaa with gcc (GCC) 8.1.0 kernel signature: f1d6fb231d51e73347704d8bb4e001ddcffce87a4e47c2780de529b97f167241 all runs: OK # git bisect good 576156bb01a62c1f64b32b416593862bb34bddaa Bisecting: 470 revisions left to test after this (roughly 9 steps) [4fbeba43b9b6f76a270108edcf5305dc1882a478] Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 testing commit 4fbeba43b9b6f76a270108edcf5305dc1882a478 with gcc (GCC) 8.1.0 kernel signature: 55f5748cfb40e4c4a73a2c2545647d0502873e6beb196065b442a2ce69fbefbe all runs: OK # git bisect good 4fbeba43b9b6f76a270108edcf5305dc1882a478 Bisecting: 218 revisions left to test after this (roughly 8 steps) [90ad18418c2d3db23ee827cdd74fed2ca9b70a18] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net testing commit 90ad18418c2d3db23ee827cdd74fed2ca9b70a18 with gcc (GCC) 8.1.0 kernel signature: 8373513b3429f3870d27edb9ed5eddef7060cd83eceb047d8c065c9ed2274565 all runs: crashed: WARNING in sta_info_insert_rcu # git bisect bad 90ad18418c2d3db23ee827cdd74fed2ca9b70a18 Bisecting: 124 revisions left to test after this (roughly 7 steps) [4ebaf0754c7a1109e66693f488f02b78f5875fee] Merge tag 'tty-4.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty testing commit 4ebaf0754c7a1109e66693f488f02b78f5875fee with gcc (GCC) 8.1.0 kernel signature: 3eb643993ec475b1b573e17cd920059897552b85b690a69c2dff1aabf794b549 all runs: crashed: WARNING in sta_info_insert_rcu # git bisect bad 4ebaf0754c7a1109e66693f488f02b78f5875fee Bisecting: 69 revisions left to test after this (roughly 6 steps) [5943a9bbbb98b5c957662edd2fc902cc14e65895] Merge tag 'pci-v4.19-fixes-3' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/helgaas/pci testing commit 5943a9bbbb98b5c957662edd2fc902cc14e65895 with gcc (GCC) 8.1.0 kernel signature: f8d08333f392a894726213064b2e13d6a5f2d01ff3af5bd9c79b944393068144 all runs: OK # git bisect good 5943a9bbbb98b5c957662edd2fc902cc14e65895 Bisecting: 39 revisions left to test after this (roughly 5 steps) [35f3625c21852ad839f20c91c7d81c4c1101e207] net: mvpp2: Extract the correct ethtype from the skb for tx csum offload testing commit 35f3625c21852ad839f20c91c7d81c4c1101e207 with gcc (GCC) 8.1.0 kernel signature: 4aeda3cb930ec429b6c25a12d8afc05c97af6839a279b266697cc5d85a381ef2 all runs: crashed: WARNING in sta_info_insert_rcu # git bisect bad 35f3625c21852ad839f20c91c7d81c4c1101e207 Bisecting: 14 revisions left to test after this (roughly 4 steps) [17c357efe5eceebdc3971a48b3d4d61a03c1178b] openvswitch: load NAT helper testing commit 17c357efe5eceebdc3971a48b3d4d61a03c1178b with gcc (GCC) 8.1.0 kernel signature: 20f69243161b9dbe60d60c678de19db0188f769ab919509f045ef0341799181a all runs: OK # git bisect good 17c357efe5eceebdc3971a48b3d4d61a03c1178b Bisecting: 6 revisions left to test after this (roughly 3 steps) [b8d5b7cec43618c8f91a9fbe80067ef2dcbc4d35] Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf testing commit b8d5b7cec43618c8f91a9fbe80067ef2dcbc4d35 with gcc (GCC) 8.1.0 kernel signature: ed63a456903e120e0fb90be96c1976070e3bede935f849bb374f4bd4613d017c all runs: crashed: WARNING in sta_info_insert_rcu # git bisect bad b8d5b7cec43618c8f91a9fbe80067ef2dcbc4d35 Bisecting: 3 revisions left to test after this (roughly 2 steps) [7e4183752735deb7543e179a44f4f4b44917cd6f] net: phy: phylink: fix SFP interface autodetection testing commit 7e4183752735deb7543e179a44f4f4b44917cd6f with gcc (GCC) 8.1.0 kernel signature: 12b228052f926142d078a16ba5600a32cd858ba3c378d42a3c5db06ad6886e6c all runs: crashed: WARNING in sta_info_insert_rcu # git bisect bad 7e4183752735deb7543e179a44f4f4b44917cd6f Bisecting: 1 revision left to test after this (roughly 1 step) [9d2f67e43b73e8af7438be219b66a5de0cfa8bd9] net/packet: fix packet drop as of virtio gso testing commit 9d2f67e43b73e8af7438be219b66a5de0cfa8bd9 with gcc (GCC) 8.1.0 kernel signature: fa69c36fe28cf7b35eef094f39a88e97e0611314e68537381bc1a148ead25050 run #0: crashed: WARNING in sta_info_insert_rcu run #1: crashed: WARNING in sta_info_insert_rcu run #2: crashed: WARNING in sta_info_insert_rcu run #3: crashed: WARNING in sta_info_insert_rcu run #4: crashed: WARNING in sta_info_insert_rcu run #5: crashed: WARNING in corrupted run #6: crashed: WARNING in sta_info_insert_rcu run #7: crashed: WARNING in sta_info_insert_rcu run #8: crashed: WARNING in sta_info_insert_rcu run #9: crashed: WARNING in sta_info_insert_rcu # git bisect bad 9d2f67e43b73e8af7438be219b66a5de0cfa8bd9 Bisecting: 0 revisions left to test after this (roughly 0 steps) [ca8931948344c485569b04821d1f6bcebccd376b] net: dsa: b53: Keep CPU port as tagged in all VLANs testing commit ca8931948344c485569b04821d1f6bcebccd376b with gcc (GCC) 8.1.0 kernel signature: 20f69243161b9dbe60d60c678de19db0188f769ab919509f045ef0341799181a run #0: OK run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: crashed: general protection fault in batadv_iv_ogm_queue_add reproducer seems to be flaky # git bisect bad ca8931948344c485569b04821d1f6bcebccd376b ca8931948344c485569b04821d1f6bcebccd376b is the first bad commit commit ca8931948344c485569b04821d1f6bcebccd376b Author: Florian Fainelli Date: Thu Oct 4 20:24:13 2018 -0700 net: dsa: b53: Keep CPU port as tagged in all VLANs Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly") was a bit too trigger happy in removing the CPU port from the VLAN membership because we rely on DSA to program the CPU port VLAN, which it does, except it does not bother itself with tagged/untagged and just usese untagged. Having the CPU port "follow" the user ports tagged/untagged is not great and does not allow for properly differentiating, so keep the CPU port tagged in all VLANs. Reported-by: Gerhard Wiesinger Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller drivers/net/dsa/b53/b53_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) culprit signature: 20f69243161b9dbe60d60c678de19db0188f769ab919509f045ef0341799181a parent signature: 20f69243161b9dbe60d60c678de19db0188f769ab919509f045ef0341799181a Reproducer flagged being flaky revisions tested: 29, total time: 4h51m25.676812s (build: 2h28m25.095034393s, test: 2h19m53.543489307s) first bad commit: ca8931948344c485569b04821d1f6bcebccd376b net: dsa: b53: Keep CPU port as tagged in all VLANs recipients (to): ["andrew@lunn.ch" "davem@davemloft.net" "f.fainelli@gmail.com" "f.fainelli@gmail.com" "netdev@vger.kernel.org" "vivien.didelot@savoirfairelinux.com"] recipients (cc): ["davem@davemloft.net" "linux-kernel@vger.kernel.org"] crash: general protection fault in batadv_iv_ogm_queue_add batman_adv: batadv0: Interface deactivated: batadv_slave_1 batman_adv: batadv0: Removing interface: batadv_slave_1 kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] PREEMPT SMP KASAN CPU: 0 PID: 10185 Comm: kworker/u4:7 Not tainted 4.19.0-rc6-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet RIP: 0010:batadv_iv_ogm_queue_add+0x9b/0xe50 net/batman-adv/bat_iv_ogm.c:785 Code: 44 89 8d 64 ff ff ff c7 02 f1 f1 f1 f1 c7 42 04 04 f2 f2 f2 48 89 fa 65 48 8b 0c 25 28 00 00 00 48 89 4d d0 31 c9 48 c1 ea 03 <0f> b6 04 02 48 89 fa 83 e2 07 38 d0 7f 08 84 c0 0f 85 99 0b 00 00 RSP: 0018:ffff88009822faa8 EFLAGS: 00010246 RAX: dffffc0000000000 RBX: ffff8800a9494cc0 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: ffff88009822fbc0 R08: ffff880095a08500 R09: 0000000000000001 R10: ffffed0013045f8f R11: 0000000000000003 R12: ffff880095a08500 R13: dffffc0000000000 R14: ffffed0012b410af R15: 000000000000003c FS: 0000000000000000(0000) GS:ffff8800ba200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffb66ce1018 CR3: 00000000a56a0000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: batadv_iv_ogm_schedule+0xb7e/0xf30 net/batman-adv/bat_iv_ogm.c:989 batadv_iv_send_outstanding_bat_ogm_packet+0x4b2/0x7b0 net/batman-adv/bat_iv_ogm.c:1817 process_one_work+0x7b9/0x14f0 kernel/workqueue.c:2153 worker_thread+0x85/0xb60 kernel/workqueue.c:2296 kthread+0x324/0x3e0 kernel/kthread.c:246 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:413 Modules linked in: ---[ end trace f3bf69a9bb8b110a ]--- RIP: 0010:batadv_iv_ogm_queue_add+0x9b/0xe50 net/batman-adv/bat_iv_ogm.c:785 Code: 44 89 8d 64 ff ff ff c7 02 f1 f1 f1 f1 c7 42 04 04 f2 f2 f2 48 89 fa 65 48 8b 0c 25 28 00 00 00 48 89 4d d0 31 c9 48 c1 ea 03 <0f> b6 04 02 48 89 fa 83 e2 07 38 d0 7f 08 84 c0 0f 85 99 0b 00 00 RSP: 0018:ffff88009822faa8 EFLAGS: 00010246 RAX: dffffc0000000000 RBX: ffff8800a9494cc0 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: ffff88009822fbc0 R08: ffff880095a08500 R09: 0000000000000001 R10: ffffed0013045f8f R11: 0000000000000003 R12: ffff880095a08500 R13: dffffc0000000000 R14: ffffed0012b410af R15: 000000000000003c FS: 0000000000000000(0000) GS:ffff8800ba200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffb66ce1018 CR3: 00000000a56a0000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400