bisecting cause commit starting from 60ec7fcfe76892a1479afab51ff17a4281923156 building syzkaller on 44068e196185e2f5a7c94629b6245cdde008b140 testing commit 60ec7fcfe76892a1479afab51ff17a4281923156 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 8c7352d46ca32927f1d6212d5aaf631f3b05cb25533f3de15ed459c9166ef700 all runs: crashed: WARNING: lock held when returning to user space in tcp_setsockopt testing release v5.15 testing commit 8bb7eca972ad531c9b149c0a51ab43a417385813 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 71323c101898a9d6190815ff9f0f1d0fc16010a2b4108dab910da9879ec0438d run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #9: OK testing release v5.14 testing commit 7d2a07b769330c34b4deabeed939325c77a7ec2f compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: fdfe9d68da08535da6f5146b3990d2c60178dfb0664c0fc62d32fedb96568655 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: possible deadlock in __inet_stream_connect run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: OK run #8: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #9: OK testing release v5.13 testing commit 62fb9874f5da54fdb243003b386128037319b219 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6c3345e6367a7be5f247cc33186f278d4ebecc41a8fd706ff0ad04ad8b97dcf5 run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: OK run #6: OK run #7: OK run #8: OK run #9: crashed: WARNING: lock held when returning to user space in tcp_setsockopt testing release v5.12 testing commit 9f4ad9e425a1d3b6a34617b8ea226d56a119a717 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 5f46ddbe9827c020ce0ae88f1c4c20ff8f8f924177d40b511fa4d951efb4c728 run #0: basic kernel testing failed: BUG: program execution failed: executor NUM: failed to write control pipe: write |NUM: broken pipe run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: OK run #9: OK testing release v5.11 testing commit f40ddce88593482919761f74910f42f4b84c004b compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ab549d96d27d641a39525890fcbc47e5ebcd19b1f44738da1a8ef01a1648580e all runs: OK # git bisect start 9f4ad9e425a1d3b6a34617b8ea226d56a119a717 f40ddce88593482919761f74910f42f4b84c004b Bisecting: 6798 revisions left to test after this (roughly 13 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [d99676af540c2dc829999928fb81c58c80a1dce4] Merge tag 'drm-next-2021-02-19' of git://anongit.freedesktop.org/drm/drm testing commit d99676af540c2dc829999928fb81c58c80a1dce4 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 4d5e872c58cee57503d1b872df8937fb471e62db84d650bffa3af8695ceb61fe run #0: basic kernel testing failed: WARNING in kvm_wait run #1: basic kernel testing failed: WARNING in kvm_wait run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: boot failed: WARNING in kvm_wait run #5: boot failed: WARNING in kvm_wait run #6: boot failed: WARNING in kvm_wait run #7: boot failed: WARNING in kvm_wait run #8: boot failed: WARNING in kvm_wait run #9: boot failed: WARNING in kvm_wait # git bisect bad d99676af540c2dc829999928fb81c58c80a1dce4 Bisecting: 3717 revisions left to test after this (roughly 12 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [f9d58de23152f2c16f326d7e014cfa2933b00304] Merge tag 'affs-for-5.12-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux testing commit f9d58de23152f2c16f326d7e014cfa2933b00304 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: eb76ea71fd579ca9d3e33a9dec6f0cc3df1316dd5b5d435f58554d066bf7884a run #0: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: possible deadlock in __inet_stream_connect run #8: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #9: crashed: WARNING: lock held when returning to user space in tcp_setsockopt # git bisect bad f9d58de23152f2c16f326d7e014cfa2933b00304 Bisecting: 1819 revisions left to test after this (roughly 11 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [b8af417e4d93caeefb89bbfbd56ec95dedd8dab5] Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next testing commit b8af417e4d93caeefb89bbfbd56ec95dedd8dab5 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 665205d13b4f0a36db3a3e1c85b57f2c25bcaacf90c9e766873943d0c4f3b43c all runs: crashed: WARNING: lock held when returning to user space in tcp_setsockopt # git bisect bad b8af417e4d93caeefb89bbfbd56ec95dedd8dab5 Bisecting: 911 revisions left to test after this (roughly 10 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [4d469ec8ec05e1fa4792415de1a95b28871ff2fa] Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue testing commit 4d469ec8ec05e1fa4792415de1a95b28871ff2fa compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ffa3a475001499269af125c48882c845fc74c7b1ba4b81302242ee6f06ffdee8 all runs: OK # git bisect good 4d469ec8ec05e1fa4792415de1a95b28871ff2fa Bisecting: 487 revisions left to test after this (roughly 9 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [295f830e53f4838344c97e12ce69637e2128ca8d] rxrpc: Fix dependency on IPv6 in udp tunnel config testing commit 295f830e53f4838344c97e12ce69637e2128ca8d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 7f4a7c071737ae577d7e2720d0d7c2cc8a697068e9a238a0bb381946b6d9da92 all runs: crashed: WARNING: lock held when returning to user space in tcp_setsockopt # git bisect bad 295f830e53f4838344c97e12ce69637e2128ca8d Bisecting: 211 revisions left to test after this (roughly 8 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [d0cf9503e908ee7b235a5efecedeb74aabc482f3] octeontx2-pf: ethtool fec mode support testing commit d0cf9503e908ee7b235a5efecedeb74aabc482f3 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 2333f6e3e8dcd016c42f0bf95698460fd48c4dd9898317766db304d56ff7f4a1 all runs: OK # git bisect good d0cf9503e908ee7b235a5efecedeb74aabc482f3 Bisecting: 105 revisions left to test after this (roughly 7 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0] octeontx2-af: cn10k: MAC internal loopback support testing commit 3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 860da36f5e8594e41f8bab0d5994a8b2401d27421e6d358f215ab105bb00d5c4 all runs: OK # git bisect good 3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0 Bisecting: 52 revisions left to test after this (roughly 6 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [234f414efd1164786269849b4fbb533d6c9cdbbf] Bluetooth: btusb: Some Qualcomm Bluetooth adapters stop working testing commit 234f414efd1164786269849b4fbb533d6c9cdbbf compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 4b264018e23d531962069b5f0bb5435f7f181e806c06ee06bd2c479f4c60b4d1 all runs: OK # git bisect good 234f414efd1164786269849b4fbb533d6c9cdbbf Bisecting: 26 revisions left to test after this (roughly 5 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [1c9a98b0ba1f16490ea0d492a1cd606f3a4b1bee] net: hns3: refactor out hclge_cmd_convert_err_code() testing commit 1c9a98b0ba1f16490ea0d492a1cd606f3a4b1bee compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 76b4e03b4a014f31c845a9113bba990df96e00137e894f4a6839a36736045762 all runs: OK # git bisect good 1c9a98b0ba1f16490ea0d492a1cd606f3a4b1bee Bisecting: 13 revisions left to test after this (roughly 4 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [c3ff3b02e99c691197a05556ef45f5c3dd2ed3d6] Merge branch 'hns3-cleanups' testing commit c3ff3b02e99c691197a05556ef45f5c3dd2ed3d6 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 76b4e03b4a014f31c845a9113bba990df96e00137e894f4a6839a36736045762 all runs: OK # git bisect good c3ff3b02e99c691197a05556ef45f5c3dd2ed3d6 Bisecting: 6 revisions left to test after this (roughly 3 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [a141e02e393370e082b25636401c49978b61bfcf] mptcp: split __mptcp_close_ssk helper testing commit a141e02e393370e082b25636401c49978b61bfcf compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6b1e4ec83ddcbb99cd23d009c7efe085f653ccb6eb6550d4db1631e6b722f4c8 all runs: OK # git bisect good a141e02e393370e082b25636401c49978b61bfcf Bisecting: 3 revisions left to test after this (roughly 2 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [6c714f1b547feb0402520357c91024375a4236f7] mptcp: pass subflow socket to a few helpers testing commit 6c714f1b547feb0402520357c91024375a4236f7 compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 6cc2c116051dff10839f56caa8778b0c1bab83a332aaf88ab336ba5f7f609a67 run #0: crashed: WARNING: suspicious RCU usage in addrconf_dad_work run #1: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #2: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #3: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #4: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #5: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #6: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #7: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #8: crashed: WARNING: lock held when returning to user space in tcp_setsockopt run #9: crashed: WARNING: lock held when returning to user space in tcp_setsockopt # git bisect bad 6c714f1b547feb0402520357c91024375a4236f7 Bisecting: 0 revisions left to test after this (roughly 1 step) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [b263b0d7d60baecda3c840a0703bb6d511f7ae2d] mptcp: move subflow close loop after sk close check testing commit b263b0d7d60baecda3c840a0703bb6d511f7ae2d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: 448f98cd56eff1bdcca89304c9195697174ed6909208ca57c5a9c81fa59ccd70 all runs: crashed: WARNING: lock held when returning to user space in tcp_setsockopt # git bisect bad b263b0d7d60baecda3c840a0703bb6d511f7ae2d Bisecting: 0 revisions left to test after this (roughly 0 steps) warning: unable to access '/syzkaller/.config/git/ignore': Permission denied warning: unable to access '/syzkaller/.config/git/attributes': Permission denied [40947e13997a1cba4e875893ca6e5d5e61a0689d] mptcp: schedule worker when subflow is closed testing commit 40947e13997a1cba4e875893ca6e5d5e61a0689d compiler: gcc (GCC) 10.2.1 20210217, GNU ld (GNU Binutils for Debian) 2.35.2 kernel signature: ffceed02dd3975fd0086e6fd45ee3e6c207377364c5e87cc6e4961bc4ed90074 all runs: crashed: WARNING: lock held when returning to user space in tcp_setsockopt # git bisect bad 40947e13997a1cba4e875893ca6e5d5e61a0689d warning: unable to access '/syzkaller/.config/git/attributes': Permission denied 40947e13997a1cba4e875893ca6e5d5e61a0689d is the first bad commit commit 40947e13997a1cba4e875893ca6e5d5e61a0689d Author: Florian Westphal Date: Fri Feb 12 15:59:56 2021 -0800 mptcp: schedule worker when subflow is closed When remote side closes a subflow we should schedule the worker to dispose of the subflow in a timely manner. Otherwise, SF_CLOSED event won't be generated until the mptcp socket itself is closing or local side is closing another subflow. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau Signed-off-by: David S. Miller net/mptcp/protocol.c | 4 ++++ net/mptcp/subflow.c | 25 +++++++++++++++++++++++-- 2 files changed, 27 insertions(+), 2 deletions(-) culprit signature: ffceed02dd3975fd0086e6fd45ee3e6c207377364c5e87cc6e4961bc4ed90074 parent signature: 6b1e4ec83ddcbb99cd23d009c7efe085f653ccb6eb6550d4db1631e6b722f4c8 revisions tested: 20, total time: 3h45m5.746137971s (build: 2h5m17.751902083s, test: 1h37m30.389075767s) first bad commit: 40947e13997a1cba4e875893ca6e5d5e61a0689d mptcp: schedule worker when subflow is closed recipients (to): ["davem@davemloft.net" "fw@strlen.de" "mathew.j.martineau@linux.intel.com"] recipients (cc): [] crash: WARNING: lock held when returning to user space in tcp_setsockopt ================================================ WARNING: lock held when returning to user space! 5.11.0-rc7-syzkaller #0 Not tainted ------------------------------------------------ syz-executor876/6019 is leaving the kernel with locks still held! 1 lock held by syz-executor876/6019: #0: ffff88801f9156e0 (k-sk_lock-AF_INET6){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1598 [inline] #0: ffff88801f9156e0 (k-sk_lock-AF_INET6){+.+.}-{0:0}, at: do_tcp_setsockopt net/ipv4/tcp.c:3365 [inline] #0: ffff88801f9156e0 (k-sk_lock-AF_INET6){+.+.}-{0:0}, at: tcp_setsockopt+0x34e/0x1ed0 net/ipv4/tcp.c:3646