bisecting fixing commit since 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 building syzkaller on 3e5ed8b45e7a561d6344a4d3d7bf3bfb8f24a7b3 testing commit 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 with gcc (GCC) 10.2.1 20210217 kernel signature: 20c455d8a58ab564b3d2acb25c1b998aa7a1929f4ff4fed292c78b6985cb6102 all runs: crashed: WARNING in hsr_forward_skb testing current HEAD b741596468b010af2846b75f5e75a842ce344a6e testing commit b741596468b010af2846b75f5e75a842ce344a6e with gcc (GCC) 10.2.1 20210217 kernel signature: 48b5eeae5a4d4c9ab7ded1c71576067cf1f96dec29f4876e0ba9d9efd6f12aed all runs: OK # git bisect start b741596468b010af2846b75f5e75a842ce344a6e 3af409ca278d4a8d50e91f9f7c4c33b175645cf3 Bisecting: 14591 revisions left to test after this (roughly 14 steps) [aea28a602fa19fb4fe66374030ab7e2c8ddf643e] libbpf: Mark BPF subprogs with hidden visibility as static for BPF verifier testing commit aea28a602fa19fb4fe66374030ab7e2c8ddf643e with gcc (GCC) 10.2.1 20210217 kernel signature: 4ae442c7f31e5a551b51178a2f4101097966b36f1ba9b147ff55df6d1461517e all runs: crashed: WARNING in hsr_forward_skb # git bisect good aea28a602fa19fb4fe66374030ab7e2c8ddf643e Bisecting: 7048 revisions left to test after this (roughly 13 steps) [68a32ba14177d4a21c4a9a941cf1d7aea86d436f] Merge tag 'drm-next-2021-04-28' of git://anongit.freedesktop.org/drm/drm testing commit 68a32ba14177d4a21c4a9a941cf1d7aea86d436f with gcc (GCC) 10.2.1 20210217 kernel signature: 4e2703290b64033c11a8d0d17b412467c083170fa0b04a9507804fb2ddb71d0d all runs: OK # git bisect bad 68a32ba14177d4a21c4a9a941cf1d7aea86d436f Bisecting: 3678 revisions left to test after this (roughly 12 steps) [37f00ab4a003f371f81e0eae76cf372f06dec780] Merge tag 'arm-drivers-5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc testing commit 37f00ab4a003f371f81e0eae76cf372f06dec780 with gcc (GCC) 10.2.1 20210217 kernel signature: 52ddf8313776146b63d74ab9bbb935869ab681e2ae033fe027dfb26d640f369d all runs: OK # git bisect bad 37f00ab4a003f371f81e0eae76cf372f06dec780 Bisecting: 1877 revisions left to test after this (roughly 11 steps) [8e3a3249502d8ff92d73d827fb41dd44c5a16f76] Merge tag 'char-misc-5.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc testing commit 8e3a3249502d8ff92d73d827fb41dd44c5a16f76 with gcc (GCC) 10.2.1 20210217 kernel signature: d3de3ba82de6e91a365e8e3d251a3033880a80d257c96340b7a96e6cd1e6c733 all runs: OK # git bisect bad 8e3a3249502d8ff92d73d827fb41dd44c5a16f76 Bisecting: 992 revisions left to test after this (roughly 10 steps) [682b26bd80f96c2e4da3eb6dcec8bf684b79151c] Merge tag 'sched_urgent_for_v5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip testing commit 682b26bd80f96c2e4da3eb6dcec8bf684b79151c with gcc (GCC) 10.2.1 20210217 kernel signature: 8b03482629be553be7014dacbd272b78fb21faf0b68db74fc4f51ac16bd195cc all runs: OK # git bisect bad 682b26bd80f96c2e4da3eb6dcec8bf684b79151c Bisecting: 511 revisions left to test after this (roughly 9 steps) [3b9784350f990d8fe2ca08978dc25cd5180d5c21] Merge tag 'io_uring-5.12-2021-04-09' of git://git.kernel.dk/linux-block testing commit 3b9784350f990d8fe2ca08978dc25cd5180d5c21 with gcc (GCC) 10.2.1 20210217 kernel signature: 4e3a673350104d2fd12fcddba089f03e5657fd944a9df8f2cc9b3c4fc9369e42 all runs: crashed: WARNING in hsr_forward_skb # git bisect good 3b9784350f990d8fe2ca08978dc25cd5180d5c21 Bisecting: 256 revisions left to test after this (roughly 8 steps) [d5fa1dad75bef69fbff5a193b7a99ada624a0154] Merge tag 'driver-core-5.12-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core testing commit d5fa1dad75bef69fbff5a193b7a99ada624a0154 with gcc (GCC) 10.2.1 20210217 kernel signature: 21f5d7c8bad861c5f21ec42b1315d6d84248c26bdb3a15f83acba31b749c3a48 all runs: OK # git bisect bad d5fa1dad75bef69fbff5a193b7a99ada624a0154 Bisecting: 127 revisions left to test after this (roughly 7 steps) [9d6803921a16f4d768dc41a75375629828f4d91e] net: hsr: Reset MAC header for Tx path testing commit 9d6803921a16f4d768dc41a75375629828f4d91e with gcc (GCC) 10.2.1 20210217 kernel signature: aec6f7b28e5cef1bf0cd175723d558a32399d6d048fa0d9b4726d868ac79e257 all runs: OK # git bisect bad 9d6803921a16f4d768dc41a75375629828f4d91e Bisecting: 63 revisions left to test after this (roughly 6 steps) [3ff3874fa0b261ef74f2bfb008a82ab1601c11eb] net/mlx5e: Guarantee room for XSK wakeup NOP on async ICOSQ testing commit 3ff3874fa0b261ef74f2bfb008a82ab1601c11eb with gcc (GCC) 10.2.1 20210217 kernel signature: 549a9596168f5696126c8e62471263958dde2b96c867eec7091e74f493d91236 all runs: crashed: WARNING in hsr_forward_skb # git bisect good 3ff3874fa0b261ef74f2bfb008a82ab1601c11eb Bisecting: 36 revisions left to test after this (roughly 5 steps) [9256ce33110174decc04caf6ef733409012e5b1c] Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue testing commit 9256ce33110174decc04caf6ef733409012e5b1c with gcc (GCC) 10.2.1 20210217 kernel signature: 8a2f56ed01f4c0ab232e3bb3809fc43f34a8228ff345ac01025198912cf2077e all runs: crashed: WARNING in hsr_forward_skb # git bisect good 9256ce33110174decc04caf6ef733409012e5b1c Bisecting: 18 revisions left to test after this (roughly 4 steps) [9a6aaf61487e6d96ce0bf9b84a784c528dbf6e5e] net: hns3: Remove the left over redundant check & assignment testing commit 9a6aaf61487e6d96ce0bf9b84a784c528dbf6e5e with gcc (GCC) 10.2.1 20210217 kernel signature: e9e46ccddc6368acd98fa9a8e33a81ea423d396166c024e2200ab7b7b98e195b all runs: crashed: WARNING in hsr_forward_skb # git bisect good 9a6aaf61487e6d96ce0bf9b84a784c528dbf6e5e Bisecting: 9 revisions left to test after this (roughly 3 steps) [f57796a4b80be8450a5e8cca1a5f55379cbee328] Merge tag 'linux-can-fixes-for-5.12-20210406' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can testing commit f57796a4b80be8450a5e8cca1a5f55379cbee328 with gcc (GCC) 10.2.1 20210217 kernel signature: da27c755c20227604195b4b2916b8c205108f1358955e53d3e0f2534ef1fc7ab all runs: crashed: WARNING in hsr_forward_skb # git bisect good f57796a4b80be8450a5e8cca1a5f55379cbee328 Bisecting: 4 revisions left to test after this (roughly 2 steps) [0c85a7e87465f2d4cbc768e245f4f45b2f299b05] net/rds: Avoid potential use after free in rds_send_remove_from_sock testing commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 with gcc (GCC) 10.2.1 20210217 kernel signature: 0858961b3d0b0fb6b5486c5d8a9ed96fa64bed769728bfb45d0060e67ffe3567 all runs: crashed: WARNING in hsr_forward_skb # git bisect good 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 Bisecting: 2 revisions left to test after this (roughly 1 step) [83e5feeb385e6d69ae95dd30e0c424afaa17cc6b] ethtool: document reserved fields in the uAPI testing commit 83e5feeb385e6d69ae95dd30e0c424afaa17cc6b with gcc (GCC) 10.2.1 20210217 kernel signature: 0858961b3d0b0fb6b5486c5d8a9ed96fa64bed769728bfb45d0060e67ffe3567 all runs: crashed: WARNING in hsr_forward_skb # git bisect good 83e5feeb385e6d69ae95dd30e0c424afaa17cc6b Bisecting: 0 revisions left to test after this (roughly 1 step) [cd90437399a24ae783b9a3a1a50fe8ee2b717355] Merge branch 'ethtool-doc' testing commit cd90437399a24ae783b9a3a1a50fe8ee2b717355 with gcc (GCC) 10.2.1 20210217 kernel signature: 0858961b3d0b0fb6b5486c5d8a9ed96fa64bed769728bfb45d0060e67ffe3567 all runs: crashed: WARNING in hsr_forward_skb # git bisect good cd90437399a24ae783b9a3a1a50fe8ee2b717355 9d6803921a16f4d768dc41a75375629828f4d91e is the first bad commit commit 9d6803921a16f4d768dc41a75375629828f4d91e Author: Kurt Kanzenbach Date: Tue Apr 6 09:35:09 2021 +0200 net: hsr: Reset MAC header for Tx path Reset MAC header in HSR Tx path. This is needed, because direct packet transmission, e.g. by specifying PACKET_QDISC_BYPASS does not reset the MAC header. This has been observed using the following setup: |$ ip link add name hsr0 type hsr slave1 lan0 slave2 lan1 supervision 45 version 1 |$ ifconfig hsr0 up |$ ./test hsr0 The test binary is using mmap'ed sockets and is specifying the PACKET_QDISC_BYPASS socket option. This patch resolves the following warning on a non-patched kernel: |[ 112.725394] ------------[ cut here ]------------ |[ 112.731418] WARNING: CPU: 1 PID: 257 at net/hsr/hsr_forward.c:560 hsr_forward_skb+0x484/0x568 |[ 112.739962] net/hsr/hsr_forward.c:560: Malformed frame (port_src hsr0) The warning can be safely removed, because the other call sites of hsr_forward_skb() make sure that the skb is prepared correctly. Fixes: d346a3fae3ff ("packet: introduce PACKET_QDISC_BYPASS socket option") Signed-off-by: Kurt Kanzenbach Reviewed-by: Eric Dumazet Signed-off-by: David S. Miller net/hsr/hsr_device.c | 1 + net/hsr/hsr_forward.c | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) culprit signature: aec6f7b28e5cef1bf0cd175723d558a32399d6d048fa0d9b4726d868ac79e257 parent signature: 0858961b3d0b0fb6b5486c5d8a9ed96fa64bed769728bfb45d0060e67ffe3567 revisions tested: 17, total time: 3h39m22.660469374s (build: 2h1m17.534467617s, test: 1h35m58.264594144s) first good commit: 9d6803921a16f4d768dc41a75375629828f4d91e net: hsr: Reset MAC header for Tx path recipients (to): ["davem@davemloft.net" "edumazet@google.com" "kurt@linutronix.de"] recipients (cc): []