bisecting fixing commit since 10d6aa565d0593fe4e152e49ab58f47a2952f902 building syzkaller on 6affd8e838ce8a0c7d72445a7f67fe3bde8bbe04 testing commit 10d6aa565d0593fe4e152e49ab58f47a2952f902 with gcc (GCC) 8.1.0 kernel signature: a15e4052b4366b3eff2c6f90fb5f3705fd73d607 all runs: crashed: WARNING in ovl_rename testing current HEAD c1141b3aab36eb0d9b2bcae4aff69e77d0554386 testing commit c1141b3aab36eb0d9b2bcae4aff69e77d0554386 with gcc (GCC) 8.1.0 kernel signature: 35590a0c34b3fa048b21e8fd4678dee4d159c693 all runs: OK # git bisect start c1141b3aab36eb0d9b2bcae4aff69e77d0554386 10d6aa565d0593fe4e152e49ab58f47a2952f902 Bisecting: 1478 revisions left to test after this (roughly 11 steps) [58b03626a7b19e6f03533cf728a9790241c3362a] soc: qcom: wcnss_ctrl: Avoid string overflow testing commit 58b03626a7b19e6f03533cf728a9790241c3362a with gcc (GCC) 8.1.0 kernel signature: f708133b10f7a0d45d45c2b0b9560c608fbeb806 all runs: crashed: WARNING in ovl_rename # git bisect good 58b03626a7b19e6f03533cf728a9790241c3362a Bisecting: 739 revisions left to test after this (roughly 10 steps) [ed799aa6288884ff34ea5bdb3d13d38086b54a83] i2c: imx: don't print error message on probe defer testing commit ed799aa6288884ff34ea5bdb3d13d38086b54a83 with gcc (GCC) 8.1.0 kernel signature: 9fb13ee31828aa000d3c81f96312eb6e92b8fdf4 all runs: crashed: WARNING in ovl_rename # git bisect good ed799aa6288884ff34ea5bdb3d13d38086b54a83 Bisecting: 369 revisions left to test after this (roughly 9 steps) [e46523a24db0a8c48a072c6f75184f8ff4b222ca] crypto: vmx - Avoid weird build failures testing commit e46523a24db0a8c48a072c6f75184f8ff4b222ca with gcc (GCC) 8.1.0 kernel signature: 296b7ee02fbf866009d0cf5b130b61a91454f95f all runs: OK # git bisect bad e46523a24db0a8c48a072c6f75184f8ff4b222ca Bisecting: 184 revisions left to test after this (roughly 8 steps) [c1a61364fb72a1b2c03ec9fbf9d5329e432956ea] powerpc: Avoid clang warnings around setjmp and longjmp testing commit c1a61364fb72a1b2c03ec9fbf9d5329e432956ea with gcc (GCC) 8.1.0 kernel signature: 91491931e5438f6557524db44ed129d7c0a98f7e all runs: OK # git bisect bad c1a61364fb72a1b2c03ec9fbf9d5329e432956ea Bisecting: 92 revisions left to test after this (roughly 7 steps) [3c64cee83f105ef564348ac06648057987a879c1] staging: rtl8712: fix interface sanity check testing commit 3c64cee83f105ef564348ac06648057987a879c1 with gcc (GCC) 8.1.0 kernel signature: a9ab484b6b60b61685e48837d65dec54f1282a58 all runs: crashed: WARNING in ovl_rename # git bisect good 3c64cee83f105ef564348ac06648057987a879c1 Bisecting: 46 revisions left to test after this (roughly 6 steps) [644d976f0b0032abc548a8a02e145988f33de47b] intel_th: Fix a double put_device() in error path testing commit 644d976f0b0032abc548a8a02e145988f33de47b with gcc (GCC) 8.1.0 kernel signature: 7d2262981928c8ffdfc6fab9f9a7168dd13947e5 all runs: OK # git bisect bad 644d976f0b0032abc548a8a02e145988f33de47b Bisecting: 22 revisions left to test after this (roughly 5 steps) [ebf66f5a00c3483d17261af50bf5f913586ad16f] Btrfs: send, skip backreference walking for extents with many references testing commit ebf66f5a00c3483d17261af50bf5f913586ad16f with gcc (GCC) 8.1.0 kernel signature: ffd8dd8ad72549354bbc8aad805cc185fcd0f124 run #0: crashed: WARNING in ovl_rename run #1: crashed: WARNING in ovl_rename run #2: crashed: WARNING in ovl_rename run #3: crashed: WARNING in ovl_rename run #4: crashed: WARNING in ovl_rename run #5: crashed: WARNING in ovl_rename run #6: crashed: WARNING in ovl_rename run #7: crashed: WARNING in ovl_rename run #8: crashed: WARNING in ovl_rename run #9: OK # git bisect good ebf66f5a00c3483d17261af50bf5f913586ad16f Bisecting: 11 revisions left to test after this (roughly 4 steps) [6b3a529808ab7d3a936d0253d4b3195262af8b83] dm zoned: reduce overhead of backing device checks testing commit 6b3a529808ab7d3a936d0253d4b3195262af8b83 with gcc (GCC) 8.1.0 kernel signature: cc24faa9e68ee3eb8dc626378f3bd68ca989fa5f all runs: OK # git bisect bad 6b3a529808ab7d3a936d0253d4b3195262af8b83 Bisecting: 5 revisions left to test after this (roughly 3 steps) [02072c31e11badb90cc5000fe240ddd2b538570c] lib: raid6: fix awk build warnings testing commit 02072c31e11badb90cc5000fe240ddd2b538570c with gcc (GCC) 8.1.0 kernel signature: 6362ddb1f35f5ef302a89b7051d8fae20aee28e2 all runs: crashed: WARNING in ovl_rename # git bisect good 02072c31e11badb90cc5000fe240ddd2b538570c Bisecting: 2 revisions left to test after this (roughly 2 steps) [8f873b8b1f78a329711b88972c1da53440d6d84a] md/raid0: Fix an error message in raid0_make_request() testing commit 8f873b8b1f78a329711b88972c1da53440d6d84a with gcc (GCC) 8.1.0 kernel signature: be8673c8854c7ff08625cc25cc7dc5f6a3cc27f1 all runs: OK # git bisect bad 8f873b8b1f78a329711b88972c1da53440d6d84a Bisecting: 0 revisions left to test after this (roughly 1 step) [7dc871b7257a7afe05d1a6f145cbd6d69efb6800] ALSA: hda - Fix pending unsol events at shutdown testing commit 7dc871b7257a7afe05d1a6f145cbd6d69efb6800 with gcc (GCC) 8.1.0 kernel signature: 8f8186ffa7e431646bd2cc1d4c88f4e3ded996b3 all runs: OK # git bisect bad 7dc871b7257a7afe05d1a6f145cbd6d69efb6800 Bisecting: 0 revisions left to test after this (roughly 0 steps) [6890751cfea7d79d998b049647a8c49e2f288ed0] ovl: relax WARN_ON() on rename to self testing commit 6890751cfea7d79d998b049647a8c49e2f288ed0 with gcc (GCC) 8.1.0 kernel signature: 4de08e7dd28c05045d03b673aacf8ac315a37cfc all runs: OK # git bisect bad 6890751cfea7d79d998b049647a8c49e2f288ed0 6890751cfea7d79d998b049647a8c49e2f288ed0 is the first bad commit commit 6890751cfea7d79d998b049647a8c49e2f288ed0 Author: Amir Goldstein Date: Fri Dec 6 08:33:36 2019 +0200 ovl: relax WARN_ON() on rename to self commit 6889ee5a53b8d969aa542047f5ac8acdc0e79a91 upstream. In ovl_rename(), if new upper is hardlinked to old upper underneath overlayfs before upper dirs are locked, user will get an ESTALE error and a WARN_ON will be printed. Changes to underlying layers while overlayfs is mounted may result in unexpected behavior, but it shouldn't crash the kernel and it shouldn't trigger WARN_ON() either, so relax this WARN_ON(). Reported-by: syzbot+bb1836a212e69f8e201a@syzkaller.appspotmail.com Fixes: 804032fabb3b ("ovl: don't check rename to self") Cc: # v4.9+ Signed-off-by: Amir Goldstein Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman fs/overlayfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) culprit signature: 4de08e7dd28c05045d03b673aacf8ac315a37cfc parent signature: 6362ddb1f35f5ef302a89b7051d8fae20aee28e2 revisions tested: 14, total time: 3h59m44.251587551s (build: 1h56m59.529476153s, test: 2h1m30.144663585s) first good commit: 6890751cfea7d79d998b049647a8c49e2f288ed0 ovl: relax WARN_ON() on rename to self cc: ["amir73il@gmail.com" "gregkh@linuxfoundation.org" "mszeredi@redhat.com"]