bisecting cause commit starting from d2f8825ab78e4c18686f3e1a756a30255bb00bf3 building syzkaller on 5afa2ddd5aa721e6eea3e51e2f5ed238479eec86 testing commit d2f8825ab78e4c18686f3e1a756a30255bb00bf3 with gcc (GCC) 8.1.0 kernel signature: 821479c4aec5cf48cadf2ef4397a1038d14287a6f85975ec59c22fa4cee58954 all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe testing release v5.6 testing commit 7111951b8d4973bda27ff663f2cf18b663d15b48 with gcc (GCC) 8.1.0 kernel signature: bffa8e2a0b0362b164373902f7a5ef13e485bb165f35ceb71a6ed3cdb7a765c8 all runs: OK # git bisect start d2f8825ab78e4c18686f3e1a756a30255bb00bf3 7111951b8d4973bda27ff663f2cf18b663d15b48 Bisecting: 7231 revisions left to test after this (roughly 13 steps) [f365ab31efacb70bed1e821f7435626e0b2528a6] Merge tag 'drm-next-2020-04-01' of git://anongit.freedesktop.org/drm/drm testing commit f365ab31efacb70bed1e821f7435626e0b2528a6 with gcc (GCC) 8.1.0 kernel signature: 2a6589b1160896929018e200c989b146e06fb7f8c0405efbb8070c7e7d73afbd all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad f365ab31efacb70bed1e821f7435626e0b2528a6 Bisecting: 4110 revisions left to test after this (roughly 12 steps) [56a451b780676bc1cdac011735fe2869fa2e9abf] Merge tag 'ntb-5.7' of git://github.com/jonmason/ntb testing commit 56a451b780676bc1cdac011735fe2869fa2e9abf with gcc (GCC) 8.1.0 kernel signature: c3bf5565ecfb6eeea9956faa27921d8aa8f84a434d24a2269e75626e829e368b all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad 56a451b780676bc1cdac011735fe2869fa2e9abf Bisecting: 1643 revisions left to test after this (roughly 11 steps) [49835c15a55225e9b3ff9cc9317135b334ea2d49] Merge tag 'pm-5.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm testing commit 49835c15a55225e9b3ff9cc9317135b334ea2d49 with gcc (GCC) 8.1.0 kernel signature: 03f0717854b00ce4886a20539fc5181f482fda1cee02adffa76961eca465a0c2 all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad 49835c15a55225e9b3ff9cc9317135b334ea2d49 Bisecting: 934 revisions left to test after this (roughly 10 steps) [063d1942247668eb0bb800aef5afbbef337344be] Merge tag 'media/v5.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media testing commit 063d1942247668eb0bb800aef5afbbef337344be with gcc (GCC) 8.1.0 kernel signature: cc01bff6fe167ef25cb89a018454adb7950b6f76ea270d02e69d72b3241770e6 all runs: OK # git bisect good 063d1942247668eb0bb800aef5afbbef337344be Bisecting: 516 revisions left to test after this (roughly 9 steps) [e681bb287f40e7a9dbcb04cef80fd87a2511ab86] staging: vt6656: Use DIV_ROUND_UP macro instead of specific code testing commit e681bb287f40e7a9dbcb04cef80fd87a2511ab86 with gcc (GCC) 8.1.0 kernel signature: e2398fec46db5143be7c29767a096a53cde854833ea33afc87380f248072b74e all runs: OK # git bisect good e681bb287f40e7a9dbcb04cef80fd87a2511ab86 Bisecting: 266 revisions left to test after this (roughly 8 steps) [db34c5ffee649e2c4c870d1031a996398a187cf5] Merge tag 'usb-5.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb testing commit db34c5ffee649e2c4c870d1031a996398a187cf5 with gcc (GCC) 8.1.0 kernel signature: e89d7a70d21257f795b366e0ce3a3ab89688435a876d10b946c47a9a0cc739b1 all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad db34c5ffee649e2c4c870d1031a996398a187cf5 Bisecting: 121 revisions left to test after this (roughly 7 steps) [a8ab3e76297ea85d92f4ee0833bd469816a13ccf] Merge tag 'usb-for-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next testing commit a8ab3e76297ea85d92f4ee0833bd469816a13ccf with gcc (GCC) 8.1.0 kernel signature: b3984cd5bcd2c73424867bc79fa13b2561aac7e798e21dc0faa435fb8b8ea63d all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad a8ab3e76297ea85d92f4ee0833bd469816a13ccf Bisecting: 63 revisions left to test after this (roughly 6 steps) [d1c6a769cdf466053ae211789f2b0671c8a72331] usb: typec: mux: Allow the mux handles to be requested with fwnode testing commit d1c6a769cdf466053ae211789f2b0671c8a72331 with gcc (GCC) 8.1.0 kernel signature: 9618602f853cf9a0d7cedeb75759a526d401c77891be1572edd7eadcdabaa17f all runs: OK # git bisect good d1c6a769cdf466053ae211789f2b0671c8a72331 Bisecting: 31 revisions left to test after this (roughly 5 steps) [eeead847487f726fa177d0f4060c4f0816ad9cd9] usb: gadget: amd5536udc: fix spelling mistake "reserverd" -> "reserved" testing commit eeead847487f726fa177d0f4060c4f0816ad9cd9 with gcc (GCC) 8.1.0 kernel signature: c6964473613e5e5e2ce91b49cd881e059c08f153108134c8000eef0f6509bc19 all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad eeead847487f726fa177d0f4060c4f0816ad9cd9 Bisecting: 15 revisions left to test after this (roughly 4 steps) [3d157c28d2289edf0439e8308e8de3a06acaaf0e] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode testing commit 3d157c28d2289edf0439e8308e8de3a06acaaf0e with gcc (GCC) 8.1.0 kernel signature: 87c79850d1a5c299a524ef2726eab42f501770770fc824c748d6cbde75d36190 all runs: OK # git bisect good 3d157c28d2289edf0439e8308e8de3a06acaaf0e Bisecting: 7 revisions left to test after this (roughly 3 steps) [0227cc84c44417a29c8102e41db8ec2c11ebc6b2] usb: dwc3: core: don't do suspend for device mode if already suspended testing commit 0227cc84c44417a29c8102e41db8ec2c11ebc6b2 with gcc (GCC) 8.1.0 kernel signature: 9995f43194948ab0247f01cd01539a7c4989cb121a19d3a2467ebf9ec2fb21c2 run #0: OK run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: boot failed: can't ssh into the instance # git bisect good 0227cc84c44417a29c8102e41db8ec2c11ebc6b2 Bisecting: 3 revisions left to test after this (roughly 2 steps) [95b18f28979e12539cc02f6ec4e2c776e8551f39] dt-bindings: usb: dwc2: add compatible property for rk3328 usb testing commit 95b18f28979e12539cc02f6ec4e2c776e8551f39 with gcc (GCC) 8.1.0 kernel signature: e872f9be189673e3125a4b4fc00512e0f341b75c637783544935b1d4d510621a all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad 95b18f28979e12539cc02f6ec4e2c776e8551f39 Bisecting: 1 revision left to test after this (roughly 1 step) [1a0808cb9e417170ed6ab97254cf319dc3e3c310] usb: dwc2: Implement set_selfpowered() testing commit 1a0808cb9e417170ed6ab97254cf319dc3e3c310 with gcc (GCC) 8.1.0 kernel signature: fc9c775557d5c98a26c7c84439053c12f265ed7232879d3f385cab635e6050e4 all runs: OK # git bisect good 1a0808cb9e417170ed6ab97254cf319dc3e3c310 Bisecting: 0 revisions left to test after this (roughly 0 steps) [f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10] usb: gadget: add raw-gadget interface testing commit f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10 with gcc (GCC) 8.1.0 kernel signature: d1dc486f08bf04743a5938967082be5b2fab99f58316c6fe754a9cd889b37423 all runs: crashed: KASAN: slab-out-of-bounds Read in dlfb_usb_probe # git bisect bad f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10 f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10 is the first bad commit commit f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10 Author: Andrey Konovalov Date: Mon Feb 24 17:13:03 2020 +0100 usb: gadget: add raw-gadget interface USB Raw Gadget is a kernel module that provides a userspace interface for the USB Gadget subsystem. Essentially it allows to emulate USB devices from userspace. Enabled with CONFIG_USB_RAW_GADGET. Raw Gadget is currently a strictly debugging feature and shouldn't be used in production. Raw Gadget is similar to GadgetFS, but provides a more low-level and direct access to the USB Gadget layer for the userspace. The key differences are: 1. Every USB request is passed to the userspace to get a response, while GadgetFS responds to some USB requests internally based on the provided descriptors. However note, that the UDC driver might respond to some requests on its own and never forward them to the Gadget layer. 2. GadgetFS performs some sanity checks on the provided USB descriptors, while Raw Gadget allows you to provide arbitrary data as responses to USB requests. 3. Raw Gadget provides a way to select a UDC device/driver to bind to, while GadgetFS currently binds to the first available UDC. 4. Raw Gadget uses predictable endpoint names (handles) across different UDCs (as long as UDCs have enough endpoints of each required transfer type). 5. Raw Gadget has ioctl-based interface instead of a filesystem-based one. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Andrey Konovalov Signed-off-by: Felipe Balbi Documentation/usb/index.rst | 1 + Documentation/usb/raw-gadget.rst | 61 ++ drivers/usb/gadget/legacy/Kconfig | 11 + drivers/usb/gadget/legacy/Makefile | 1 + drivers/usb/gadget/legacy/raw_gadget.c | 1078 ++++++++++++++++++++++++++++++++ include/uapi/linux/usb/raw_gadget.h | 167 +++++ 6 files changed, 1319 insertions(+) create mode 100644 Documentation/usb/raw-gadget.rst create mode 100644 drivers/usb/gadget/legacy/raw_gadget.c create mode 100644 include/uapi/linux/usb/raw_gadget.h culprit signature: d1dc486f08bf04743a5938967082be5b2fab99f58316c6fe754a9cd889b37423 parent signature: fc9c775557d5c98a26c7c84439053c12f265ed7232879d3f385cab635e6050e4 revisions tested: 16, total time: 3h30m3.029441468s (build: 1h46m34.543756024s, test: 1h41m52.305465841s) first bad commit: f2c2e717642c66f7fe7e5dd69b2e8ff5849f4d10 usb: gadget: add raw-gadget interface cc: ["andreyknvl@google.com" "balbi@kernel.org" "gregkh@linuxfoundation.org"] crash: KASAN: slab-out-of-bounds Read in dlfb_usb_probe ================================================================== BUG: KASAN: slab-out-of-bounds in hex_string+0x389/0x500 lib/vsprintf.c:1137 Read of size 1 at addr ffff8880a30ae69b by task kworker/0:2/2661 CPU: 0 PID: 2661 Comm: kworker/0:2 Not tainted 5.6.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x128/0x182 lib/dump_stack.c:118 print_address_description.constprop.8.cold.10+0x9/0x317 mm/kasan/report.c:374 __kasan_report.cold.11+0x1c/0x34 mm/kasan/report.c:506 kasan_report+0xe/0x20 mm/kasan/common.c:641 hex_string+0x389/0x500 lib/vsprintf.c:1137 pointer+0x145/0x510 lib/vsprintf.c:2193 vsnprintf+0x3f7/0x1190 lib/vsprintf.c:2578 va_format.isra.10+0xf7/0x160 lib/vsprintf.c:1652 pointer+0x224/0x510 lib/vsprintf.c:2221 vsnprintf+0x3f7/0x1190 lib/vsprintf.c:2578 vscnprintf+0x9/0x30 lib/vsprintf.c:2677 vprintk_store+0x34/0x360 kernel/printk/printk.c:1917 vprintk_emit+0xfc/0x560 kernel/printk/printk.c:1978 dev_vprintk_emit+0x400/0x445 drivers/base/core.c:3616 dev_printk_emit+0x90/0xb6 drivers/base/core.c:3627 _dev_info+0xc8/0xf6 drivers/base/core.c:3685 dlfb_parse_vendor_descriptor drivers/video/fbdev/udlfb.c:1589 [inline] dlfb_usb_probe.cold.23+0xea7/0x1a0a drivers/video/fbdev/udlfb.c:1672 usb_probe_interface+0x268/0x6c0 drivers/usb/core/driver.c:361 really_probe+0x1f9/0x5e0 drivers/base/dd.c:551 driver_probe_device+0xc9/0x1b0 drivers/base/dd.c:724 bus_for_each_drv+0x117/0x1a0 drivers/base/bus.c:431 __device_attach+0x1be/0x2c0 drivers/base/dd.c:897 bus_probe_device+0x19e/0x250 drivers/base/bus.c:491 device_add+0x10d0/0x1900 drivers/base/core.c:2500 usb_set_configuration+0xc02/0x1560 drivers/usb/core/message.c:2023 generic_probe+0x61/0x8a drivers/usb/core/generic.c:210 really_probe+0x1f9/0x5e0 drivers/base/dd.c:551 driver_probe_device+0xc9/0x1b0 drivers/base/dd.c:724 bus_for_each_drv+0x117/0x1a0 drivers/base/bus.c:431 __device_attach+0x1be/0x2c0 drivers/base/dd.c:897 bus_probe_device+0x19e/0x250 drivers/base/bus.c:491 device_add+0x10d0/0x1900 drivers/base/core.c:2500 usb_new_device.cold.66+0x679/0xe85 drivers/usb/core/hub.c:2548 hub_port_connect drivers/usb/core/hub.c:5195 [inline] hub_port_connect_change drivers/usb/core/hub.c:5335 [inline] port_event drivers/usb/core/hub.c:5481 [inline] hub_event+0x15fe/0x2d60 drivers/usb/core/hub.c:5563 process_one_work+0x903/0x15c0 kernel/workqueue.c:2264 worker_thread+0x82/0xb50 kernel/workqueue.c:2410 kthread+0x31d/0x3e0 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Allocated by task 2661: save_stack+0x19/0x80 mm/kasan/common.c:72 set_track mm/kasan/common.c:80 [inline] __kasan_kmalloc.constprop.17+0xc1/0xd0 mm/kasan/common.c:515 __do_kmalloc mm/slab.c:3656 [inline] __kmalloc+0x164/0x7b0 mm/slab.c:3665 kmalloc include/linux/slab.h:560 [inline] usb_get_configuration+0x2a9/0x3880 drivers/usb/core/config.c:919 usb_enumerate_device drivers/usb/core/hub.c:2381 [inline] usb_new_device+0x345/0x6d0 drivers/usb/core/hub.c:2517 hub_port_connect drivers/usb/core/hub.c:5195 [inline] hub_port_connect_change drivers/usb/core/hub.c:5335 [inline] port_event drivers/usb/core/hub.c:5481 [inline] hub_event+0x15fe/0x2d60 drivers/usb/core/hub.c:5563 process_one_work+0x903/0x15c0 kernel/workqueue.c:2264 worker_thread+0x82/0xb50 kernel/workqueue.c:2410 kthread+0x31d/0x3e0 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Freed by task 6995: save_stack+0x19/0x80 mm/kasan/common.c:72 set_track mm/kasan/common.c:80 [inline] kasan_set_free_info mm/kasan/common.c:337 [inline] __kasan_slab_free+0xf7/0x140 mm/kasan/common.c:476 __cache_free mm/slab.c:3426 [inline] kfree+0x107/0x2b0 mm/slab.c:3757 tomoyo_add_entry security/tomoyo/common.c:2045 [inline] tomoyo_supervisor+0x9aa/0xc10 security/tomoyo/common.c:2103 tomoyo_audit_path_log security/tomoyo/file.c:168 [inline] tomoyo_path_permission+0x244/0x340 security/tomoyo/file.c:587 tomoyo_path_perm+0x2a2/0x370 security/tomoyo/file.c:838 security_inode_getattr+0xab/0x100 security/security.c:1254 vfs_getattr+0x17/0x40 fs/stat.c:117 vfs_statx+0xcb/0x130 fs/stat.c:201 vfs_fstatat include/linux/fs.h:3282 [inline] __do_sys_newfstatat+0x6f/0xc0 fs/stat.c:378 do_syscall_64+0xc6/0x620 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe The buggy address belongs to the object at ffff8880a30ae680 which belongs to the cache kmalloc-32 of size 32 The buggy address is located 27 bytes inside of 32-byte region [ffff8880a30ae680, ffff8880a30ae6a0) The buggy address belongs to the page: page:ffffea00028c2b80 refcount:1 mapcount:0 mapping:ffff8880aa4001c0 index:0xffff8880a30aefc1 flags: 0xfffe0000000200(slab) raw: 00fffe0000000200 ffffea00027830c8 ffffea00029bf4c8 ffff8880aa4001c0 raw: ffff8880a30aefc1 ffff8880a30ae000 000000010000003f 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff8880a30ae580: fb fb fb fb fc fc fc fc 00 00 01 fc fc fc fc fc ffff8880a30ae600: 00 00 01 fc fc fc fc fc fb fb fb fb fc fc fc fc >ffff8880a30ae680: 00 00 00 03 fc fc fc fc fb fb fb fb fc fc fc fc ^ ffff8880a30ae700: fb fb fb fb fc fc fc fc 00 00 01 fc fc fc fc fc ffff8880a30ae780: fb fb fb fb fc fc fc fc 00 01 fc fc fc fc fc fc ==================================================================