bisecting fixing commit since 1127b219ce9481c84edad9711626d856127d5e51 building syzkaller on d5a3ae1f760e7cb2cd5a721d9645ae22eae114fe testing commit 1127b219ce9481c84edad9711626d856127d5e51 with gcc (GCC) 8.1.0 kernel signature: 382f52c9d4449d7e54c17f4dcb0a72107119e01f62531a03ebb9d4b5299a2ed8 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy testing current HEAD c85fb28b6f999db9928b841f63f1beeb3074eeca testing commit c85fb28b6f999db9928b841f63f1beeb3074eeca with gcc (GCC) 8.1.0 kernel signature: eea01ed75cdb3401f12e6f0108e6dafdcdc605a99aa77bfde69db1d2ea0be627 all runs: OK # git bisect start c85fb28b6f999db9928b841f63f1beeb3074eeca 1127b219ce9481c84edad9711626d856127d5e51 Bisecting: 825 revisions left to test after this (roughly 10 steps) [97cf32996c46d9935cc133d910a75fb687dd6144] drm/amd/pm: Removed fixed clock in auto mode DPM testing commit 97cf32996c46d9935cc133d910a75fb687dd6144 with gcc (GCC) 8.1.0 kernel signature: d0aeea0436edbf9677589f21f14c643b090d930dac086a111beb1deee3b7a3ed all runs: OK # git bisect bad 97cf32996c46d9935cc133d910a75fb687dd6144 Bisecting: 406 revisions left to test after this (roughly 9 steps) [8075fc3b113dee1531106aaec3dfa19c8158374d] Merge tag 'block-5.9-2020-09-04' of git://git.kernel.dk/linux-block testing commit 8075fc3b113dee1531106aaec3dfa19c8158374d with gcc (GCC) 8.1.0 kernel signature: 5b80da8abd357cd4431be14b1820440b2f2752191afaf0396f25714492e4dce0 all runs: OK # git bisect bad 8075fc3b113dee1531106aaec3dfa19c8158374d Bisecting: 222 revisions left to test after this (roughly 8 steps) [830fadfd954c6782b7a8a2461c76a568c7153b9a] perf tools: Add bpf image check to __map__is_kmodule testing commit 830fadfd954c6782b7a8a2461c76a568c7153b9a with gcc (GCC) 8.1.0 kernel signature: 049a6507af982f8c25ac462f00d9889d4d54741161467f4e05b9f4eb2cc95f09 all runs: OK # git bisect bad 830fadfd954c6782b7a8a2461c76a568c7153b9a Bisecting: 97 revisions left to test after this (roughly 7 steps) [f75aef392f869018f78cfedf3c320a6b3fcfda6b] Linux 5.9-rc3 testing commit f75aef392f869018f78cfedf3c320a6b3fcfda6b with gcc (GCC) 8.1.0 kernel signature: 8600d9f86aa4839945867afd36f7619313fb419b52895086d4eedcf76af39cc5 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good f75aef392f869018f78cfedf3c320a6b3fcfda6b Bisecting: 43 revisions left to test after this (roughly 6 steps) [9c7d619be5a002ea29c172df5e3c1227c22cbb41] Merge tag 'perf-tools-fixes-for-v5.9-2020-09-01' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux testing commit 9c7d619be5a002ea29c172df5e3c1227c22cbb41 with gcc (GCC) 8.1.0 kernel signature: 0df69c2b6cfe9faa220d21d38567c9d12830d9cbaca05a35716abcf67ef434b2 all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good 9c7d619be5a002ea29c172df5e3c1227c22cbb41 Bisecting: 22 revisions left to test after this (roughly 5 steps) [fc3abb53250a90ba2150eebd182137c136f4d25a] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid testing commit fc3abb53250a90ba2150eebd182137c136f4d25a with gcc (GCC) 8.1.0 kernel signature: c51dc10847bbf5a1bff3730059be972520e26b23fc7d6b10d981da6b34ceee45 all runs: OK # git bisect bad fc3abb53250a90ba2150eebd182137c136f4d25a Bisecting: 13 revisions left to test after this (roughly 3 steps) [3a653b205f29b3f9827a01a0c88bfbcb0d169494] dm thin metadata: Fix use-after-free in dm_bm_set_read_only testing commit 3a653b205f29b3f9827a01a0c88bfbcb0d169494 with gcc (GCC) 8.1.0 kernel signature: 87e9d9ea4a7499eebe86508d94acc966636a90425108b2376f025f7b56861b27 run #0: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #1: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #2: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #3: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #4: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #5: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #6: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #7: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #8: crashed: INFO: trying to register non-static key in uhid_dev_destroy run #9: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor705229012" "root@10.128.15.197:./syz-executor705229012"]: exit status 1 ssh: connect to host 10.128.15.197 port 22: Connection timed out lost connection # git bisect good 3a653b205f29b3f9827a01a0c88bfbcb0d169494 Bisecting: 6 revisions left to test after this (roughly 3 steps) [e1d0126ca3a66c284a02b083a42e2b39558002cd] Merge tag 'xfs-5.9-fixes-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux testing commit e1d0126ca3a66c284a02b083a42e2b39558002cd with gcc (GCC) 8.1.0 kernel signature: 5d5bf886996e5a27ced0b1fe59e082d583132798f54318ed18c865c33207c5cb all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good e1d0126ca3a66c284a02b083a42e2b39558002cd Bisecting: 3 revisions left to test after this (roughly 2 steps) [b7429ea53d6c0936a0f10a5d64164f0aea440143] HID: elan: Fix memleak in elan_input_configured testing commit b7429ea53d6c0936a0f10a5d64164f0aea440143 with gcc (GCC) 8.1.0 kernel signature: 8427e8f35cd0414767fe05b3fd89803f5883885da9f97aadc721ac5f7832be0f all runs: crashed: INFO: trying to register non-static key in uhid_dev_destroy # git bisect good b7429ea53d6c0936a0f10a5d64164f0aea440143 Bisecting: 1 revision left to test after this (roughly 1 step) [35556bed836f8dc07ac55f69c8d17dce3e7f0e25] HID: core: Sanitize event code and type when mapping input testing commit 35556bed836f8dc07ac55f69c8d17dce3e7f0e25 with gcc (GCC) 8.1.0 kernel signature: 990b517645e641e5480949914ece668600e22e88c59e8f65f307a02f2642b173 all runs: OK # git bisect bad 35556bed836f8dc07ac55f69c8d17dce3e7f0e25 Bisecting: 0 revisions left to test after this (roughly 0 steps) [bce1305c0ece3dc549663605e567655dd701752c] HID: core: Correctly handle ReportSize being zero testing commit bce1305c0ece3dc549663605e567655dd701752c with gcc (GCC) 8.1.0 kernel signature: 1a3acb6cbb8fccc9e82002b4d525986327a895ef532edce000173b8b9fb3d33e all runs: OK # git bisect bad bce1305c0ece3dc549663605e567655dd701752c bce1305c0ece3dc549663605e567655dd701752c is the first bad commit commit bce1305c0ece3dc549663605e567655dd701752c Author: Marc Zyngier Date: Sat Aug 29 12:26:01 2020 +0100 HID: core: Correctly handle ReportSize being zero It appears that a ReportSize value of zero is legal, even if a bit non-sensical. Most of the HID code seems to handle that gracefully, except when computing the total size in bytes. When fed as input to memset, this leads to some funky outcomes. Detect the corner case and correctly compute the size. Cc: stable@vger.kernel.org Signed-off-by: Marc Zyngier Signed-off-by: Benjamin Tissoires drivers/hid/hid-core.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) culprit signature: 1a3acb6cbb8fccc9e82002b4d525986327a895ef532edce000173b8b9fb3d33e parent signature: 8427e8f35cd0414767fe05b3fd89803f5883885da9f97aadc721ac5f7832be0f revisions tested: 13, total time: 2h40m2.671417199s (build: 1h5m9.06531678s, test: 1h33m35.271529762s) first good commit: bce1305c0ece3dc549663605e567655dd701752c HID: core: Correctly handle ReportSize being zero recipients (to): ["benjamin.tissoires@gmail.com" "benjamin.tissoires@redhat.com" "jikos@kernel.org" "linux-input@vger.kernel.org" "maz@kernel.org"] recipients (cc): ["linux-kernel@vger.kernel.org"]