bisecting fixing commit since 04a1320651757c78277bea48bec97f0d43e6b17b building syzkaller on 49f3583951e3febc6a93b6e3b4cd213649a6b3c9 testing commit 04a1320651757c78277bea48bec97f0d43e6b17b with gcc (GCC) 8.1.0 all runs: crashed: general protection fault in bpf_tcp_close testing current HEAD 4b6f23161b4e888e72671e377c32eabe9a8e62fc testing commit 4b6f23161b4e888e72671e377c32eabe9a8e62fc with gcc (GCC) 8.1.0 run #0: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor478098828" "root@10.128.10.17:./syz-executor478098828"]: exit status 1 ssh: connect to host 10.128.10.17 port 22: Connection timed out lost connection run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect start 4b6f23161b4e888e72671e377c32eabe9a8e62fc 04a1320651757c78277bea48bec97f0d43e6b17b Bisecting: 44157 revisions left to test after this (roughly 16 steps) [ec7146db150082737cbfeacaae0f33e42c95cf18] Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next testing commit ec7146db150082737cbfeacaae0f33e42c95cf18 with gcc (GCC) 8.1.0 all runs: boot failed: KASAN: use-after-free Read in generic_make_request # git bisect skip ec7146db150082737cbfeacaae0f33e42c95cf18 Bisecting: 44157 revisions left to test after this (roughly 16 steps) [5135d5efcbb439c2acb20d6197dd57af3a456e76] perf tools: Add cpu_topology object testing commit 5135d5efcbb439c2acb20d6197dd57af3a456e76 with gcc (GCC) 8.1.0 all runs: OK # git bisect bad 5135d5efcbb439c2acb20d6197dd57af3a456e76 Bisecting: 22009 revisions left to test after this (roughly 15 steps) [0d1e8b8d2bcd3150d51754d8d0fdbf44dc88b0d3] Merge tag 'kvm-4.20-1' of git://git.kernel.org/pub/scm/virt/kvm/kvm testing commit 0d1e8b8d2bcd3150d51754d8d0fdbf44dc88b0d3 with gcc (GCC) 8.1.0 all runs: OK # git bisect bad 0d1e8b8d2bcd3150d51754d8d0fdbf44dc88b0d3 Bisecting: 11002 revisions left to test after this (roughly 14 steps) [d5acba26bfa097a618be425522b1ec4269d3edaf] Merge tag 'char-misc-4.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc testing commit d5acba26bfa097a618be425522b1ec4269d3edaf with gcc (GCC) 8.1.0 all runs: crashed: general protection fault in bpf_tcp_close # git bisect good d5acba26bfa097a618be425522b1ec4269d3edaf Bisecting: 5493 revisions left to test after this (roughly 13 steps) [ca9eb48fe01fa7fa60ff9f2196b1bd0d84dc81af] Merge tag 'regulator-v5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator testing commit ca9eb48fe01fa7fa60ff9f2196b1bd0d84dc81af with gcc (GCC) 8.1.0 all runs: OK # git bisect bad ca9eb48fe01fa7fa60ff9f2196b1bd0d84dc81af Bisecting: 2747 revisions left to test after this (roughly 12 steps) [d207ea8e74ff45be0838afa12bdd2492fa9dc8bc] Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip testing commit d207ea8e74ff45be0838afa12bdd2492fa9dc8bc with gcc (GCC) 8.1.0 all runs: crashed: general protection fault in bpf_tcp_close # git bisect good d207ea8e74ff45be0838afa12bdd2492fa9dc8bc Bisecting: 1373 revisions left to test after this (roughly 11 steps) [3548fcf7d877c682c9a5a413c51929739192156d] qlogic: netxen: remove ndo_poll_controller testing commit 3548fcf7d877c682c9a5a413c51929739192156d with gcc (GCC) 8.1.0 all runs: OK # git bisect bad 3548fcf7d877c682c9a5a413c51929739192156d Bisecting: 668 revisions left to test after this (roughly 10 steps) [67b076095dd7a13ff24e9b5f830fcb1291ae0678] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net testing commit 67b076095dd7a13ff24e9b5f830fcb1291ae0678 with gcc (GCC) 8.1.0 run #0: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor290446198" "root@10.128.0.71:./syz-executor290446198"]: exit status 1 ssh: connect to host 10.128.0.71 port 22: Connection timed out lost connection run #1: crashed: general protection fault in tcp_cleanup_ulp run #2: crashed: general protection fault in tcp_cleanup_ulp run #3: crashed: general protection fault in tcp_cleanup_ulp run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 67b076095dd7a13ff24e9b5f830fcb1291ae0678 Bisecting: 333 revisions left to test after this (roughly 8 steps) [126d6848ef13958e1cb959e96c21d19bc498ade9] sfp: fix oops with ethtool -m testing commit 126d6848ef13958e1cb959e96c21d19bc498ade9 with gcc (GCC) 8.1.0 run #0: crashed: general protection fault in tcp_cleanup_ulp run #1: OK run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: crashed: general protection fault in tcp_cleanup_ulp run #9: OK # git bisect good 126d6848ef13958e1cb959e96c21d19bc498ade9 Bisecting: 169 revisions left to test after this (roughly 7 steps) [6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84] Linux 4.19-rc5 testing commit 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84 with gcc (GCC) 8.1.0 run #0: crashed: general protection fault in tcp_cleanup_ulp run #1: crashed: general protection fault in tcp_cleanup_ulp run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84 Bisecting: 83 revisions left to test after this (roughly 6 steps) [fc0c8146680e362ebeaed0294b869425cc18230e] Merge tag 'char-misc-4.19-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc testing commit fc0c8146680e362ebeaed0294b869425cc18230e with gcc (GCC) 8.1.0 all runs: OK # git bisect bad fc0c8146680e362ebeaed0294b869425cc18230e Bisecting: 42 revisions left to test after this (roughly 6 steps) [93f62ad5e83a13e0c224dfca5ef40f90c09aad51] bonding: use netpoll_poll_dev() helper testing commit 93f62ad5e83a13e0c224dfca5ef40f90c09aad51 with gcc (GCC) 8.1.0 all runs: OK # git bisect bad 93f62ad5e83a13e0c224dfca5ef40f90c09aad51 Bisecting: 21 revisions left to test after this (roughly 5 steps) [bffd5e86951c43e87abf12157e4d6ff7dc37cec9] Merge branch 'qed-fixes' testing commit bffd5e86951c43e87abf12157e4d6ff7dc37cec9 with gcc (GCC) 8.1.0 run #0: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor624455403" "root@10.128.10.51:./syz-executor624455403"]: exit status 1 ssh: connect to host 10.128.10.51 port 22: Connection timed out lost connection run #1: crashed: general protection fault in tcp_cleanup_ulp run #2: OK run #3: OK run #4: OK run #5: OK run #6: crashed: general protection fault in tcp_cleanup_ulp run #7: OK run #8: crashed: general protection fault in tcp_cleanup_ulp run #9: OK # git bisect good bffd5e86951c43e87abf12157e4d6ff7dc37cec9 Bisecting: 10 revisions left to test after this (roughly 4 steps) [f3bf939f3d4552becb115d76e17b3e5957bab4a2] net: cirrus: fix return type of ndo_start_xmit function testing commit f3bf939f3d4552becb115d76e17b3e5957bab4a2 with gcc (GCC) 8.1.0 run #0: crashed: general protection fault in tcp_cleanup_ulp run #1: crashed: general protection fault in tcp_cleanup_ulp run #2: crashed: general protection fault in tcp_cleanup_ulp run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good f3bf939f3d4552becb115d76e17b3e5957bab4a2 Bisecting: 5 revisions left to test after this (roughly 3 steps) [83fe9a966111b51a34f10c35e568e45bff34de48] devlink: double free in devlink_resource_fill() testing commit 83fe9a966111b51a34f10c35e568e45bff34de48 with gcc (GCC) 8.1.0 run #0: crashed: general protection fault in tcp_cleanup_ulp run #1: crashed: general protection fault in tcp_cleanup_ulp run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: OK # git bisect good 83fe9a966111b51a34f10c35e568e45bff34de48 Bisecting: 2 revisions left to test after this (roughly 2 steps) [474ff2600889e16280dbc6ada8bfecb216169a70] net-ethtool: ETHTOOL_GUFO did not and should not require CAP_NET_ADMIN testing commit 474ff2600889e16280dbc6ada8bfecb216169a70 with gcc (GCC) 8.1.0 failed to run ["make" "bzImage" "-j" "64" "CC=/syzkaller/bisect_bin/gcc-8.1.0/bin/gcc"]: exit status 2 # git bisect skip 474ff2600889e16280dbc6ada8bfecb216169a70 Bisecting: 2 revisions left to test after this (roughly 2 steps) [8360ed6745df6de2d8ddff8e2116789258fe5890] RDS: IB: Use DEFINE_PER_CPU_SHARED_ALIGNED for rds_ib_stats testing commit 8360ed6745df6de2d8ddff8e2116789258fe5890 with gcc (GCC) 8.1.0 failed to run ["make" "bzImage" "-j" "64" "CC=/syzkaller/bisect_bin/gcc-8.1.0/bin/gcc"]: exit status 2 # git bisect skip 8360ed6745df6de2d8ddff8e2116789258fe5890 Bisecting: 2 revisions left to test after this (roughly 2 steps) [16fdf8ba98391650ce4bc4f3f71629d8a413bc21] rds: Fix build regression. testing commit 16fdf8ba98391650ce4bc4f3f71629d8a413bc21 with gcc (GCC) 8.1.0 run #0: crashed: general protection fault in tcp_cleanup_ulp run #1: basic kernel testing failed: failed to copy test binary to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "BatchMode=yes" "-o" "IdentitiesOnly=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-i" "/syzkaller/jobs/linux/workdir/image/key" "/tmp/syz-executor544791278" "root@10.128.1.47:./syz-executor544791278"]: exit status 1 ssh: connect to host 10.128.1.47 port 22: Connection timed out lost connection run #2: OK run #3: OK run #4: OK run #5: OK run #6: OK run #7: OK run #8: OK run #9: crashed: general protection fault in tcp_cleanup_ulp # git bisect good 16fdf8ba98391650ce4bc4f3f71629d8a413bc21 Bisecting: 0 revisions left to test after this (roughly 0 steps) [ac3d9dd034e565df2c034ab2ca71f0a9f69153c1] netpoll: make ndo_poll_controller() optional testing commit ac3d9dd034e565df2c034ab2ca71f0a9f69153c1 with gcc (GCC) 8.1.0 all runs: OK # git bisect bad ac3d9dd034e565df2c034ab2ca71f0a9f69153c1 ac3d9dd034e565df2c034ab2ca71f0a9f69153c1 is the first bad commit commit ac3d9dd034e565df2c034ab2ca71f0a9f69153c1 Author: Eric Dumazet Date: Fri Sep 21 15:27:38 2018 -0700 netpoll: make ndo_poll_controller() optional As diagnosed by Song Liu, ndo_poll_controller() can be very dangerous on loaded hosts, since the cpu calling ndo_poll_controller() might steal all NAPI contexts (for all RX/TX queues of the NIC). This capture can last for unlimited amount of time, since one cpu is generally not able to drain all the queues under load. It seems that all networking drivers that do use NAPI for their TX completions, should not provide a ndo_poll_controller(). NAPI drivers have netpoll support already handled in core networking stack, since netpoll_poll_dev() uses poll_napi(dev) to iterate through registered NAPI contexts for a device. This patch allows netpoll_poll_dev() to process NAPI contexts even for drivers not providing ndo_poll_controller(), allowing for following patches in NAPI drivers. Also we export netpoll_poll_dev() so that it can be called by bonding/team drivers in following patches. Reported-by: Song Liu Signed-off-by: Eric Dumazet Tested-by: Song Liu Signed-off-by: David S. Miller :040000 040000 17eac10f1de2fcdf99aa92248cd87507718ae6c3 ee4af3a131d17578b6822adbee1935ef36c310e0 M include :040000 040000 6dfe4fbc024c0091e25665550dfb7fac22b7cc75 cfcbf802aa4f6f3a158d46f1e7e70ad2e4285e38 M net revisions tested: 21, total time: 5h13m42.046380875s (build: 1h45m42.235024593s, test: 3h19m0.034885106s) first good commit: ac3d9dd034e565df2c034ab2ca71f0a9f69153c1 netpoll: make ndo_poll_controller() optional cc: ["davem@davemloft.net" "dbanerje@akamai.com" "edumazet@google.com" "fw@strlen.de" "linux-kernel@vger.kernel.org" "matwey@sai.msu.ru" "netdev@vger.kernel.org" "pabeni@redhat.com" "paulmck@linux.ibm.com" "rppt@linux.ibm.com" "sakari.ailus@linux.intel.com" "songliubraving@fb.com" "tglx@linutronix.de"]